superreview granted: [Bug 233094] [FIX]input text doesn't appear in text box if text box is in floated cell : [Attachment 140654] This fixes all three testcases and the website

David Baron <dbaron@dbaron.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s
request for superreview:
Bug 233094: [FIX]input text doesn't appear in text box if text box is in
floated cell
http://bugzilla.mozilla.org/show_bug.cgi?id=233094

Attachment 140654: This fixes all three testcases and the website
http://bugzilla.mozilla.org/attachment.cgi?id=140654&action=edit

------- Additional Comments from David Baron <dbaron@dbaron.org>
I'm not crazy about any of the table pseudo frame construction code, and I
don't remember my previous objection to this patch, but r+sr=dbaron.
0
bugzilla
4/23/2004 11:20:21 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
821 Views

Similar Articles

[PageSpeed] 44
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 233094] [FIX]input text doesn't appear in text box if text box is in floated cell : [Attachment 140654] This fixes all three testcases and the website
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 233094: [FIX]input text doesn't appear in text box if text box is in floated cell http://bugzilla.mozilla.org/show_bug.cgi?id=233094 Attachment 140654: This fixes all three testcases and the website http://bugzilla.mozilla.org/attachment.cgi?id=140654&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> David, what do you think? ...

superreview granted: [Bug 285138] Spellchecker doesn't skip quoted text in plain text editor : [Attachment 179753] fix based on daniel's review comment
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 285138: Spellchecker doesn't skip quoted text in plain text editor https://bugzilla.mozilla.org/show_bug.cgi?id=285138 Attachment 179753: fix based on daniel's review comment https://bugzilla.mozilla.org/attachment.cgi?id=179753&action=edit ...

superreview granted: [Bug 285138] Spellchecker doesn't skip quoted text in plain text editor : [Attachment 179336] the fix
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 285138: Spellchecker doesn't skip quoted text in plain text editor https://bugzilla.mozilla.org/show_bug.cgi?id=285138 Attachment 179336: the fix https://bugzilla.mozilla.org/attachment.cgi?id=179336&action=edit ...

superreview granted: [Bug 300027] [FIX]text document on Web sent as mail attachment has MIME type application/x-vnd.mozilla.maybe-text : [Attachment 188859] Patch to fix
Darin Fisher <darin@meer.net> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 300027: [FIX]text document on Web sent as mail attachment has MIME type application/x-vnd.mozilla.maybe-text https://bugzilla.mozilla.org/show_bug.cgi?id=300027 Attachment 188859: Patch to fix https://bugzilla.mozilla.org/attachment.cgi?id=188859&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> Looks good to me, sr=darin ...

superreview granted: [Bug 290469] Strange behaviour when highlighting text in text box : [Attachment 181091] fix
Boris Zbarsky <bzbarsky@mit.edu> has granted Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 290469: Strange behaviour when highlighting text in text box https://bugzilla.mozilla.org/show_bug.cgi?id=290469 Attachment 181091: fix https://bugzilla.mozilla.org/attachment.cgi?id=181091&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, but shouldn't we check over other callers of GetOffsetFromView if they're using the offset for anything? ...

superreview granted: [Bug 399410] [FIX]composer text box doesn' t scroll down when typing past end of last line
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu>'s request for superreview: Bug 399410: [FIX]composer text box doesn't scroll down when typing past end of last line https://bugzilla.mozilla.org/show_bug.cgi?id=399410 Attachment 284573: This fixes it, even in the face of reentry. https://bugzilla.mozilla.org/attachment.cgi?id=284573&action=edit ...

superreview granted: [Bug 399410] [FIX]composer text box doesn' t scroll down when typing past end of last line #2
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu>'s request for superreview: Bug 399410: [FIX]composer text box doesn't scroll down when typing past end of last line https://bugzilla.mozilla.org/show_bug.cgi?id=399410 Attachment 287056: Need to handle destruction https://bugzilla.mozilla.org/attachment.cgi?id=287056&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> Do I want to know how GetPositionAndSize can kill the frame? Can it r...

superreview granted: [Bug 252783] [FIX] text input doesn't consider letter-spacing for sizing : [Attachment 154138] Patch rev. 1
David Baron <dbaron@dbaron.org> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 252783: [FIX] text input doesn't consider letter-spacing for sizing http://bugzilla.mozilla.org/show_bug.cgi?id=252783 Attachment 154138: Patch rev. 1 http://bugzilla.mozilla.org/attachment.cgi?id=154138&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> >+ // Increment width with cols * letter-spacing. >+ { >+ const nsStyleText* textStyle = GetStyleText(); >+ if (eStyleUnit_Coord == textS...

superreview granted: [Bug 252783] [FIX] text input doesn't consider letter-spacing for sizing : [Attachment 154151] Patch rev. 2
Mats Palmgren <mats.palmgren@bredband.net> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 252783: [FIX] text input doesn't consider letter-spacing for sizing http://bugzilla.mozilla.org/show_bug.cgi?id=252783 Attachment 154151: Patch rev. 2 http://bugzilla.mozilla.org/attachment.cgi?id=154151&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Moving sr=dbaron from comment 5 ...

superreview requested: [Bug 433192] Ctrl+Shift+X doesn't work in text boxes with Arabic/Hebrew/Persian keyboard to switch between RTL/LTR layouts : [Attachment 320470] fix without HasSameCharCaseInsen
Karl Tomlinson (:karlt) <mozbugz@karlt.net> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 433192: Ctrl+Shift+X doesn't work in text boxes with Arabic/Hebrew/Persian keyboard to switch between RTL/LTR layouts https://bugzilla.mozilla.org/show_bug.cgi?id=433192 Attachment 320470: fix without HasSameCharCaseInsensitive https://bugzilla.mozilla.org/attachment.cgi?id=320470&action=edit ------- Additional Comments from Karl Tomlinson (:karlt) <mozbugz@karlt.net> Changes based on comment 35. I think this is all we need but att...

superreview canceled: [Bug 433192] Ctrl+Shift+X doesn't work in text boxes with Arabic/Hebrew/Persian keyboard to switch between RTL/LTR layouts : [Attachment 320470] fix without HasSameCharCaseInsens
Karl Tomlinson (:karlt) <mozbugz@karlt.net> has canceled Karl Tomlinson (:karlt) <mozbugz@karlt.net>'s request for superreview: Bug 433192: Ctrl+Shift+X doesn't work in text boxes with Arabic/Hebrew/Persian keyboard to switch between RTL/LTR layouts https://bugzilla.mozilla.org/show_bug.cgi?id=433192 Attachment 320470: fix without HasSameCharCaseInsensitive https://bugzilla.mozilla.org/attachment.cgi?id=320470&action=edit ------- Additional Comments from Karl Tomlinson (:karlt) <mozbugz@karlt.net> Removing HasSameCharCaseInsensitive without the extra s...

superreview requested: [Bug 285138] Spellchecker doesn't skip quoted text in plain text editor : [Attachment 179336] the fix
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 285138: Spellchecker doesn't skip quoted text in plain text editor https://bugzilla.mozilla.org/show_bug.cgi?id=285138 Attachment 179336: the fix https://bugzilla.mozilla.org/attachment.cgi?id=179336&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> This broke when I landed inline spell check because we were stomping over _retval when we checked to see if the content node was a moz-signature. ...

superreview requested: [Bug 354298] Text from testcase of bug 315875 doesn't show up anymore : [Attachment 240273] simple fix
Robert O'Callahan (Novell) <roc@ocallahan.org> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 354298: Text from testcase of bug 315875 doesn't show up anymore https://bugzilla.mozilla.org/show_bug.cgi?id=354298 Attachment 240273: simple fix https://bugzilla.mozilla.org/attachment.cgi?id=240273&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> The testcase creates an anonymous table with two captions, which is weird but I guess we have to handle it like all other weird stuff :-). The fix is ...

superreview cancelled: [Bug 354298] Text from testcase of bug 315875 doesn't show up anymore : [Attachment 240273] simple fix
Robert O'Callahan (Novell) <roc@ocallahan.org> has cancelled Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 354298: Text from testcase of bug 315875 doesn't show up anymore https://bugzilla.mozilla.org/show_bug.cgi?id=354298 Attachment 240273: simple fix https://bugzilla.mozilla.org/attachment.cgi?id=240273&action=edit ...

Web resources about - superreview granted: [Bug 233094] [FIX]input text doesn't appear in text box if text box is in floated cell : [Attachment 140654] This fixes all three testcases and the website - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/6/2015 7:32:11 PM