superreview granted: [Bug 231034] Tab doesn't scroll though address list : [Attachment 140245] updated patch with neil's comments

David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor
<mscott@mozilla.org>'s request for superreview:
Bug 231034: Tab doesn't scroll though address list
http://bugzilla.mozilla.org/show_bug.cgi?id=231034

Attachment 140245: updated patch with neil's comments
http://bugzilla.mozilla.org/attachment.cgi?id=140245&action=edit
0
bugzilla
1/30/2004 6:15:43 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
616 Views

Similar Articles

[PageSpeed] 50

Reply:

Similar Artilces:

superreview requested: [Bug 231034] Tab doesn't scroll though address list : [Attachment 140245] updated patch with neil's comments
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 231034: Tab doesn't scroll though address list http://bugzilla.mozilla.org/show_bug.cgi?id=231034 Attachment 140245: updated patch with neil's comments http://bugzilla.mozilla.org/attachment.cgi?id=140245&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> moving forward the r, requesting sr. ...

superreview granted: [Bug 263182] Page Info (Security tab) doesn't explain mixed secure/insecure : [Attachment 193950] Patch with Neil's comments addressed
Gavin Sharp <gavin.sharp@gmail.com> has granted Gavin Sharp <gavin.sharp@gmail.com>'s request for superreview: Bug 263182: Page Info (Security tab) doesn't explain mixed secure/insecure https://bugzilla.mozilla.org/show_bug.cgi?id=263182 Attachment 193950: Patch with Neil's comments addressed https://bugzilla.mozilla.org/attachment.cgi?id=193950&action=edit ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky. Land this either _really_ early in 1.8b2 or in 1.9a.... ...

superreview granted: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 164339] Updated patch addressing Mike's sr comment
Mike Pinkerton <pinkerton@aol.net> has granted Bruce Davidson <Bruce.Davidson@iplbath.com>'s request for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 164339: Updated patch addressing Mike's sr comment https://bugzilla.mozilla.org/attachment.cgi?id=164339&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink, will land myself. ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ...

superreview granted: [Bug 282645] address autocomplete doesn't work for replies (but works for new compose) : [Attachment 175796] neil's patch w/ recursion protection
Boris Zbarsky <bzbarsky@mit.edu> has granted Brian Ryner (IBM) <bryner@brianryner.com>'s request for superreview: Bug 282645: address autocomplete doesn't work for replies (but works for new compose) https://bugzilla.mozilla.org/show_bug.cgi?id=282645 Attachment 175796: neil's patch w/ recursion protection https://bugzilla.mozilla.org/attachment.cgi?id=175796&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky. I think I prefer this to adding several extra bytes to every textframe... As for how this could ...

superreview granted: [Bug 439470] Mailing List Dialog for OS X address books doesn't list addresses and isn't read-only : [Attachment 327403] Provide read-only detection for mailing list dialogs.
David Bienvenu <bienvenu@nventure.com> has granted Mark Banner (afk 5-12 July) <bugzilla@standard8.plus.com>'s request for superreview: Bug 439470: Mailing List Dialog for OS X address books doesn't list addresses and isn't read-only https://bugzilla.mozilla.org/show_bug.cgi?id=439470 Attachment 327403: Provide read-only detection for mailing list dialogs. https://bugzilla.mozilla.org/attachment.cgi?id=327403&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Looks good - one comment nit: read-only? if so, sho...

superreview granted: [Bug 230577] mail address autocompletion chooses three addresses from address book entries of a certain form : [Attachment 140687] updated patch with neil's comments
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 230577: mail address autocompletion chooses three addresses from address book entries of a certain form http://bugzilla.mozilla.org/show_bug.cgi?id=230577 Attachment 140687: updated patch with neil's comments http://bugzilla.mozilla.org/attachment.cgi?id=140687&action=edit ...

superreview granted: [Bug 123006] Keyword substitution with %s doesn't escape characters : [Attachment 163330] corrects neil's comments
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jean-Marc Desperrier <jmdesp@alussinan.org>'s request for superreview: Bug 123006: Keyword substitution with %s doesn't escape characters https://bugzilla.mozilla.org/show_bug.cgi?id=123006 Attachment 163330: corrects neil's comments https://bugzilla.mozilla.org/attachment.cgi?id=163330&action=edit ...

superreview granted: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Johnny Stenback <jst@mozilla.jstenback.com> has granted Boris Zbarsky <bz-vacation@mit.edu>'s request for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> + if (!name.IsEmpty()) { + aFormSubmission->AddNameValuePair(thi...

superreview requested: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 164339] Updated patch addressing Mike's sr comment
Bruce Davidson <Bruce.Davidson@iplbath.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 164339: Updated patch addressing Mike's sr comment https://bugzilla.mozilla.org/attachment.cgi?id=164339&action=edit ...

superreview granted: [Bug 279533] Update Camino's font preferences code per bug 95227 (serif/sans-serif set is now per language) / serif / sans-serif pref ui doesn't work : [Attachment 174475] patch
Simon Fraser <sfraser_bugs@smfr.org> has granted Asaf Romano <bugs.mano@mail-central.com>'s request for superreview: Bug 279533: Update Camino's font preferences code per bug 95227 (serif/sans-serif set is now per language) / serif / sans-serif pref ui doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=279533 Attachment 174475: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=174475&action=edit ...

superreview granted: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173127] patch v1
Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173127: patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=173127&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky, but it sounds like some cleanup of incremental vs final chunk is in order.... ...

superreview granted: [Bug 214843] Space doesn't scroll when link's child has focus : [Attachment 147204] patch for 214843
Johnny Stenback <jst@mozilla.jstenback.com> has granted Nian Liu <neo.liu@sun.com>'s request for superreview: Bug 214843: Space doesn't scroll when link's child has focus http://bugzilla.mozilla.org/show_bug.cgi?id=214843 Attachment 147204: patch for 214843 http://bugzilla.mozilla.org/attachment.cgi?id=147204&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> >- >- if (focusedElement) { >- nsAutoString tagName; >- focusedElement->GetTagName(tagName); >+ PRBool isA = PR_FALSE; >+ if...

Web resources about - superreview granted: [Bug 231034] Tab doesn't scroll though address list : [Attachment 140245] updated patch with neil's comments - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/18/2016 1:40:20 AM