superreview granted: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 150174] tada!

Darin Fisher (IBM) <darin@meer.net> has granted Robert O'Callahan
<roc@ocallahan.org>'s request for superreview:
Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII
strings
http://bugzilla.mozilla.org/show_bug.cgi?id=226439

Attachment 150174: tada!
http://bugzilla.mozilla.org/attachment.cgi?id=150174&action=edit

------- Additional Comments from Darin Fisher (IBM) <darin@meer.net>
well done!

r+sr=darin
0
bugzilla
6/16/2004 3:36:01 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
595 Views

Similar Articles

[PageSpeed] 0
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 150174] tada!
Robert O'Callahan <roc@ocallahan.org> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 150174: tada! http://bugzilla.mozilla.org/attachment.cgi?id=150174&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> here you go. by my count, 2252 call sites were changed. You may wish to just review the script :-) ...

superreview granted: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 147309] provide a fast compare-with-null-terminated-ASCII
David Baron <dbaron@dbaron.org> has granted Robert O'Callahan <roc@ocallahan.org>'s request for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 147309: provide a fast compare-with-null-terminated-ASCII http://bugzilla.mozilla.org/attachment.cgi?id=147309&action=edit ...

superreview granted: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 147310] layout conversion
David Baron <dbaron@dbaron.org> has granted Robert O'Callahan <roc@ocallahan.org>'s request for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 147310: layout conversion http://bugzilla.mozilla.org/attachment.cgi?id=147310&action=edit ...

superreview granted: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 149104] udpated^2
Darin Fisher (IBM) <darin@meer.net> has granted Robert O'Callahan <roc@ocallahan.org>'s request for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 149104: udpated^2 http://bugzilla.mozilla.org/attachment.cgi?id=149104&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> no need for a new patch. just drop the LC everywhere, and document the cases where the input string must be lowercase. r+sr=darin with that. ...

superreview granted: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 145975] revised^2
David Baron <dbaron@dbaron.org> has granted Robert O'Callahan <roc@ocallahan.org>'s request for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 145975: revised^2 http://bugzilla.mozilla.org/attachment.cgi?id=145975&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> The NSCAP_ prefix has always been used only for nsCOMPtr. Perhaps just use NS_? #ifdef-ing includes is a recipe for bustage. However, nsCharTraits.h alr...

superreview granted: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 146955] experiments for code size
David Baron <dbaron@dbaron.org> has granted Robert O'Callahan <roc@ocallahan.org>'s request for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 146955: experiments for code size http://bugzilla.mozilla.org/attachment.cgi?id=146955&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> beware that code size experiments with small samples are sometimes misleading (inlined functions output separately once they're used, per...

superreview granted: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 147482] Assign, Append and EqualsIgnoreCase variants
Darin Fisher (IBM) <darin@meer.net> has granted Robert O'Callahan <roc@ocallahan.org>'s request for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 147482: Assign, Append and EqualsIgnoreCase variants http://bugzilla.mozilla.org/attachment.cgi?id=147482&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> >Index: xpcom/string/public/nsCharTraits.h >+ compareASCIIIgnoreCase( const char_type* s1, const char* ...

superreview granted: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 150243] fix nsCharTraits<PR_Unichar> for full I18N correctness
Darin Fisher (IBM) <darin@meer.net> has granted Robert O'Callahan <roc@ocallahan.org>'s request for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 150243: fix nsCharTraits<PR_Unichar> for full I18N correctness http://bugzilla.mozilla.org/attachment.cgi?id=150243&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> r+sr=darin Please add comments to this code regarding the Unicode to ASCII conversion. Also, t...

superreview requested: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 147309] provide a fast compare-with-null-terminated-ASCII
Robert O'Callahan <roc@ocallahan.org> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 147309: provide a fast compare-with-null-terminated-ASCII http://bugzilla.mozilla.org/attachment.cgi?id=147309&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> Note that I've tested this by converting layout (patch forthcoming) to EqualsLiteral and then building with the templat...

superreview requested: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 136051] as described
Robert O'Callahan <roc@ocallahan.org> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 136051: as described http://bugzilla.mozilla.org/attachment.cgi?id=136051&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> Something to try in 1.7a, but I may as well get it in the queue so I don't forget about it :-). ...

superreview requested: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 147310] layout conversion
Robert O'Callahan <roc@ocallahan.org> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 147310: layout conversion http://bugzilla.mozilla.org/attachment.cgi?id=147310&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> Up to you how much you want to review vs rubberstamp :-) ...

superreview requested: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 149104] udpated^2
Robert O'Callahan <roc@ocallahan.org> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 149104: udpated^2 http://bugzilla.mozilla.org/attachment.cgi?id=149104&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> one more time :-) ...

superreview requested: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 145975] revised^2
Robert O'Callahan <roc@ocallahan.org> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 145975: revised^2 http://bugzilla.mozilla.org/attachment.cgi?id=145975&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> Carrying forward darin's r+. David, if you're OK with this code then I think we can go ahead and check it in on an otherwise quiet evening and see what ha...

superreview requested: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 146955] experiments for code size
Robert O'Callahan <roc@ocallahan.org> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 226439: Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings http://bugzilla.mozilla.org/show_bug.cgi?id=226439 Attachment 146955: experiments for code size http://bugzilla.mozilla.org/attachment.cgi?id=146955&action=edit ...

Web resources about - superreview granted: [Bug 226439] Reduce footprint of nsA(C?)String::Equals() applied to ASCII strings : [Attachment 150174] tada! - netscape.mozilla.reviewers

Resources last updated: 11/28/2015 3:32:11 AM