superreview requested: [Bug 220093] inCSSValueSearch incorrectly uses strings : [Attachment 132002] use nsString instead
timeless@myrealbox.com <timeless@bemail.org> has asked Boris Zbarsky (on vacation until end of September) <bz-vacation@mit.edu> for superreview: Bug 220093: inCSSValueSearch incorrectly uses strings http://bugzilla.mozilla.org/show_bug.cgi?id=220093 Attachment 132002: use nsString instead http://bugzilla.mozilla.org/attachment.cgi?id=132002&action=edit ...

superreview granted: [Bug 232503] Start using Empty[C]String() : [Attachment 140140] Use Empty[C]String()
Peter Van der Beken <peterv@propagandism.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 232503: Start using Empty[C]String() http://bugzilla.mozilla.org/show_bug.cgi?id=232503 Attachment 140140: Use Empty[C]String() http://bugzilla.mozilla.org/attachment.cgi?id=140140&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> > Index: editor/libeditor/html/Makefile.in > =================================================================== > @@ -58,19 +58,18 @@ CPPSRCS =...

superreview granted: [Bug 334189] nsSHistory::PrintHistory should use a string class : [Attachment 218648] reindent file and use string class
jag (Peter Annema) <jag@tty.nl> has granted superreview: Bug 334189: nsSHistory::PrintHistory should use a string class https://bugzilla.mozilla.org/show_bug.cgi?id=334189 Attachment 218648: reindent file and use string class https://bugzilla.mozilla.org/attachment.cgi?id=218648&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> Are you re-indenting the whole file, or just that section? ...

superreview granted: [Bug 407297] nsIHTMLToTextSink should use nsStringGlue .h instead of nsString.h : [Attachment 292018] Changes nsString. h to nsStringGlue.h in nsIHTMLToTextSink
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted superreview: Bug 407297: nsIHTMLToTextSink should use nsStringGlue.h instead of nsString.h https://bugzilla.mozilla.org/show_bug.cgi?id=407297 Attachment 292018: Changes nsString.h to nsStringGlue.h in nsIHTMLToTextSink https://bugzilla.mozilla.org/attachment.cgi?id=292018&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> This should hopefully be a safe change that allows mailnews to move forward. ...

superreview granted: [Bug 242184] nsIStreamConverter uses InitialCaps in idl instead of interCaps : [Attachment 147424] use interCaps
Darin Fisher (IBM) <darin@meer.net> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 242184: nsIStreamConverter uses InitialCaps in idl instead of interCaps http://bugzilla.mozilla.org/show_bug.cgi?id=242184 Attachment 147424: use interCaps http://bugzilla.mozilla.org/attachment.cgi?id=147424&action=edit ...

superreview granted: [Bug 131867] Our use of setlocale() is not threadsafe : [Attachment 141891] Use a Private string class for floating point numbers
tor@acm.org has granted Kenneth Herron (kherron) <kjh-5727@comcast.net>'s request for superreview: Bug 131867: Our use of setlocale() is not threadsafe http://bugzilla.mozilla.org/show_bug.cgi?id=131867 Attachment 141891: Use a Private string class for floating point numbers http://bugzilla.mozilla.org/attachment.cgi?id=141891&action=edit ...

superreview granted: [Bug 298807] nsIBookmarksService::ResolveKeyword can make a better use of strings : [Attachment 188012] patch (use AString)
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jungshik Shin <jshin1987@gmail.com>'s request for superreview: Bug 298807: nsIBookmarksService::ResolveKeyword can make a better use of strings https://bugzilla.mozilla.org/show_bug.cgi?id=298807 Attachment 188012: patch (use AString) https://bugzilla.mozilla.org/attachment.cgi?id=188012&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> >- nsDependentString postDataStr(postDataVal); >- *aPostData = ToNewUnicode(post...

superreview granted: [Bug 239132] nsIWidget::SetTitle should use nsAString, not nsString : [Attachment 145520] Use PromiseFlatString and fix naming conflicts in windows/
Darin Fisher (IBM) <darin@meer.net> has granted Darin Fisher (IBM) <darin@meer.net>'s request for superreview: Bug 239132: nsIWidget::SetTitle should use nsAString, not nsString http://bugzilla.mozilla.org/show_bug.cgi?id=239132 Attachment 145520: Use PromiseFlatString and fix naming conflicts in windows/ http://bugzilla.mozilla.org/attachment.cgi?id=145520&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> >Index: src/gtk/nsWindow.cpp >- PRInt32 len = (PRInt32)aTitle.Length(); >- encoder->GetMaxLength(aTitle....

superreview granted: [Bug 242185] nsITXTToHTMLConv uses InitialCaps in idl instead of interCaps : [Attachment 147422] fix case and use javadoc style
Darin Fisher (IBM) <darin@meer.net> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 242185: nsITXTToHTMLConv uses InitialCaps in idl instead of interCaps http://bugzilla.mozilla.org/show_bug.cgi?id=242185 Attachment 147422: fix case and use javadoc style http://bugzilla.mozilla.org/attachment.cgi?id=147422&action=edit ------- Additional Comments from Darin Fisher (IBM) <darin@meer.net> can you get rid of the redundant [const] tags as well? thanks! r+sr=darin ...

superreview granted: [Bug 234703] mClassInfoFlags is always 0 instead of using the XPCWrappedNativeProto(..., ClassInfoFlags, ...) value : [Attachment 141641] use the value passed to the constructor
Boris Zbarsky (not able to do reviews) <bzbarsky@mit.edu> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 234703: mClassInfoFlags is always 0 instead of using the XPCWrappedNativeProto(..., ClassInfoFlags, ...) value http://bugzilla.mozilla.org/show_bug.cgi?id=234703 Attachment 141641: use the value passed to the constructor http://bugzilla.mozilla.org/attachment.cgi?id=141641&action=edit ------- Additional Comments from Boris Zbarsky (not able to do reviews) <bzbarsky@mit.edu> sr=bzbarsky ...

superreview granted: [Bug 250828] When i use global inbox, thunderbird does not use localized string "Inbox". : [Attachment 160458] possible fix
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 250828: When i use global inbox, thunderbird does not use localized string "Inbox". https://bugzilla.mozilla.org/show_bug.cgi?id=250828 Attachment 160458: possible fix https://bugzilla.mozilla.org/attachment.cgi?id=160458&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> I like this - I'd fix the comment // "none" doesn't have an inbox - maybe just remove it... ...

superreview granted: [Bug 239181] IMAP STATUS command should not be used on selected mailbox : [Attachment 149082] use NOOP instead of STATUS if we're selected
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 239181: IMAP STATUS command should not be used on selected mailbox http://bugzilla.mozilla.org/show_bug.cgi?id=239181 Attachment 149082: use NOOP instead of STATUS if we're selected http://bugzilla.mozilla.org/attachment.cgi?id=149082&action=edit ...

superreview granted: [Bug 274440] ".key" should not be used to describe access keys, use ".accesskey" instead : [Attachment 174088] updated patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Hasse <jasajudeju@telia.com>'s request for superreview: Bug 274440: ".key" should not be used to describe access keys, use ".accesskey" instead https://bugzilla.mozilla.org/show_bug.cgi?id=274440 Attachment 174088: updated patch https://bugzilla.mozilla.org/attachment.cgi?id=174088&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Transferring r=db48x as per his comment. ...

superreview requested: [Bug 260141] Some strings in locale files is using "Firefox"
Alexander L. Slovesnik <als@mozilla.ru> has asked for superreview: Bug 260141: Some strings in locale files is using "Firefox" - should use &brandShortName; instead https://bugzilla.mozilla.org/show_bug.cgi?id=260141 Attachment 159777: Patch for updated.dtd only. https://bugzilla.mozilla.org/attachment.cgi?id=159777&action=edit ...