superreview requested: [Bug 217903] ###!!! ASSERTION: prev sibling not in line list: 'Not Reached', file i:/build/mozilla/layout/html/base/src/nsBlockFrame.cpp, line 4679 : [Attachment 194408] Patch
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 217903: ###!!! ASSERTION: prev sibling not in line list: 'Not Reached', file i:/build/mozilla/layout/html/base/src/nsBlockFrame.cpp, line 4679 https://bugzilla.mozilla.org/show_bug.cgi?id=217903 Attachment 194408: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=194408&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> This fixes the stack that I have, which is the same as the one in comment 1. The ...

superreview granted: [Bug 277875] ###!!! ASSERTION: this shouldn't happen, should it?: 'Not Reached', file r:/cenzic/mozilla/layout/html/base/src/nsFrame.cpp, line 2427 : [Attachment 173584] fix
Boris Zbarsky <bzbarsky@mit.edu> has granted Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 277875: ###!!! ASSERTION: this shouldn't happen, should it?: 'Not Reached', file r:/cenzic/mozilla/layout/html/base/src/nsFrame.cpp, line 2427 https://bugzilla.mozilla.org/show_bug.cgi?id=277875 Attachment 173584: fix https://bugzilla.mozilla.org/attachment.cgi?id=173584&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky ...

superreview requested: [Bug 277875] ###!!! ASSERTION: this shouldn't happen, should it?: 'Not Reached', file r:/cenzic/mozilla/layout/html/base/src/nsFrame.cpp, line 2427 : [Attachment 173584] fix
Robert O'Callahan (Novell) <roc@ocallahan.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 277875: ###!!! ASSERTION: this shouldn't happen, should it?: 'Not Reached', file r:/cenzic/mozilla/layout/html/base/src/nsFrame.cpp, line 2427 https://bugzilla.mozilla.org/show_bug.cgi?id=277875 Attachment 173584: fix https://bugzilla.mozilla.org/attachment.cgi?id=173584&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> Make nsIFrame::GetWindow do it the easy way, and don't bother asser...

superreview granted: [Bug 341436] ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978 : [Attachment 225493] Don't pass null
neil@parkwaycc.co.uk <neil@httl.net> has granted Alex Vincent <ajvincent@gmail.com>'s request for superreview: Bug 341436: ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978 https://bugzilla.mozilla.org/show_bug.cgi?id=341436 Attachment 225493: Don't pass null in. https://bugzilla.mozilla.org/attachment.cgi?id=225493&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Nit: adding a blank line after the return would make the code look nicer...

superreview granted: [Bug 324036] ###!!! ASSERTION: NOT IMPLEMENTED: '0', file c:/mozsource/mozilla/layout/base/nsDocumentViewer.cpp, line 2512 : [Attachment 242813] patch, v1.1
Johnny Stenback <jst@mozilla.org> has granted Alex Vincent <ajvincent@gmail.com>'s request for superreview: Bug 324036: ###!!! ASSERTION: NOT IMPLEMENTED: '0', file c:/mozsource/mozilla/layout/base/nsDocumentViewer.cpp, line 2512 https://bugzilla.mozilla.org/show_bug.cgi?id=324036 Attachment 242813: patch, v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=242813&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> NS_IMETHODIMP DocumentViewerImpl::GetSearchable(PRBool *aSearchable) { - NS_ASSERTION(0, "NOT IMPL...

superreview granted: [Bug 270797] ###!!! ASSERTION: null data pointer: 'Not Reached', file r:\mozilla\xpcom\string\src\nsTSubstring.cpp, line 599 : [Attachment 166577] Patch 2
David Bienvenu <bienvenu@nventure.com> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 270797: ###!!! ASSERTION: null data pointer: 'Not Reached', file r:\mozilla\xpcom\string\src\nsTSubstring.cpp, line 599 https://bugzilla.mozilla.org/show_bug.cgi?id=270797 Attachment 166577: Patch 2 https://bugzilla.mozilla.org/attachment.cgi?id=166577&action=edit ...

superreview granted: [Bug 268480] ###!!! ASSERTION: cannot set user:pass on no-auth url: 'Error', file r:/mozilla/netwerk/base/src/nsStandardURL.cpp, line 1121 : [Attachment 165241] v1 patch
Boris Zbarsky <bzbarsky@mit.edu> has granted Darin Fisher (IBM) <darin@meer.net>'s request for superreview: Bug 268480: ###!!! ASSERTION: cannot set user:pass on no-auth url: 'Error', file r:/mozilla/netwerk/base/src/nsStandardURL.cpp, line 1121 https://bugzilla.mozilla.org/show_bug.cgi?id=268480 Attachment 165241: v1 patch https://bugzilla.mozilla.org/attachment.cgi?id=165241&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky. Thanks! ...

superreview granted: [Bug 217906] ###!!! ASSERTION: null args: 'aNode1 && aNode2 && aResult', file i:/build/mozilla/editor/libeditor/html/nsHTMLEditRules.cpp, line 7556 : [Attachment 130692] patch t
<kinmoz@netscape.net> has granted Joe Francis <mozeditor@floppymoose.com>'s request for superreview: Bug 217906: ###!!! ASSERTION: null args: 'aNode1 && aNode2 && aResult', file i:/build/mozilla/editor/libeditor/html/nsHTMLEditRules.cpp, line 7556 http://bugzilla.mozilla.org/show_bug.cgi?id=217906 Attachment 130692: patch to nsHTMLEditRules.cpp http://bugzilla.mozilla.org/attachment.cgi?id=130692&action=edit ------- Additional Comments from <kinmoz@netscape.net> sr=kinmoz@netscape.net ...

superreview granted: [Bug 287008] ###!!! ASSERTION: Don't call me!: 'Error', file r:/mozilla/dom/src/base/nsDOMClassInfo.cpp, line 2986 : [Attachment 191294] Fix.
Peter Van der Beken <peterv@propagandism.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 287008: ###!!! ASSERTION: Don't call me!: 'Error', file r:/mozilla/dom/src/base/nsDOMClassInfo.cpp, line 2986 https://bugzilla.mozilla.org/show_bug.cgi?id=287008 Attachment 191294: Fix. https://bugzilla.mozilla.org/attachment.cgi?id=191294&action=edit ...

superreview requested: [Bug 341436] ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978 : [Attachment 225493] Don't pass nu
Alex Vincent <ajvincent@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 341436: ###!!! ASSERTION: URI is empty: '!aURI.IsEmpty()', file c:/mozilla.org/baseline/mozilla/rdf/base/src/nsRDFService.cpp, line 978 https://bugzilla.mozilla.org/show_bug.cgi?id=341436 Attachment 225493: Don't pass null in. https://bugzilla.mozilla.org/attachment.cgi?id=225493&action=edit ...

superreview granted: [Bug 294414] ###!!! ASSERTION: This is not supposed to fail!: 'Error', file r:/mozilla/js/src/xpconnect/src/nsXPConnect.cpp, line 413 : [Attachment 190667] Proposed patch for the
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 294414: ###!!! ASSERTION: This is not supposed to fail!: 'Error', file r:/mozilla/js/src/xpconnect/src/nsXPConnect.cpp, line 413 https://bugzilla.mozilla.org/show_bug.cgi?id=294414 Attachment 190667: Proposed patch for the LoadSrc issue https://bugzilla.mozilla.org/attachment.cgi?id=190667&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> r+sr=jst ...

superreview granted: [Bug 124282] ASSERTION: no m_path, see bugs #57659 and #72317: 'm_path', file /home/timeless/mozilla/mailnews/news/src/nsNNTPProtocol.cpp, line 2180 : [Attachment 69104] Patch wh
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 124282: ASSERTION: no m_path, see bugs #57659 and #72317: 'm_path', file /home/timeless/mozilla/mailnews/news/src/nsNNTPProtocol.cpp, line 2180 https://bugzilla.mozilla.org/show_bug.cgi?id=124282 Attachment 69104: Patch which updates the assertion to point to bug 73920 and bug 72320. https://bugzilla.mozilla.org/attachment.cgi?id=69104&action=edit ...

superreview requested: [Bug 324036] ###!!! ASSERTION: NOT IMPLEMENTED: '0', file c:/mozsource/mozilla/layout/base/nsDocumentViewer.cpp, line 2512 : [Attachment 242696] patch, v1
Alex Vincent <ajvincent@gmail.com> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 324036: ###!!! ASSERTION: NOT IMPLEMENTED: '0', file c:/mozsource/mozilla/layout/base/nsDocumentViewer.cpp, line 2512 https://bugzilla.mozilla.org/show_bug.cgi?id=324036 Attachment 242696: patch, v1 https://bugzilla.mozilla.org/attachment.cgi?id=242696&action=edit ------- Additional Comments from Alex Vincent <ajvincent@gmail.com> It is disabled, but we never checked that... whoops! This is a really simple patch for nsXBLPrototypeHandler to make us do ...

superreview cancelled: [Bug 324036] ###!!! ASSERTION: NOT IMPLEMENTED: '0', file c:/mozsource/mozilla/layout/base/nsDocumentViewer.cpp, line 2512 : [Attachment 242696] patch, v1
Alex Vincent <ajvincent@gmail.com> has cancelled Alex Vincent <ajvincent@gmail.com>'s request for superreview: Bug 324036: ###!!! ASSERTION: NOT IMPLEMENTED: '0', file c:/mozsource/mozilla/layout/base/nsDocumentViewer.cpp, line 2512 https://bugzilla.mozilla.org/show_bug.cgi?id=324036 Attachment 242696: patch, v1 https://bugzilla.mozilla.org/attachment.cgi?id=242696&action=edit ------- Additional Comments from Alex Vincent <ajvincent@gmail.com> answering review comments and irc chat with jst ...