superreview requested: [Bug 196670] JNG images crash Mozilla on Windows[@ mng_add_chunk ] : [Attachment 129051] Patch to work around Microsoft compiler bug that causes JNG crash
Glenn Randers-Pehrson (pls fix bug#196670) <glennrp@imagemagick.org> has asked rbs@maths.uq.edu.au for superreview: Bug 196670: JNG images crash Mozilla on Windows[@ mng_add_chunk ] http://bugzilla.mozilla.org/show_bug.cgi?id=196670 Attachment 129051: Patch to work around Microsoft compiler bug that causes JNG crash http://bugzilla.mozilla.org/attachment.cgi?id=129051&action=edit ------- Additional Comments from Glenn Randers-Pehrson (pls fix bug#196670) <glennrp@imagemagick.org> rbs: sr? This simple patch removes two redundant lines of code. The Microsoft comp...

superreview granted: [Bug 196670] JNG images crash Mozilla on Windows[@ mng_add_chunk ] : [Attachment 134570] Revised patch to work around MS compiler bug that crashes JNG
<rbs@maths.uq.edu.au> has granted Glenn Randers-Pehrson (pls fix bug#196670) <glennrp@imagemagick.org>'s request for superreview: Bug 196670: JNG images crash Mozilla on Windows[@ mng_add_chunk ] http://bugzilla.mozilla.org/show_bug.cgi?id=196670 Attachment 134570: Revised patch to work around MS compiler bug that crashes JNG http://bugzilla.mozilla.org/attachment.cgi?id=134570&action=edit ------- Additional Comments from <rbs@maths.uq.edu.au> sr=rbs ...

superreview requested: [Bug 196670] JNG images crash Mozilla on Windows[@ mng_add_chunk ] : [Attachment 134570] Revised patch to work around MS compiler bug that crashes JNG
Glenn Randers-Pehrson (pls fix bug#196670) <glennrp@imagemagick.org> has asked rbs@maths.uq.edu.au for superreview: Bug 196670: JNG images crash Mozilla on Windows[@ mng_add_chunk ] http://bugzilla.mozilla.org/show_bug.cgi?id=196670 Attachment 134570: Revised patch to work around MS compiler bug that crashes JNG http://bugzilla.mozilla.org/attachment.cgi?id=134570&action=edit ------- Additional Comments from Glenn Randers-Pehrson (pls fix bug#196670) <glennrp@imagemagick.org> tor: r? rbs: sr? The new patch provides a much more robust workaround to the Microsoft ...

superreview granted: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) : [Attachment 173746] patch
T Rowley (IBM) <tor@acm.org> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 250936: Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) https://bugzilla.mozilla.org/show_bug.cgi?id=250936 Attachment 173746: patch https://bugzilla.mozilla.org/attachment.cgi?id=173746&action=edit ...

superreview requested: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed : [Attachment 152994] Patch nsModule to register only supported image formats
timeless@myrealbox.com (working) <timeless@bemail.org> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 250936: Non distributed image formats opens many mozilla windows until crashed http://bugzilla.mozilla.org/show_bug.cgi?id=250936 Attachment 152994: Patch nsModule to register only supported image formats http://bugzilla.mozilla.org/attachment.cgi?id=152994&action=edit ...

superreview cancelled: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed : [Attachment 152994] Patch nsModule to register only supported image formats
Christian Biesinger (unique:bi) <cbiesinger@gmx.at> has cancelled timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 250936: Non distributed image formats opens many mozilla windows until crashed http://bugzilla.mozilla.org/show_bug.cgi?id=250936 Attachment 152994: Patch nsModule to register only supported image formats http://bugzilla.mozilla.org/attachment.cgi?id=152994&action=edit ...

superreview requested: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) : [Attachment 173746] patch
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked T Rowley (IBM) <tor@acm.org> for superreview: Bug 250936: Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) https://bugzilla.mozilla.org/show_bug.cgi?id=250936 Attachment 173746: patch https://bugzilla.mozilla.org/attachment.cgi?id=173746&action=edit ...

superreview granted: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) : [Attachment 173795] equivalent for firefox
Darin Fisher <darin@meer.net> has granted T Rowley (IBM) <tor@acm.org>'s request for superreview: Bug 250936: Non distributed image formats opens many mozilla windows until crashed (infinite/eternal window opening loop) https://bugzilla.mozilla.org/show_bug.cgi?id=250936 Attachment 173795: equivalent for firefox https://bugzilla.mozilla.org/attachment.cgi?id=173795&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> >Index: nsBrowserContentHandler.js > const nsIPrefBranch = Components.interfaces.nsIPrefBranch; > c...

superreview requested: [Bug 250936] Non distributed image formats opens many mozilla windows until crashed : [Attachment 152994] Patch nsModule to register only supported image formats #2
timeless@myrealbox.com (working) <timeless@bemail.org> has asked T Rowley (IBM) <tor@acm.org> for superreview: Bug 250936: Non distributed image formats opens many mozilla windows until crashed http://bugzilla.mozilla.org/show_bug.cgi?id=250936 Attachment 152994: Patch nsModule to register only supported image formats http://bugzilla.mozilla.org/attachment.cgi?id=152994&action=edit ...

superreview granted: [Bug 225034] Certificate Manager Crashes Mozilla [@ nsCertTree::CmpByCrit] : [Attachment 136693] cleanup patch, unrelated to crash
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted timeless@myrealbox.com (working) <timeless@bemail.org>'s request for superreview: Bug 225034: Certificate Manager Crashes Mozilla [@ nsCertTree::CmpByCrit] https://bugzilla.mozilla.org/show_bug.cgi?id=225034 Attachment 136693: cleanup patch, unrelated to crash https://bugzilla.mozilla.org/attachment.cgi?id=136693&action=edit ...

superreview granted: [Bug 287308] element with not correctly resolved context attribute crashes mozilla on window close [@ nsPopupSetFrame::DoLayout ] : [Attachment 178580] Fixes the crash for me...
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 287308: element with not correctly resolved context attribute crashes mozilla on window close [@ nsPopupSetFrame::DoLayout ] https://bugzilla.mozilla.org/show_bug.cgi?id=287308 Attachment 178580: Fixes the crash for me... https://bugzilla.mozilla.org/attachment.cgi?id=178580&action=edit ...

superreview granted: [Bug 215798] Running Venkman crashes Mozilla [@ JS_GetPrivate ] : [Attachment 131582] patch to fix the GC safety bug, plus a few warning fixes
Johnny Stenback <jst@mozilla.jstenback.com> has granted Brendan Eich <brendan@mozilla.org>'s request for superreview: Bug 215798: Running Venkman crashes Mozilla [@ JS_GetPrivate ] http://bugzilla.mozilla.org/show_bug.cgi?id=215798 Attachment 131582: patch to fix the GC safety bug, plus a few warning fixes http://bugzilla.mozilla.org/attachment.cgi?id=131582&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> I wasn't able to test this or run with it, but the change looks good. Hopefully someone else is able to ve...

superreview granted: [Bug 297807] Java 1.4.2 SR2 plug-in and later cause Mozilla to crash : [Attachment 186357] Patch v1
Darin Fisher <darin@meer.net> has granted Philip K. Warren (IBM) <pkwarren@gmail.com>'s request for superreview: Bug 297807: Java 1.4.2 SR2 plug-in and later cause Mozilla to crash https://bugzilla.mozilla.org/show_bug.cgi?id=297807 Attachment 186357: Patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=186357&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> >Index: modules/plugin/base/src/nsPluginsDirUnix.cpp >+static void setJavaLibPath(const nsCString & pluginPath) nit: space before or after "&" ...

superreview granted: [Bug 297807] Java 1.4.2 SR2 plug-in and later cause Mozilla to crash : [Attachment 186368] Patch v2
Darin Fisher <darin@meer.net> has granted Philip K. Warren (IBM) <pkwarren@gmail.com>'s request for superreview: Bug 297807: Java 1.4.2 SR2 plug-in and later cause Mozilla to crash https://bugzilla.mozilla.org/show_bug.cgi?id=297807 Attachment 186368: Patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=186368&action=edit ...