superreview denied: [Bug 301367] Tag Files with Source URL : [Attachment 189829] patch to tag files with source url

Darin Fisher <darin@meer.net> has denied Michael Kaply (IBM) (mkaply)
<mozilla@kaply.com>'s request for superreview:
Bug 301367: Tag Files with Source URL
https://bugzilla.mozilla.org/show_bug.cgi?id=301367

Attachment 189829: patch to tag files with source url
https://bugzilla.mozilla.org/attachment.cgi?id=189829&action=edit

------- Additional Comments from Darin Fisher <darin@meer.net>
Whenever you change an interface definition, you MUST change the corresponding
"uuid" property of the interface.  Otherwise, existing XPCOM components may
crash when they attempt to use the old interface.  By changing the uuid, you
make it so that QueryInterface can be used properly to test for the existance
of a particular version of the interface.

Also, a style nit:
"SaveFileSource( mCurrentBaseURI, aFile);"
why the extra whitespace?  is that how the rest of the source file is coded? 
if not, then please change your style to match that of the surrounding code,
thx!
0
bugzilla
7/21/2005 6:27:46 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
580 Views

Similar Articles

[PageSpeed] 9
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 301367] Tag Files with Source URL : [Attachment 189829] patch to tag files with source url
Michael Kaply (IBM) (mkaply) <mozilla@kaply.com> has asked Darin Fisher <darin@meer.net> for superreview: Bug 301367: Tag Files with Source URL https://bugzilla.mozilla.org/show_bug.cgi?id=301367 Attachment 189829: patch to tag files with source url https://bugzilla.mozilla.org/attachment.cgi?id=189829&action=edit ------- Additional Comments from Michael Kaply (IBM) (mkaply) <mozilla@kaply.com> r=mkaply ...

superreview requested: [Bug 301367] Tag Files with Source URL : [Attachment 204417] revised patch to tag files with source url
Peter Weilbacher <mozilla@Weilbacher.org> has asked Darin Fisher <darin@meer.net> for superreview: Bug 301367: Tag Files with Source URL https://bugzilla.mozilla.org/show_bug.cgi?id=301367 Attachment 204417: revised patch to tag files with source url https://bugzilla.mozilla.org/attachment.cgi?id=204417&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> As the cross-platform coordination in bug 90918 has failed I think it makes sense to try the OS/2 only approach again, hence I ask for reviews again. This patch attends to...

superreview granted: [Bug 301367] Tag Files with Source URL : [Attachment 204417] revised patch to tag files with source url
Darin Fisher <darin@meer.net> has granted Peter Weilbacher <mozilla@Weilbacher.org>'s request for superreview: Bug 301367: Tag Files with Source URL https://bugzilla.mozilla.org/show_bug.cgi?id=301367 Attachment 204417: revised patch to tag files with source url https://bugzilla.mozilla.org/attachment.cgi?id=204417&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> I don't really like the ifdef'ing in cross-platform code, but ok. sr=darin assuming mkaply is okay with the stuff inside the ifdefs ;-) ...

superreview denied: [Bug 253405] Warning for document.all doesn't list source file or line number : [Attachment 155287] get the source file and line number
Brendan Eich <brendan@mozilla.org> has denied Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 253405: Warning for document.all doesn't list source file or line number http://bugzilla.mozilla.org/show_bug.cgi?id=253405 Attachment 155287: get the source file and line number http://bugzilla.mozilla.org/attachment.cgi?id=155287&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> >-static void >-PrintDocumentAllWarningOnConsole() >+static nsresult >+PrintDocumentAllWarningOnConsole(JSContext *cx) &g...

superreview denied: [Bug 103468] Mozilla creates .url files with zero byte at end, confusing IE (Internet shortcut) : [Attachment 149178] patch 4
Robert O'Callahan <roc@ocallahan.org> has denied Brodie Thiesfield <brofield@jellycan.com>'s request for superreview: Bug 103468: Mozilla creates .url files with zero byte at end, confusing IE (Internet shortcut) http://bugzilla.mozilla.org/show_bug.cgi?id=103468 Attachment 149178: patch 4 http://bugzilla.mozilla.org/attachment.cgi?id=149178&action=edit ------- Additional Comments from Robert O'Callahan <roc@ocallahan.org> minusing in anticipation of a new patch ...

superreview granted: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143792] patch v4
Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger <cbiesinger@gmx.at>'s request for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143792: patch v4 http://bugzilla.mozilla.org/attachment.cgi?id=143792&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky, but I didn't verify general correctness of the win32 mumbo-jumbo (I don't know enough about win32 to do that). ...

superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143792] patch v4
Christian Biesinger <cbiesinger@gmx.at> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143792: patch v4 http://bugzilla.mozilla.org/attachment.cgi?id=143792&action=edit ------- Additional Comments from Christian Biesinger <cbiesinger@gmx.at> I'll change nsIFileProtocolHandler's uuid before checking in ...

superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143792] patch v4 #2
Christian Biesinger <cbiesinger@gmx.at> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143792: patch v4 http://bugzilla.mozilla.org/attachment.cgi?id=143792&action=edit ...

superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143888] patch for callers, v2
Christian Biesinger <cbiesinger@gmx.at> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143888: patch for callers, v2 http://bugzilla.mozilla.org/attachment.cgi?id=143888&action=edit ------- Additional Comments from Christian Biesinger <cbiesinger@gmx.at> I'll make those changes ...

superreview granted: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143888] patch for callers, v2
Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger <cbiesinger@gmx.at>'s request for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143888: patch for callers, v2 http://bugzilla.mozilla.org/attachment.cgi?id=143888&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: xpfe/components/bookmarks/src/nsBookmarksService.cpp The changes to this are fine. File a bug on firefox t...

superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143888] patch for callers, v2 #2
Christian Biesinger <cbiesinger@gmx.at> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) http://bugzilla.mozilla.org/show_bug.cgi?id=69114 Attachment 143888: patch for callers, v2 http://bugzilla.mozilla.org/attachment.cgi?id=143888&action=edit ...

superreview requested: [Bug 363654] .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch : [Attachment 248458] disables .url in file:open
Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org> has asked Stuart Morgan <stuart.morgan@alumni.case.edu> for superreview: Bug 363654: .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch https://bugzilla.mozilla.org/show_bug.cgi?id=363654 Attachment 248458: disables .url in file:open https://bugzilla.mozilla.org/attachment.cgi?id=248458&action=edit ------- Additional Comments from Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org> Asking for sr on this 7-char patch in case we need to take it ...

superreview granted: [Bug 363654] .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch : [Attachment 248458] disables .url in file:open
Stuart Morgan <stuart.morgan@alumni.case.edu> has granted Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org>'s request for superreview: Bug 363654: .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch https://bugzilla.mozilla.org/show_bug.cgi?id=363654 Attachment 248458: disables .url in file:open https://bugzilla.mozilla.org/attachment.cgi?id=248458&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> Well, that kinda sucks. ...

superreview requested: [Bug 253405] Warning for document.all doesn't list source file or line number : [Attachment 155287] get the source file and line number
timeless@myrealbox.com (working) <timeless@bemail.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 253405: Warning for document.all doesn't list source file or line number http://bugzilla.mozilla.org/show_bug.cgi?id=253405 Attachment 155287: get the source file and line number http://bugzilla.mozilla.org/attachment.cgi?id=155287&action=edit ...

Web resources about - superreview denied: [Bug 301367] Tag Files with Source URL : [Attachment 189829] patch to tag files with source url - netscape.mozilla.reviewers

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/12/2015 9:02:44 AM