superreview denied: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 179246] Like so

David Baron <dbaron@mozilla.org> has denied Boris Zbarsky <bzbarsky@mit.edu>'s
request for superreview:
Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the
value
https://bugzilla.mozilla.org/show_bug.cgi?id=288574

Attachment 179246: Like so
https://bugzilla.mozilla.org/attachment.cgi?id=179246&action=edit

------- Additional Comments from David Baron <dbaron@mozilla.org>
>@@ -752,17 +758,18 @@ CSSParserImpl::ParseAndAppendDeclaration
>+    if (!ParseDeclaration(errorCode, aDeclaration, PR_FALSE,
>+			    PR_FALSE, aChanged)) {

I think this should be passing PR_TRUE.  Otherwise duplicate declarations in
CSSStyleDeclaration::cssText setter won't be serialized consistently with other
duplicate declarations.

That will mess up the case:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/style/nsDOMCSSDeclar
ation.cpp&rev=3.60&mark=215-221#194
but that code should probably be fixed anyway.

>+  if (aMustCallValueAppended || !PropertySetInData(aPropID)) {

Why can't you just check the property bit in mData instead of writing this new
PropertySetInData function?
0
bugzilla
4/5/2005 12:03:24 AM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
891 Views

Similar Articles

[PageSpeed] 55
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 179246] Like so
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozilla.org> for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 179246: Like so https://bugzilla.mozilla.org/attachment.cgi?id=179246&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This would be simpler if we could depend on the bit on mData, but since we can't... ...

superreview requested: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 180304] Same as diff -w
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozillafoundation.org> for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 180304: Same as diff -w https://bugzilla.mozilla.org/attachment.cgi?id=180304&action=edit ...

superreview granted: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 180304] Same as diff -w
David Baron <dbaron@mozillafoundation.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 180304: Same as diff -w https://bugzilla.mozilla.org/attachment.cgi?id=180304&action=edit ...

superreview denied: [Bug 359392] [FIX]Very slow rendering of the top bar on mozilla.org : [Attachment 246745] Don't tile when we don't have to
Boris Zbarsky <bzbarsky@mit.edu> has denied Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 359392: [FIX]Very slow rendering of the top bar on mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=359392 Attachment 246745: Don't tile when we don't have to https://bugzilla.mozilla.org/attachment.cgi?id=246745&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Actually, that uses the wrong offset in the case when there's more than one tile... I'll update the patch. ...

superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs https://bugzilla.mozilla.org/show_bug.cgi?id=340083 Attachment 224205: don't create frames for content we don't handle, don't invalidate nondisplay content https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit ...

superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if t
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Duh, thanks. r+sr=me....

superreview requested: [Bug 287008] ###!!! ASSERTION: Don't call me!: 'Error', file r:/mozilla/dom/src/base/nsDOMClassInfo.cpp, line 2986 : [Attachment 191294] Fix.
Johnny Stenback <jst@mozilla.org> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 287008: ###!!! ASSERTION: Don't call me!: 'Error', file r:/mozilla/dom/src/base/nsDOMClassInfo.cpp, line 2986 https://bugzilla.mozilla.org/show_bug.cgi?id=287008 Attachment 191294: Fix. https://bugzilla.mozilla.org/attachment.cgi?id=191294&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> Calling nsElementSH::GetProperty() from here does nothing other than assert and return NS_OK, just return NS_OK instead. (P...

superreview granted: [Bug 287008] ###!!! ASSERTION: Don't call me!: 'Error', file r:/mozilla/dom/src/base/nsDOMClassInfo.cpp, line 2986 : [Attachment 191294] Fix.
Peter Van der Beken <peterv@propagandism.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 287008: ###!!! ASSERTION: Don't call me!: 'Error', file r:/mozilla/dom/src/base/nsDOMClassInfo.cpp, line 2986 https://bugzilla.mozilla.org/show_bug.cgi?id=287008 Attachment 191294: Fix. https://bugzilla.mozilla.org/attachment.cgi?id=191294&action=edit ...

superreview requested: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ...

superreview cancelled: [Bug 359392] [FIX]Very slow rendering of the top bar on mozilla.org : [Attachment 246745] Don't tile when we don't have to
Boris Zbarsky <bzbarsky@mit.edu> has cancelled Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 359392: [FIX]Very slow rendering of the top bar on mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=359392 Attachment 246745: Don't tile when we don't have to https://bugzilla.mozilla.org/attachment.cgi?id=246745&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Actually, that uses the wrong offset in the case when there's more than one tile... I'll update the patch. ...

superreview requested: [Bug 359392] Very slow rendering of the top bar on mozilla.org : [Attachment 246745] Don't tile when we don't have to
Boris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 359392: Very slow rendering of the top bar on mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=359392 Attachment 246745: Don't tile when we don't have to https://bugzilla.mozilla.org/attachment.cgi?id=246745&action=edit ...

superreview granted: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, I guess.. Is ther a reason mIsBrokenPlugin is write-only? ...

superreview requested: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ...

superreview granted: [Bug 451234] don't stop plugins from loading just because they don't have a resource file : [Attachment 334535] fix v1.0
Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> has granted Josh Aas <joshmoz@gmail.com>'s request for superreview: Bug 451234: don't stop plugins from loading just because they don't have a resource file https://bugzilla.mozilla.org/show_bug.cgi?id=451234 Attachment 334535: fix v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=334535&action=edit ...

Web resources about - superreview denied: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 179246] Like so - netscape.mozilla.reviewers

Resources last updated: 12/3/2015 12:15:12 PM