superreview denied: [Bug 191578] "Close Other Tabs" Needs a Confirmation Dialog : [Attachment 128576] patch v1 should do the trick, adds a confirmation similar to what when you close a window full of

jag (Peter Annema) <jag@tty.nl> has denied Peter Lairo <Peter@Lairo.com>'s
request for superreview:
Bug 191578: "Close Other Tabs" Needs a Confirmation Dialog
http://bugzilla.mozilla.org/show_bug.cgi?id=191578

Attachment 128576: patch v1 should do the trick, adds a confirmation similar to
what when you close a window full of tabs
http://bugzilla.mozilla.org/attachment.cgi?id=128576&action=edit

------- Additional Comments from jag (Peter Annema) <jag@tty.nl>
Minusing patch, obsoleting it (I doubt it still applies cleanly).
0
bugzilla
4/5/2004 8:26:03 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
1209 Views

Similar Articles

[PageSpeed] 57
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview granted: [Bug 191578] "Close Other Tabs" Needs a Confirmation Dialog : [Attachment 148198] Final patch, with numtabs changed to numTabs
jag (Peter Annema) <jag@tty.nl> has granted jag (Peter Annema) <jag@tty.nl>'s request for superreview: Bug 191578: "Close Other Tabs" Needs a Confirmation Dialog http://bugzilla.mozilla.org/show_bug.cgi?id=191578 Attachment 148198: Final patch, with numtabs changed to numTabs http://bugzilla.mozilla.org/attachment.cgi?id=148198&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> sr=jag ...

superreview cancelled: [Bug 191578] "Close Other Tabs" Needs a Confirmation Dialog : [Attachment 148218] Final patch again, with one more variable rename (not edited directly this time... apologies..
Tim Meader <tmeader@gmail.com> has cancelled Tim Meader <tmeader@gmail.com>'s request for superreview: Bug 191578: "Close Other Tabs" Needs a Confirmation Dialog http://bugzilla.mozilla.org/show_bug.cgi?id=191578 Attachment 148218: Final patch again, with one more variable rename (not edited directly this time... apologies... I don't work via patches too often) http://bugzilla.mozilla.org/attachment.cgi?id=148218&action=edit ...

superreview requested: [Bug 191578] "Close Other Tabs" Needs a Confirmation Dialog : [Attachment 148218] Final patch again, with one more variable rename (not edited directly this time... apologies..
Tim Meader <tmeader@gmail.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 191578: "Close Other Tabs" Needs a Confirmation Dialog http://bugzilla.mozilla.org/show_bug.cgi?id=191578 Attachment 148218: Final patch again, with one more variable rename (not edited directly this time... apologies... I don't work via patches too often) http://bugzilla.mozilla.org/attachment.cgi?id=148218&action=edit ...

superreview granted: [Bug 191578] "Close Other Tabs" Needs a Confirmation Dialog : [Attachment 147813] Updated version of yesterday's patch, this one applies to both Firefox and the Suite.
jag (Peter Annema) <jag@tty.nl> has granted jag (Peter Annema) <jag@tty.nl>'s request for superreview: Bug 191578: "Close Other Tabs" Needs a Confirmation Dialog http://bugzilla.mozilla.org/show_bug.cgi?id=191578 Attachment 147813: Updated version of yesterday's patch, this one applies to both Firefox and the Suite. http://bugzilla.mozilla.org/attachment.cgi?id=147813&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> >Index: xpfe/global/resources/content/bindings/tabbrowser.xml >==============================...

superreview requested: [Bug 191578] "Close Other Tabs" Needs a Confirmation Dialog : [Attachment 147965] Added missing conditional argument per jag
Tim Meader <tmeader@gmail.com> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 191578: "Close Other Tabs" Needs a Confirmation Dialog http://bugzilla.mozilla.org/show_bug.cgi?id=191578 Attachment 147965: Added missing conditional argument per jag http://bugzilla.mozilla.org/attachment.cgi?id=147965&action=edit ...

superreview granted: [Bug 191578] "Close Other Tabs" Needs a Confirmation Dialog : [Attachment 147965] Added missing conditional argument per jag
jag (Peter Annema) <jag@tty.nl> has granted Tim Meader <tmeader@gmail.com>'s request for superreview: Bug 191578: "Close Other Tabs" Needs a Confirmation Dialog http://bugzilla.mozilla.org/show_bug.cgi?id=191578 Attachment 147965: Added missing conditional argument per jag http://bugzilla.mozilla.org/attachment.cgi?id=147965&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> Hmmm, missed this the other times around, but numtabs should really be numTabs. No need for a new patch, whoever checks this in just needs to change...

superreview granted: [Bug 191578] "Close Other Tabs" Needs a Confirmation Dialog : [Attachment 147924] Final version (taking into account jag and dragon's changes)
jag (Peter Annema) <jag@tty.nl> has granted jag (Peter Annema) <jag@tty.nl>'s request for superreview: Bug 191578: "Close Other Tabs" Needs a Confirmation Dialog http://bugzilla.mozilla.org/show_bug.cgi?id=191578 Attachment 147924: Final version (taking into account jag and dragon's changes) http://bugzilla.mozilla.org/attachment.cgi?id=147924&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> netdragon is right. I thought I had explained why I wanted the conditional setBoolPref inside the shouldPrompt block, I guess...

superreview requested: [Bug 348183] scenario where clicking cancel in the "closing window with <n> tabs open" prompt closes the window, instead of keeing it open : [Attachment 233097] low risk patch u
Seth Spitzer [:ss] <sspitzer@mozilla.com> has asked Brian Ryner <bryner@gmail.com> for superreview: Bug 348183: scenario where clicking cancel in the "closing window with <n> tabs open" prompt closes the window, instead of keeing it open https://bugzilla.mozilla.org/show_bug.cgi?id=348183 Attachment 233097: low risk patch until everything is sorted out https://bugzilla.mozilla.org/attachment.cgi?id=233097&action=edit ------- Additional Comments from Seth Spitzer [:ss] <sspitzer@mozilla.com> I'm still nervous about changing nsGlobalWindow.cp...

superreview requested: [Bug 275430] change "open links from other applications" to be "a new tab in the most recent window" instead of "the most recent tab/window" : [Attachment 177848] Patch to make
Jeremy Morton <bugzilla@game-point.net> has asked Ben Goodger <bugs@bengoodger.com> for superreview: Bug 275430: change "open links from other applications" to be "a new tab in the most recent window" instead of "the most recent tab/window" https://bugzilla.mozilla.org/show_bug.cgi?id=275430 Attachment 177848: Patch to make externally-launched links open in new window https://bugzilla.mozilla.org/attachment.cgi?id=177848&action=edit ...

superreview cancelled: [Bug 275430] change "open links from other applications" to be "a new tab in the most recent window" instead of "the most recent tab/window" : [Attachment 177848] Patch to make
Mike Connor <mconnor@steelgryphon.com> has cancelled Jeremy Morton <bugzilla@game-point.net>'s request for superreview: Bug 275430: change "open links from other applications" to be "a new tab in the most recent window" instead of "the most recent tab/window" https://bugzilla.mozilla.org/show_bug.cgi?id=275430 Attachment 177848: Patch to make externally-launched links open in new window https://bugzilla.mozilla.org/attachment.cgi?id=177848&action=edit ------- Additional Comments from Mike Connor <mconnor@steelgryphon.com> New ...

superreview granted: [Bug 348183] scenario where clicking cancel in the "closing window with <n> tabs open" prompt closes the window, instead of keeping it open : [Attachment 233097] alternative, low
Brian Ryner <bryner@gmail.com> has granted Seth Spitzer [:ss] <sspitzer@mozilla.com>'s request for superreview: Bug 348183: scenario where clicking cancel in the "closing window with <n> tabs open" prompt closes the window, instead of keeping it open https://bugzilla.mozilla.org/show_bug.cgi?id=348183 Attachment 233097: alternative, low-risk patch until everything is sorted out https://bugzilla.mozilla.org/attachment.cgi?id=233097&action=edit ...

superreview granted: [Bug 300149] [SM v1.0a++, Windows] In "Add/Remove Programs", version is "1.0" instead of "1.0a" : [Attachment 189975] patch
Daniel Veditz <dveditz@cruzio.com> has granted Christian Biesinger (:bi) <cbiesinger@gmx.at>'s request for superreview: Bug 300149: [SM v1.0a++, Windows] In "Add/Remove Programs", version is "1.0" instead of "1.0a" https://bugzilla.mozilla.org/show_bug.cgi?id=300149 Attachment 189975: patch https://bugzilla.mozilla.org/attachment.cgi?id=189975&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> sr=dveditz This might lead to mysterious problems if someone leaves spaces on the end. Would a regexp ...

superreview requested: [Bug 300149] [SM v1.0a++, Windows] In "Add/Remove Programs", version is "1.0" instead of "1.0a" : [Attachment 189975] patch
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 300149: [SM v1.0a++, Windows] In "Add/Remove Programs", version is "1.0" instead of "1.0a" https://bugzilla.mozilla.org/show_bug.cgi?id=300149 Attachment 189975: patch https://bugzilla.mozilla.org/attachment.cgi?id=189975&action=edit ------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at> this should do it. kairo: note that this would not have been an issue had version.txt a new line at the end...

superreview cancelled: [Bug 268892] Command-w (Ctrl+W) does not close Element Properties window : [Attachment 167957] Add Accel+W "Close"
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has cancelled Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 268892: Command-w (Ctrl+W) does not close Element Properties window https://bugzilla.mozilla.org/show_bug.cgi?id=268892 Attachment 167957: Add Accel+W "Close" https://bugzilla.mozilla.org/attachment.cgi?id=167957&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> Whoops, sorry for the flag mix-up :-[ ...

Web resources about - superreview denied: [Bug 191578] "Close Other Tabs" Needs a Confirmation Dialog : [Attachment 128576] patch v1 should do the trick, adds a confirmation similar to what when you close a window full of - netscape.mozilla.reviewers

Confirmation - Wikipedia, the free encyclopedia
A bishop administering Confirmation. Rogier van der Weyden , The Seven Sacraments , 15th century. normally carried out through anointing , the ...

Confirmation - Wikipedia, the free encyclopedia
A bishop administering Confirmation. Rogier van der Weyden , The Seven Sacraments , 15th century. normally carried out through anointing , the ...

Facebook Reportedly Acquires Gowalla, No Confirmation From Either Company
... “most” of its employees and founder Josh Williams over to Palo Alto headquarters to work on Timeline, according to CNN. We could not get confirmation ...

Twitter reactions to the #Fed confirmation
... over Twitter — the last time that a new chairperson was appointed, Twitter wasn’t around. Within half an hour of the milestone confirmation, ...

Senate Confirmation Hearing (200910150008HQ) - Flickr - Photo Sharing!
U.S. Sen. Jay Rockefeller, D-W.Va., Chairman of the of the Senate Committee on Commerce, Science and Transportation, makes a point during the ...

Wet Hot American Summer: First Day of Camp - Cast Confirmation - Netflix - HD - YouTube
The counselors are confirmed for Wet Hot American Summer: First Day of Camp, a limited 8-episode series coming to Netflix just in time for summer. ...

Barry O'Sullivan's Senate confirmation delayed
Queensland will be without one of its senators until at least February next year.

Is this confirmation Prince George and Princess Charlotte's nanny is Mary Poppins?
The christening of Princess Charlotte was touted as &quot;modern&quot;. No one told the nanny.

Jurgen Klopp Liverpool, Jurgen Klopp news, Jurgen Klopp Liverpool confirmation
JURGEN Klopp is officially the new Liverpool manager.

Is this confirmation Prince George and Princess Charlotte's nanny is Mary ...
Sydney Morning Herald Is this confirmation Prince George and Princess Charlotte's nanny is Mary ... Sydney Morning Herald There were many ...

Resources last updated: 12/26/2015 8:09:07 PM