superreview cancelled: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 195950] Additional patch for lib/freebl from Wan-Teh, v2

Nelson Bolyard <nelson@bolyard.com> has cancelled Wan-Teh Chang
<wtchang@redhat.com>'s request for superreview:
Bug 303508: Add freebl shared libs that do only 64-bit integer math
https://bugzilla.mozilla.org/show_bug.cgi?id=303508

Attachment 195950: Additional patch for lib/freebl from Wan-Teh, v2
https://bugzilla.mozilla.org/attachment.cgi?id=195950&action=edit

------- Additional Comments from Nelson Bolyard <nelson@bolyard.com>
r=nelson.  Saul has some additional review comments coming soon, I think.

Suggestion:  In manifest.mn, instead of adding 5 new lines that all read:
>+    LIBRARY_VERSION := _$(LIBRARY_VERSION)

you might make a change something like the following, 
right after the endif for FREEBL_CHILD_BUILD

>-ifndef LIBRARY_NAME
>-  LIBRARY_NAME = freebl
>+ifneq($(LIBRARY_NAME),freebl)
>+    LIBRARY_VERSION := _$(LIBRARY_VERSION)
> endif
0
bugzilla
9/13/2005 10:06:56 PM
netscape.mozilla.reviewers 29156 articles. 0 followers. Follow

0 Replies
409 Views

Similar Articles

[PageSpeed] 38
Get it on Google Play
Get it on Apple App Store

Reply: