superreview requested: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 173080] updated patch file to reflect Mike's comments
olivier@umich.edu has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 263336: Add keyboard searching of "stored cookies" and "site permissions" lists. https://bugzilla.mozilla.org/show_bug.cgi?id=263336 Attachment 173080: updated patch file to reflect Mike's comments https://bugzilla.mozilla.org/attachment.cgi?id=173080&action=edit ...

superreview cancelled: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 173081] updated patch to reflect Mike's comment
Mike Pinkerton <pinkerton@aol.net> has cancelled olivier@umich.edu's request for superreview: Bug 263336: Add keyboard searching of "stored cookies" and "site permissions" lists. https://bugzilla.mozilla.org/show_bug.cgi?id=263336 Attachment 173081: updated patch to reflect Mike's comment https://bugzilla.mozilla.org/attachment.cgi?id=173081&action=edit ...

superreview requested: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 173081] updated patch to reflect Mike's comment
olivier@umich.edu has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 263336: Add keyboard searching of "stored cookies" and "site permissions" lists. https://bugzilla.mozilla.org/show_bug.cgi?id=263336 Attachment 173081: updated patch to reflect Mike's comment https://bugzilla.mozilla.org/attachment.cgi?id=173081&action=edit ------- Additional Comments from olivier@umich.edu did a mistake on the previous one, so here is the correct patch ...

superreview denied: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 168722] a new nib file with the sizing of the search field correctly set
Mike Pinkerton <pinkerton@aol.net> has denied Ludovic Hirlimann <qa-mozilla@hirlimann.net>'s request for superreview: Bug 263336: Add keyboard searching of "stored cookies" and "site permissions" lists. https://bugzilla.mozilla.org/show_bug.cgi?id=263336 Attachment 168722: a new nib file with the sizing of the search field correctly set https://bugzilla.mozilla.org/attachment.cgi?id=168722&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr- ...

superreview requested: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 168722] a new nib file with the sizing of the search field correctly set
Ludovic Hirlimann <qa-mozilla@hirlimann.net> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 263336: Add keyboard searching of "stored cookies" and "site permissions" lists. https://bugzilla.mozilla.org/show_bug.cgi?id=263336 Attachment 168722: a new nib file with the sizing of the search field correctly set https://bugzilla.mozilla.org/attachment.cgi?id=168722&action=edit ------- Additional Comments from Ludovic Hirlimann <qa-mozilla@hirlimann.net> mike .nib file and patch file are ok now, asking for sr and landing. ...

superreview cancelled: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 172300] source code
Mike Pinkerton <pinkerton@aol.net> has cancelled Julian Pellico <jpellico@hailmail.net>'s request for superreview: Bug 263336: Add keyboard searching of "stored cookies" and "site permissions" lists. https://bugzilla.mozilla.org/show_bug.cgi?id=263336 Attachment 172300: source code https://bugzilla.mozilla.org/attachment.cgi?id=172300&action=edit ...

superreview granted: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 173173] source code patch
Mike Pinkerton <pinkerton@aol.net> has granted olivier@umich.edu's request for superreview: Bug 263336: Add keyboard searching of "stored cookies" and "site permissions" lists. https://bugzilla.mozilla.org/show_bug.cgi?id=263336 Attachment 173173: source code patch https://bugzilla.mozilla.org/attachment.cgi?id=173173&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink ...

superreview requested: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 173173] source code patch
olivier@umich.edu has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 263336: Add keyboard searching of "stored cookies" and "site permissions" lists. https://bugzilla.mozilla.org/show_bug.cgi?id=263336 Attachment 173173: source code patch https://bugzilla.mozilla.org/attachment.cgi?id=173173&action=edit ...

superreview requested: [Bug 263336] Add keyboard searching of "stored cookies" and "site permissions" lists. : [Attachment 172300] source code
Julian Pellico <jpellico@hailmail.net> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 263336: Add keyboard searching of "stored cookies" and "site permissions" lists. https://bugzilla.mozilla.org/show_bug.cgi?id=263336 Attachment 172300: source code https://bugzilla.mozilla.org/attachment.cgi?id=172300&action=edit ------- Additional Comments from Julian Pellico <jpellico@hailmail.net> Requesting sr from pink. Plase beware the nib issue I mentioned. ...

superreview cancelled: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 181275] patch with pinkerton's comments addresed
Torben <torben@despammed.com> has cancelled Torben <torben@despammed.com>'s request for superreview: Bug 90918: RFE: Add url in "comments" field of the "get info" window when download file. https://bugzilla.mozilla.org/show_bug.cgi?id=90918 Attachment 181275: patch with pinkerton's comments addresed https://bugzilla.mozilla.org/attachment.cgi?id=181275&action=edit ...

superreview requested: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 181275] patch with pinkerton's comments addresed
Torben <torben@despammed.com> has asked Simon Fraser (on vacation) <sfraser_bugs@smfr.org> for superreview: Bug 90918: RFE: Add url in "comments" field of the "get info" window when download file. https://bugzilla.mozilla.org/show_bug.cgi?id=90918 Attachment 181275: patch with pinkerton's comments addresed https://bugzilla.mozilla.org/attachment.cgi?id=181275&action=edit ------- Additional Comments from Torben <torben@despammed.com> > does this only happen when dragging files? > what about when downloading them via normal means? ...

superreview cancelled: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 180129] Cleaned up patch, moving review requests
Mike Pinkerton <pinkerton@aol.net> has cancelled Torben <torben@despammed.com>'s request for superreview: Bug 90918: RFE: Add url in "comments" field of the "get info" window when download file. https://bugzilla.mozilla.org/show_bug.cgi?id=90918 Attachment 180129: Cleaned up patch, moving review requests https://bugzilla.mozilla.org/attachment.cgi?id=180129&action=edit ...

superreview granted: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 164339] Updated patch addressing Mike's sr comment
Mike Pinkerton <pinkerton@aol.net> has granted Bruce Davidson <Bruce.Davidson@iplbath.com>'s request for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 164339: Updated patch addressing Mike's sr comment https://bugzilla.mozilla.org/attachment.cgi?id=164339&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink, will land myself. ...

superreview requested: [Bug 266356] [patch] "Add Separator" button shoudn't be enabled in history view. : [Attachment 164339] Updated patch addressing Mike's sr comment
Bruce Davidson <Bruce.Davidson@iplbath.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 266356: [patch] "Add Separator" button shoudn't be enabled in history view. https://bugzilla.mozilla.org/show_bug.cgi?id=266356 Attachment 164339: Updated patch addressing Mike's sr comment https://bugzilla.mozilla.org/attachment.cgi?id=164339&action=edit ...