superreview cancelled: [Bug 193011] Some tabs unresponsive/won't close when many tabs are open: followup from bug 156405 : [Attachment 129377] Updated patch for reviewDavid Baron <dbaron@dbaron.org> has cancelled Randell Jesup
<rjesup@wgate.com>'s request for superreview:
Bug 193011: Some tabs unresponsive/won't close when many tabs are open:
followup from bug 156405
http://bugzilla.mozilla.org/show_bug.cgi?id=193011
Attachment 129377: Updated patch for review
http://bugzilla.mozilla.org/attachment.cgi?id=129377&action=edit
...
superreview cancelled: [Bug 193011] Some tabs unresponsive/won't close when many tabs are open: followup from bug 156405 : [Attachment 129300] Patch for review; includes handling ?David Baron <dbaron@dbaron.org> has cancelled Randell Jesup
<rjesup@wgate.com>'s request for superreview:
Bug 193011: Some tabs unresponsive/won't close when many tabs are open:
followup from bug 156405
http://bugzilla.mozilla.org/show_bug.cgi?id=193011
Attachment 129300: Patch for review; includes handling ?
http://bugzilla.mozilla.org/attachment.cgi?id=129300&action=edit
...
superreview requested: [Bug 193011] Some tabs unresponsive/won't close when many tabs are open: followup from bug 156405 : [Attachment 129377] Updated patch for reviewRandell Jesup <rjesup@wgate.com> has asked David Baron <dbaron@dbaron.org> for
superreview:
Bug 193011: Some tabs unresponsive/won't close when many tabs are open:
followup from bug 156405
http://bugzilla.mozilla.org/show_bug.cgi?id=193011
Attachment 129377: Updated patch for review
http://bugzilla.mozilla.org/attachment.cgi?id=129377&action=edit
...
superreview cancelled: [Bug 342432] After Undo Close Tab, content area of newly-opened page isn't focused : [Attachment 236968] always focus the reopened tab's content areaAaron Leventhal <aaronleventhal@moonset.net> has cancelled Simon B�nzli
<zeniko@gmail.com>'s request for superreview:
Bug 342432: After Undo Close Tab, content area of newly-opened page isn't
focused
https://bugzilla.mozilla.org/show_bug.cgi?id=342432
Attachment 236968: always focus the reopened tab's content area
https://bugzilla.mozilla.org/attachment.cgi?id=236968&action=edit
------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net>
I can't do superreviews and anyway you don't need them for chrome. You need a
toolkit...
superreview requested: [Bug 342432] After Undo Close Tab, content area of newly-opened page isn't focused : [Attachment 236968] always focus the reopened tab's content areaSimon B�nzli <zeniko@gmail.com> has asked Aaron Leventhal
<aaronleventhal@moonset.net> for superreview:
Bug 342432: After Undo Close Tab, content area of newly-opened page isn't
focused
https://bugzilla.mozilla.org/show_bug.cgi?id=342432
Attachment 236968: always focus the reopened tab's content area
https://bugzilla.mozilla.org/attachment.cgi?id=236968&action=edit
------- Additional Comments from Simon B�nzli <zeniko@gmail.com>
Like this?
...
superreview cancelled: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224087] updated patch, thanks gavinSeth Spitzer <sspitzer@mozilla.com> has cancelled Seth Spitzer
<sspitzer@mozilla.com>'s request for superreview:
Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new
blank tabs
https://bugzilla.mozilla.org/show_bug.cgi?id=339036
Attachment 224087: updated patch, thanks gavin
https://bugzilla.mozilla.org/attachment.cgi?id=224087&action=edit
...
superreview cancelled: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224127] revised patch, with two additional changes per gavinSeth Spitzer <sspitzer@mozilla.com> has cancelled Seth Spitzer
<sspitzer@mozilla.com>'s request for superreview:
Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new
blank tabs
https://bugzilla.mozilla.org/show_bug.cgi?id=339036
Attachment 224127: revised patch, with two additional changes per gavin
https://bugzilla.mozilla.org/attachment.cgi?id=224127&action=edit
------- Additional Comments from Seth Spitzer <sspitzer@mozilla.com>
re-requesting review from mconnor
...
superreview cancelled: [Bug 300485] Launching SeaMonkey when it's already running, with "open in new tab" preference, should open a new tab rather than window. : [Attachment 189715] Proposed patch (Wjag (Peter Annema) <jag@tty.nl> has cancelled neil@parkwaycc.co.uk
<neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview:
Bug 300485: Launching SeaMonkey when it's already running, with "open in new
tab" preference, should open a new tab rather than window.
https://bugzilla.mozilla.org/show_bug.cgi?id=300485
Attachment 189715: Proposed patch (Windows)
https://bugzilla.mozilla.org/attachment.cgi?id=189715&action=edit
...
superreview cancelled: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227973] tweaks in response to reviewsMarria Nazif <marria@gmail.com> has cancelled Marria Nazif <marria@gmail.com>'s
request for superreview:
Bug 241972: new window opened by window.open('xxx.exe') or target="_blank"
isn't closed automatically when a download begins
https://bugzilla.mozilla.org/show_bug.cgi?id=241972
Attachment 227973: tweaks in response to reviews
https://bugzilla.mozilla.org/attachment.cgi?id=227973&action=edit
------- Additional Comments from Marria Nazif <marria@gmail.com>
Actually, I'm going to go ahead and check this in on the trunk, since thes...
superreview cancelled: [Bug 327873] Return-to-parent tab doesn't work for tabs opened by target="_blank" links : [Attachment 223184] patch v2Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has cancelled
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for
superreview:
Bug 327873: Return-to-parent tab doesn't work for tabs opened by
target="_blank" links
https://bugzilla.mozilla.org/show_bug.cgi?id=327873
Attachment 223184: patch v2
https://bugzilla.mozilla.org/attachment.cgi?id=223184&action=edit
...
superreview requested: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patchChris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked
neil@parkwaycc.co.uk <neil@httl.net> for superreview:
Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab
bar when only one tab is open"] pref is ignored)
https://bugzilla.mozilla.org/show_bug.cgi?id=351289
Attachment 236765: patch
https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit
------- Additional Comments from Chris Thomas (CTho) [formerly
cst@andrew.cmu.edu] <cst@yecc.com>
If you show the tab bar:
Ctrl+F4 => close tab
...
superreview denied: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patchneil@parkwaycc.co.uk <neil@httl.net> has denied Chris Thomas (CTho) [formerly
cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview:
Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab
bar when only one tab is open"] pref is ignored)
https://bugzilla.mozilla.org/show_bug.cgi?id=351289
Attachment 236765: patch
https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit
------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
1. You shouldn't early return, you should reverse your conditi...
superreview cancelled: [Bug 344808] Canceling a [download whose link tries to open a new window] causes current tab to close, when browser.link.open_newwindow is 1 : [Attachment 230560] don't close wiSimon B�nzli <zeniko@gmail.com> has cancelled Simon B�nzli <zeniko@gmail.com>'s
request for superreview:
Bug 344808: Canceling a [download whose link tries to open a new window] causes
current tab to close, when browser.link.open_newwindow is 1
https://bugzilla.mozilla.org/show_bug.cgi?id=344808
Attachment 230560: don't close windows with session history
https://bugzilla.mozilla.org/attachment.cgi?id=230560&action=edit
...
superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank lChris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked
neil@parkwaycc.co.uk <neil@httl.net> for superreview:
Bug 156082: Don't hide the tab bar when clicking the close box (pref for
showing single tab ["Hide tab bar when only one tab is open"] is ignored)
https://bugzilla.mozilla.org/show_bug.cgi?id=156082
Attachment 233414: blank last tab
https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit
------- Additional Comments from Chris Thomas (CTho) [formerly
cst@andrew.cmu.edu] <cst@yecc.com>
Same as the Firefox imple...