superreview cancelled: [Bug 127461] Get New Messages stops working for one account : [Attachment 157869] Proposed patchMichael Kaply (IBM) <mkaply@us.ibm.com> has cancelled Larry Cook
<lcook@sybase.com>'s request for superreview:
Bug 127461: Get New Messages stops working for one account
https://bugzilla.mozilla.org/show_bug.cgi?id=127461
Attachment 157869: Proposed patch - Revision 2 based on Christian and David's
comments
https://bugzilla.mozilla.org/attachment.cgi?id=157869&action=edit
...
superreview granted: [Bug 127461] Get New Messages stops working for one account : [Attachment 158495] Proposed patchDavid Bienvenu <bienvenu@nventure.com> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 127461: Get New Messages stops working for one account
http://bugzilla.mozilla.org/show_bug.cgi?id=127461
Attachment 158495: Proposed patch - Revision 4
http://bugzilla.mozilla.org/attachment.cgi?id=158495&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
thx for doing this, looks good. I'm going to kill the unneeded braces in
nsPop3Protocol::OnTransportStatus() before I checkin, but it looks good.
...
superreview requested: [Bug 127461] Get New Messages stops working for one account : [Attachment 157869] Proposed patchLarry Cook <lcook@sybase.com> has asked David Bienvenu <bienvenu@nventure.com>
for superreview:
Bug 127461: Get New Messages stops working for one account
http://bugzilla.mozilla.org/show_bug.cgi?id=127461
Attachment 157869: Proposed patch - Revision 2 based on Christian and David's
comments
http://bugzilla.mozilla.org/attachment.cgi?id=157869&action=edit
...
superreview requested: [Bug 127461] Get New Messages stops working for one account : [Attachment 163392] fix the connection caseDavid Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 127461: Get New Messages stops working for one account
https://bugzilla.mozilla.org/show_bug.cgi?id=127461
Attachment 163392: fix the connection case
https://bugzilla.mozilla.org/attachment.cgi?id=163392&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
Christian and/or Larry, does this seem OK?
...
superreview granted: [Bug 127461] Get New Messages stops working for one account : [Attachment 163392] fix the connection caseScott MacGregor <mscott@mozilla.org> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 127461: Get New Messages stops working for one account
https://bugzilla.mozilla.org/show_bug.cgi?id=127461
Attachment 163392: fix the connection case
https://bugzilla.mozilla.org/attachment.cgi?id=163392&action=edit
...
superreview requested: [Bug 30057] Use one Local Mail tree for all POP3 accounts : [Attachment 148387] make get new messages on deferred account workDavid Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 30057: Use one Local Mail tree for all POP3 accounts
http://bugzilla.mozilla.org/show_bug.cgi?id=30057
Attachment 148387: make get new messages on deferred account work
http://bugzilla.mozilla.org/attachment.cgi?id=148387&action=edit
...
superreview granted: [Bug 30057] Use one Local Mail tree for all POP3 accounts : [Attachment 148387] make get new messages on deferred account workScott MacGregor <mscott@mozilla.org> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 30057: Use one Local Mail tree for all POP3 accounts
http://bugzilla.mozilla.org/show_bug.cgi?id=30057
Attachment 148387: make get new messages on deferred account work
http://bugzilla.mozilla.org/attachment.cgi?id=148387&action=edit
------- Additional Comments from Scott MacGregor <mscott@mozilla.org>
can you make the corresponding thunderbird changes to mailCommands.js and
mailWindowOverlay.js?
...
superreview requested: [Bug 252843] getting new mail for new, non-deferred pop3 account doesn't work until you restart. : [Attachment 154165] proposed fixDavid Bienvenu <bienvenu@nventure.com> has asked Seth Spitzer
<sspitzer@mozilla.org> for superreview:
Bug 252843: getting new mail for new, non-deferred pop3 account doesn't work
until you restart.
http://bugzilla.mozilla.org/show_bug.cgi?id=252843
Attachment 154165: proposed fix
http://bugzilla.mozilla.org/attachment.cgi?id=154165&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
I made sure the fundamental stuff works - clicking on a folder w/ an
out-of-date summary file does reparse the summary file.
...
superreview granted: [Bug 252843] getting new mail for new, non-deferred pop3 account doesn't work until you restart. : [Attachment 154165] proposed fixSeth Spitzer <sspitzer@mozilla.org> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 252843: getting new mail for new, non-deferred pop3 account doesn't work
until you restart.
http://bugzilla.mozilla.org/show_bug.cgi?id=252843
Attachment 154165: proposed fix
http://bugzilla.mozilla.org/attachment.cgi?id=154165&action=edit
------- Additional Comments from Seth Spitzer <sspitzer@mozilla.org>
sr=sspitzer
david, thanks for fixing this!
as far as regression testing, you might also want to check that news does the
rig...
superreview granted: [Bug 30057] Use one Local Mail tree for all POP3 accounts : [Attachment 148009] step 2Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 30057: Use one Local Mail tree for all POP3 accounts
http://bugzilla.mozilla.org/show_bug.cgi?id=30057
Attachment 148009: step 2 - get new mail on a pop3 deferred account downloads
mail into deferred to account
http://bugzilla.mozilla.org/attachment.cgi?id=148009&action=edit
...
superreview requested: [Bug 30057] Use one Local Mail tree for all POP3 accounts : [Attachment 148009] step 2David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 30057: Use one Local Mail tree for all POP3 accounts
http://bugzilla.mozilla.org/show_bug.cgi?id=30057
Attachment 148009: step 2 - get new mail on a pop3 deferred account downloads
mail into deferred to account
http://bugzilla.mozilla.org/attachment.cgi?id=148009&action=edit
...
superreview cancelled: [Bug 227490] POP3: messages in inbox doubled when get new mail runs after labelling a msg : [Attachment 136806] proposed fixDavid Bienvenu <bienvenu@nventure.com> has cancelled David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 227490: POP3: messages in inbox doubled when get new mail runs after
labelling a msg
http://bugzilla.mozilla.org/show_bug.cgi?id=227490
Attachment 136806: proposed fix
http://bugzilla.mozilla.org/attachment.cgi?id=136806&action=edit
------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
sorry, wrong patch
...
superreview requested: [Bug 254513] getting new mail for deferred pop3 account doesn't work the first time : [Attachment 155320] proposed fixDavid Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor
<mscott@mozilla.org> for superreview:
Bug 254513: getting new mail for deferred pop3 account doesn't work the first
time
http://bugzilla.mozilla.org/show_bug.cgi?id=254513
Attachment 155320: proposed fix
http://bugzilla.mozilla.org/attachment.cgi?id=155320&action=edit
...
superreview granted: [Bug 254513] getting new mail for deferred pop3 account doesn't work the first time : [Attachment 155320] proposed fixScott MacGregor <mscott@mozilla.org> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 254513: getting new mail for deferred pop3 account doesn't work the first
time
http://bugzilla.mozilla.org/show_bug.cgi?id=254513
Attachment 155320: proposed fix
http://bugzilla.mozilla.org/attachment.cgi?id=155320&action=edit
...
superreview granted: [Bug 30057] Use one Local Mail tree for all POP3 accounts : [Attachment 147944] step oneScott MacGregor <mscott@mozilla.org> has granted David Bienvenu
<bienvenu@nventure.com>'s request for superreview:
Bug 30057: Use one Local Mail tree for all POP3 accounts
http://bugzilla.mozilla.org/show_bug.cgi?id=30057
Attachment 147944: step one - remember which account a message came from, and
use it when deleting msgs from pop3 server
http://bugzilla.mozilla.org/attachment.cgi?id=147944&action=edit
...