superreview granted: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make senseJohnny Stenback <jst@netscape.com> has granted timeless@myrealbox.com
<timeless@bemail.org>'s request for superreview:
Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in
GlobalWindowImpl::Unescape
http://bugzilla.mozilla.org/show_bug.cgi?id=217896
Attachment 130691: don't do silly things that don't make sense
http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit
------- Additional Comments from Johnny Stenback <jst@netscape.com>
sr=jst
...
superreview requested: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sensetimeless@myrealbox.com <timeless@bemail.org> has asked Johnny Stenback
<jst@netscape.com> for superreview:
Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in
GlobalWindowImpl::Unescape
http://bugzilla.mozilla.org/show_bug.cgi?id=217896
Attachment 130691: don't do silly things that don't make sense
http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit
...
superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nondRobert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview:
Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title
in defs
https://bugzilla.mozilla.org/show_bug.cgi?id=340083
Attachment 224205: don't create frames for content we don't handle, don't
invalidate nondisplay content
https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit
...
ALERT: Don't save passwords in Firefox or don't lend your laptopALERT: Don't save passwords in Firefox or don't lend your laptop
http://blog.lxxm.com/blogview.asp?logID=904&cateID=10
There is a critical difference between keeping encoded passwords and showing
them directly. However, it seems Firefox developers has been ignoring it. It
is alerted here that if you lend your laptop with your account, you are
letting the user to view all of your passwords kept in your Firefox. To
check it, click Tools->Options->Privacy (Big Tab)-> Passwords(Small Tab) ->
View Saved Passwords(Button) -> Passwords Saved(Default Tab) -&g...
superreview granted: [Bug 363654] .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch : [Attachment 248458] disables .url in file:openStuart Morgan <stuart.morgan@alumni.case.edu> has granted Smokey Ardisson
(unreliable; no bugmail) <alqahira@ardisson.org>'s request for superreview:
Bug 363654: .url files opened via File:Open don't open/don't open properly on
the 1.8.0 branch
https://bugzilla.mozilla.org/show_bug.cgi?id=363654
Attachment 248458: disables .url in file:open
https://bugzilla.mozilla.org/attachment.cgi?id=248458&action=edit
------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu>
Well, that kinda sucks.
...
superreview requested: [Bug 363654] .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch : [Attachment 248458] disables .url in file:openSmokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org> has asked
Stuart Morgan <stuart.morgan@alumni.case.edu> for superreview:
Bug 363654: .url files opened via File:Open don't open/don't open properly on
the 1.8.0 branch
https://bugzilla.mozilla.org/show_bug.cgi?id=363654
Attachment 248458: disables .url in file:open
https://bugzilla.mozilla.org/attachment.cgi?id=248458&action=edit
------- Additional Comments from Smokey Ardisson (unreliable; no bugmail)
<alqahira@ardisson.org>
Asking for sr on this 7-char patch in case we need to take it ...
superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if tBrendan Eich <brendan@mozilla.org> has granted Johnny Stenback
<jst@mozilla.jstenback.com>'s request for superreview:
Bug 245619: Don't bother converting result of scripts into a string when the
caller doesn't care about the value.
http://bugzilla.mozilla.org/show_bug.cgi?id=245619
Attachment 150056: Don't convert the result to a string if the caller doesn't
care about the return value.
http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit
------- Additional Comments from Brendan Eich <brendan@mozilla.org>
Duh, thanks. r+sr=me....
superreview granted: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to creBrian Ryner <bryner@brianryner.com> has granted Aaron Leventhal
<aaronleventhal@moonset.net>'s request for superreview:
Bug 312788: Crash exposing invisible plugins
https://bugzilla.mozilla.org/show_bug.cgi?id=312788
Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at
it, make absolutely sure we don't ever try to create children for native
accessibles (make native accessibles inherit from the leaf class)
https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit
...
I don't know why my code don't work(it's for shopping cart)
I wrote this code for shopping cart.I used c lass for it and i want to store orders in cache.the customer username is in a session.customer select the product from a datalist.but and I want to show the orders in gridview .but when I select some product and go to the page that gridview is in it (shopping cart page)I could,t see any thing.please look at my code and see if I wrote my code incorrect.thanks for your helping me.------------------------------------------------------------------------- //the code for add product to shopping cart(products are in data list)protected void order(o...
superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #3Aaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 312788: Crash exposing invisible plugins
https://bugzilla.mozilla.org/show_bug.cgi?id=312788
Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at
it, make absolutely sure we don't ever try to create children for native
accessibles (make native accessibles inherit from the leaf class)
https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit
...
superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #2Aaron Leventhal (vacation: mostly gone until Oct 17)
<aaronleventhal@moonset.net> has asked Johnny Stenback <jst@mozilla.org> for
superreview:
Bug 312788: Crash exposing invisible plugins
https://bugzilla.mozilla.org/show_bug.cgi?id=312788
Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at
it, make absolutely sure we don't ever try to create children for native
accessibles (make native accessibles inherit from the leaf class)
https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit
...
superreview requested: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 264442: plugin finder can't find anything for windows media.
https://bugzilla.mozilla.org/show_bug.cgi?id=264442
Attachment 162212: Don't assume we don't have a plugin before getting a
responce from the network.
https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit
...
superreview requested: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string ifJohnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich
<brendan@mozilla.org> for superreview:
Bug 245619: Don't bother converting result of scripts into a string when the
caller doesn't care about the value.
http://bugzilla.mozilla.org/show_bug.cgi?id=245619
Attachment 150056: Don't convert the result to a string if the caller doesn't
care about the return value.
http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit
...
superreview granted: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback
<jst@mozilla.jstenback.com>'s request for superreview:
Bug 264442: plugin finder can't find anything for windows media.
https://bugzilla.mozilla.org/show_bug.cgi?id=264442
Attachment 162212: Don't assume we don't have a plugin before getting a
responce from the network.
https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
r+sr=bzbarsky, I guess..
Is ther a reason mIsBrokenPlugin is write-only?
...
superreview requested: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 179246] Like soBoris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozilla.org> for
superreview:
Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the
value
https://bugzilla.mozilla.org/show_bug.cgi?id=288574
Attachment 179246: Like so
https://bugzilla.mozilla.org/attachment.cgi?id=179246&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
This would be simpler if we could depend on the bit on mData, but since we
can't...
...
superreview denied: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 179246] Like soDavid Baron <dbaron@mozilla.org> has denied Boris Zbarsky <bzbarsky@mit.edu>'s
request for superreview:
Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the
value
https://bugzilla.mozilla.org/show_bug.cgi?id=288574
Attachment 179246: Like so
https://bugzilla.mozilla.org/attachment.cgi?id=179246&action=edit
------- Additional Comments from David Baron <dbaron@mozilla.org>
>@@ -752,17 +758,18 @@ CSSParserImpl::ParseAndAppendDeclaration
>+ if (!ParseDeclaration(errorCode, aDeclaration, PR_FALSE,
>+ PR_FAL...
superreview granted: [Bug 451234] don't stop plugins from loading just because they don't have a resource file : [Attachment 334535] fix v1.0Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> has granted
Josh Aas <joshmoz@gmail.com>'s request for superreview:
Bug 451234: don't stop plugins from loading just because they don't have a
resource file
https://bugzilla.mozilla.org/show_bug.cgi?id=451234
Attachment 334535: fix v1.0
https://bugzilla.mozilla.org/attachment.cgi?id=334535&action=edit
...
superreview requested: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 180304] Same as diff -wBoris Zbarsky <bzbarsky@mit.edu> has asked David Baron
<dbaron@mozillafoundation.org> for superreview:
Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the
value
https://bugzilla.mozilla.org/show_bug.cgi?id=288574
Attachment 180304: Same as diff -w
https://bugzilla.mozilla.org/attachment.cgi?id=180304&action=edit
...
superreview requested: [Bug 451234] don't stop plugins from loading just because they don't have a resource file : [Attachment 334535] fix v1.0Josh Aas <joshmoz@gmail.com> has asked Robert O'Callahan (:roc) (Mozilla
Corporation) <roc@ocallahan.org> for superreview:
Bug 451234: don't stop plugins from loading just because they don't have a
resource file
https://bugzilla.mozilla.org/show_bug.cgi?id=451234
Attachment 334535: fix v1.0
https://bugzilla.mozilla.org/attachment.cgi?id=334535&action=edit
...
superreview granted: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 180304] Same as diff -wDavid Baron <dbaron@mozillafoundation.org> has granted Boris Zbarsky
<bzbarsky@mit.edu>'s request for superreview:
Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the
value
https://bugzilla.mozilla.org/show_bug.cgi?id=288574
Attachment 180304: Same as diff -w
https://bugzilla.mozilla.org/attachment.cgi?id=180304&action=edit
...
superreview requested: [Bug 372571] Edit menu shortcuts don't work in Save file picker : [Attachment 311741] fix v1.2Josh Aas <joshmoz@gmail.com> has asked Vladimir Vukicevic (:vlad)
<vladimir@pobox.com> for superreview:
Bug 372571: Edit menu shortcuts don't work in Save file picker
https://bugzilla.mozilla.org/show_bug.cgi?id=372571
Attachment 311741: fix v1.2
https://bugzilla.mozilla.org/attachment.cgi?id=311741&action=edit
------- Additional Comments from Josh Aas <joshmoz@gmail.com>
Skip exposing the API via XPCOM for now.
...
superreview granted: [Bug 372571] Edit menu shortcuts don't work in Save file picker : [Attachment 311741] fix v1.2Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has granted Josh Aas
<joshmoz@gmail.com>'s request for superreview:
Bug 372571: Edit menu shortcuts don't work in Save file picker
https://bugzilla.mozilla.org/show_bug.cgi?id=372571
Attachment 311741: fix v1.2
https://bugzilla.mozilla.org/attachment.cgi?id=311741&action=edit
------- Additional Comments from Vladimir Vukicevic (:vlad)
<vladimir@pobox.com>
Ah, that works for me -- nsCocoaUtils sounds like a great place for it.
Thanks!
...
superreview requested: [Bug 372571] Edit menu shortcuts don't work in Save file picker : [Attachment 311499] fix v1.1Josh Aas <joshmoz@gmail.com> has asked Vladimir Vukicevic (:vlad)
<vladimir@pobox.com> for superreview:
Bug 372571: Edit menu shortcuts don't work in Save file picker
https://bugzilla.mozilla.org/show_bug.cgi?id=372571
Attachment 311499: fix v1.1
https://bugzilla.mozilla.org/attachment.cgi?id=311499&action=edit
...
superreview canceled: [Bug 372571] Edit menu shortcuts don't work in Save file picker : [Attachment 311499] fix v1.1Josh Aas <joshmoz@gmail.com> has canceled Josh Aas <joshmoz@gmail.com>'s
request for superreview:
Bug 372571: Edit menu shortcuts don't work in Save file picker
https://bugzilla.mozilla.org/show_bug.cgi?id=372571
Attachment 311499: fix v1.1
https://bugzilla.mozilla.org/attachment.cgi?id=311499&action=edit
------- Additional Comments from Josh Aas <joshmoz@gmail.com>
Skip exposing the API via XPCOM for now.
...