superreview requested: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882

Zack Weinberg <zweinberg@mozilla.com> has asked David Baron [:dbaron]
<dbaron@mozilla.com> for superreview:
Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work
https://bugzilla.mozilla.org/show_bug.cgi?id=3D93725

Attachment 323226: possible patch for this and #77882
https://bugzilla.mozilla.org/attachment.cgi?id=3D323226&action=3Dedit

------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com>
This proved to be pretty simple to fix, with some caveats.  The attached pa=
tch
passes Hixie's test linked from here, + its own reftests, and doesn't break=
 any
reftests.=0D
=0D
Caveat #1: Thebes does not implement nsIFontMetrics::GetFontHandle, which is
the obvious way to tell whether a change to the .weight field of an nsFont =
has
actually resulted in the selection of a different font.  The code in this p=
atch
is instead relying on the assumption that changing font weight is likely to
change the font's max-advance metric.  In local testing this works great for
proportional fonts, but not for monospace fonts (naturally enough) -- this =
is
still an improvement on the present state, but I would be grateful for bett=
er
ideas.=0D
=0D
Caveat #2: The reftests included in this patch are weaker than Hixie's
original.    I see no way to make them stronger without relying on a partic=
ular
font being installed on the testing system, but they did miss a bug in my f=
irst
attempt at a fix, that Hixie's test caught.=0D
=0D
Caveat #3: contra the previous code, I make no use whatsoever of weight val=
ues
that are not multiples of 100.	This is consistent with my reading of CSS2.1
but not consistent with the discussion in bug 77882.  I put more detailed n=
otes
there - see especially my (bug 77882 comment 7) and Hixie's (bug 77882 comm=
ent
2).  I'm inclined to say that this caveat, unlike possibly the other two,
should not block this bug; rather, if non-multiple-of-100 weights are somet=
imes
appropriate, we can leave bug 77882 open after this lands and fix it there.=
0
bugzilla
5/31/2008 7:28:24 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
921 Views

Similar Articles

[PageSpeed] 48
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview canceled: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has canceled Zack Weinberg <zweinberg@mozilla.com>'s request for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=323226&action=edit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> retracting review request. ...

''''''''''''''''''''
Name: haznen Email: haznenatyahoodotcom Product: Gran Paradiso Alpha 8 Summary: '''''''''''''''''''' Comments: '''''''''''''''''''''''''''''''''''' Browser Details: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061204 UGES/1.7.2.0 GranParadiso/3.0a1 From URL: http://www.mozilla.org/projects/granparadiso/ Note to readers: Hendrix gives...

'''''
Name: mario Email: ramar17atfastwebnetdotit Product: Gran Paradiso Alpha 2 Summary: ''''' Comments: K: Browser Details: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2) Gecko/20070206 GranParadiso/3.0a2 ...

'do' won't 'do' if '/'
Greetings to All from Au, Have a NetWare Perl 5.8.4 and wanted to tweak File\Spec\NW.pm to try and standardise on '/' separators. If I run a test script (t/uni/lower.t) with an unmodified NW.pm, it calls t/uni/case.pl, that, in case.pl, (when the path separators are '\'), the $file is '..\lib\unicore\To\Lower.pl' and the following code portion works, with $simple getting a returned table: sub casetest { my ($base, $spec, $func) = @_; my $file = File::Spec->catfile(File::Spec->catdir(File::Spec->updir, "lib", &qu...

superreview requested: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 317954] Patch v1.0
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 430650: '^' and '=C2=A8' chars don't work in password fields https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650 Attachment 317954: Patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=3D317954&action=3Dedit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> Katakai-san, please hurry up to review this, if you can.=0D =0D Roc: Would you r+sr for this? Even if we...

'''
Name: L Lachowsky Email: e2brutus_10atyahoodotcom Product: Firefox Summary: ''' Comments: why duddn this surprise me... I change default server from IE to Mozilla, and then i get error messages. well, shud I decide to not get on my computer with Mozilla..or shud I risk security breeches with IE....hmmm at least i can get on the internet with IE Browser Details: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5 From URL: http://hendrix.mozilla.org/ Note to readers: Hendrix gives no expectation of a response to this fee...

Cast from type ''''DBNull'''' to type ''''String'''' is not valid.
How do I avoid getting this error: Cast from type ''''DBNull'''' to type ''''String'''' is not valid. I am trying to get values from the database into a form for updating using a Datareader, SQL is set to allow nulls for certain fields as they are not required but the only way I can get the form to display is by adding a space in SQL. Is there another way around this? Check if it is equal to DBNull.Value first and if it is, don't do the cast.Stanley Tan theSpoke Blog Where in the code does it need to go? I am using the following and it's the profile that isn't always requi...

table_info('','','','%') cannot return any types
I was recently confirming table_info special cases and discovered the case for getting table_types cannot work. table_info('','','','%') should return a list of table types but it returns a list of empty strings instead: my @types = $h->tables('', '', '', '%'); print "all types:\n", join("xxx\n", @types), "\n"; # should output something like: # "dbo" # "INFORMATION_SCHEMA" # "sys" # and actually outputs: xxx xxx It seems to be down to the following ...

'or' or 'union'
Hello I was just wondering, in general what is better to use, an 'or' clause in a select or a 'union' to join two selects together. Do both statements create work tables? Many thanks Alex I think OR will be better than union. because suppose u have 3 tables and using OR u can join table a and table b and table c so each table will have only one read. but using union you will join table a and table b and in another query of union u will use table (a or b) and table c so ur one read is more in union . Ramdas Alex Cheung wrote: > Hello > >...

'IN' Clause or 'OR'
Hello, [1]: select * from TABLEA where COL1 IN('value1','value2''valu3'....) [2]:select * from TABLEA where COL1 = 'value1' OR COL1= 'value2' OR COL1='valu3'. TABLEA is a huge table and it has non-clustered index on COL1. Among the above 2 queries, which query will give me the better performance or fast response and WHY? What is the difference between 'IN' and 'OR' clauses as for as Sybase Optimization is concerned. Which is the better one to be used on huge tables. Thanks. Mac An IN list is treated ...

'b'..'a'
Hello. I'm using defferent 5.6.0's for Win32. I wonder wheter following behaviour is intentional or not: d:\>perl -e "print 'b'..'c'" bc d:\>perl -e "print 'b'..'a'" bcdefghijklmnopqrstuvwxyz I expected empty list in latter case, like in perl -e "print 'bb'..'a'" <!ENTITY Vadim REALLIFE "Vadim V.Konovalov, St.Petersburg, Russia"> &Vadim; On Wed, Sep 20, 2000 at 03:14:41PM +0400, Konovalov, Vadim wrote: > Hello. > > I'm using defferent 5.6.0'...

superreview granted: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 318391] Patch v1.1
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has granted=20 superreview: Bug 430650: '^' and '=C2=A8' chars don't work in password fields https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650 Attachment 318391: Patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=3D318391&action=3Dedit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> Thank you, Roc and Katakai-san.= ...

superreview granted: [Bug 430650] '^' and '=?UTF-8?Q?=C2=A8?=' chars don't work in password fields : [Attachment 317954] Patch v1.0
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 430650: '^' and '=C2=A8' chars don't work in password fields https://bugzilla.mozilla.org/show_bug.cgi?id=3D430650 Attachment 317954: Patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=3D317954&action=3Dedit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.or= g> + if (aState =3D=3D mIMEData->mEnabled) {=0D mIMEData->mEnabled =3D aState;=0D =0D...

superreview requested: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Neil: Easy fix, you forgot an arg ;-). ...

Web resources about - superreview requested: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882 - mozilla.dev.super-review

Resources last updated: 12/29/2015 4:58:49 AM