superreview denied: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312934] Disable and lock checking patch v1.0a
neil@parkwaycc.co.uk <neil@httl.net> has denied Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=3D79603 Attachment 312934: Disable and lock checking patch v1.0a https://bugzilla.mozilla.org/attachment.cgi?id=3D312934&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Unfortunately disabling colourpickers doesn't work correctly - the binding simply makes a bold claim that it's...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312933] Disable and lock checking patch v1.0
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312933: Disable and lock checking patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=312933&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> This patch: * Disables the color pickers when system colors box is checked as long as picker pref is not locked. * Re-enables the col...

superreview canceled: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312933] Disable and lock checking patch v1.0
Ian Neal <iann_bugzilla@blueyonder.co.uk> has canceled Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312933: Disable and lock checking patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=312933&action=edit ...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313971] Label disabling patch v1.1a
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313971: Label disabling patch v1.1a https://bugzilla.mozilla.org/attachment.cgi?id=313971&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Changes since v1.1: * Labels now have the same disabled status as their associated colorpicker. ...

superreview granted: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313971] Label disabling patch v1.1a
neil@parkwaycc.co.uk <neil@httl.net> has granted Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313971: Label disabling patch v1.1a https://bugzilla.mozilla.org/attachment.cgi?id=313971&action=edit ...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313728] Onchange patch v1.1
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313728: Onchange patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=313728&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Changes since v1.0a - addressed review comments: * use onchange on preference. * use preference value instead of checkbox setting. * set disabled prop...

superreview canceled: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313728] Onchange patch v1.1
Ian Neal <iann_bugzilla@blueyonder.co.uk> has canceled Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313728: Onchange patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=313728&action=edit ...

superreview requested: [Bug 408023] The indicator doesn' t look disabled in a disabled check menu item : [Attachment 292721] Patch
Michael Ventnor <ventnor.bugzilla@yahoo.com.au> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 408023: The indicator doesn't look disabled in a disabled check menu item https://bugzilla.mozilla.org/show_bug.cgi?id=408023 Attachment 292721: Patch https://bugzilla.mozilla.org/attachment.cgi?id=292721&action=edit ------- Additional Comments from Michael Ventnor <ventnor.bugzilla@yahoo.com.au> In the Library, you cannot remove the Name column which is represented by a disabled check menu item on the column menu to the top-righ...

superreview requested: [Bug 58048] [Pref Stylesheet]`Always use my colors' shouldn't remove colors from form controls [CASCADE]
David Baron [:dbaron] <dbaron@mozilla.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 58048: [Pref Stylesheet]`Always use my colors' shouldn't remove colors from form controls [CASCADE] https://bugzilla.mozilla.org/show_bug.cgi?id=58048 Attachment 264970: patch https://bugzilla.mozilla.org/attachment.cgi?id=264970&action=edit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> This patch fixes this bug and bug 255829 and improves on the fix for bug 255411. It reimplements the preference at the rule mapping...

superreview granted: [Bug 408023] The indicator doesn' t look disabled in a disabled check menu item : [Attachment 292721] Patch
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Michael Ventnor <ventnor.bugzilla@yahoo.com.au>'s request for superreview: Bug 408023: The indicator doesn't look disabled in a disabled check menu item https://bugzilla.mozilla.org/show_bug.cgi?id=408023 Attachment 292721: Patch https://bugzilla.mozilla.org/attachment.cgi?id=292721&action=edit ...

superreview requested: [Bug 258793] background-attachment checks should check that there's an image : [Attachment 158482] patch
David Baron <dbaron@dbaron.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 258793: background-attachment checks should check that there's an image http://bugzilla.mozilla.org/show_bug.cgi?id=258793 Attachment 158482: patch http://bugzilla.mozilla.org/attachment.cgi?id=158482&action=edit ...

superreview requested: [Bug 302416] NSS should not be using NSPR static libraries : [Attachment 190892] Fix the lock check for the unlock call. Handle the full explicit 'case 1' of the PKCS #11 locki
Robert Relyea <rrelyea@redhat.com> has asked for superreview: Bug 302416: NSS should not be using NSPR static libraries https://bugzilla.mozilla.org/show_bug.cgi?id=302416 Attachment 190892: Fix the lock check for the unlock call. Handle the full explicit 'case 1' of the PKCS #11 locking semantics. https://bugzilla.mozilla.org/attachment.cgi?id=190892&action=edit ...

superreview requested: [Bug 225809] Don't fall back to insecure authentication if "use secure authentication" is checked : [Attachment 135676] patch v1
Lorenzo Colitti <lorenzo@colitti.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 225809: Don't fall back to insecure authentication if "use secure authentication" is checked http://bugzilla.mozilla.org/show_bug.cgi?id=225809 Attachment 135676: patch v1 http://bugzilla.mozilla.org/attachment.cgi?id=135676&action=edit ------- Additional Comments from Lorenzo Colitti <lorenzo@colitti.com> Requesting sr. mscott, if you like it, can you check it in? I don't have CVS access. ...

superreview requested: [Bug 282141] Use system colors pref uses the wrong color for default background : [Attachment 174243] Patch
Christopher A. Aillon <caillon@gmail.com> has asked Christopher Blizzard <blizzard@mozilla.org> for superreview: Bug 282141: Use system colors pref uses the wrong color for default background https://bugzilla.mozilla.org/show_bug.cgi?id=282141 Attachment 174243: Patch https://bugzilla.mozilla.org/attachment.cgi?id=174243&action=edit ------- Additional Comments from Christopher A. Aillon <caillon@gmail.com> Use base, and get rid of an extra assignment of aColor (it gets assigned 0 in the default: branch of the switch) ...