superreview requested: [Bug 451123] [FIX]"ASSERTION: Don't call SetValueInternal for file inputs" : [Attachment 334733] Same as diff -w

Boris Zbarsky (todo: 200+ items) [gone 8/9--8/17] <bzbarsky@mit.edu> has asked
Jonas Sicking (:sicking) <jonas@sicking.cc> for superreview:
Bug 451123: [FIX]"ASSERTION: Don't call SetValueInternal for file inputs"
https://bugzilla.mozilla.org/show_bug.cgi?id=451123

Attachment 334733: Same as diff -w
https://bugzilla.mozilla.org/attachment.cgi?id=334733&action=edit
0
bugzilla
8/20/2008 6:54:07 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
441 Views

Similar Articles

[PageSpeed] 11
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 67873] [FILE]onchange for input type="file" doesn't behave correctly : [Attachment 141215] This fixes both testcases and the various tests I've tried with it
Boris Zbarsky <bzbarsky@mit.edu> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 67873: [FILE]onchange for input type="file" doesn't behave correctly http://bugzilla.mozilla.org/show_bug.cgi?id=67873 Attachment 141215: This fixes both testcases and the various tests I've tried with it http://bugzilla.mozilla.org/attachment.cgi?id=141215&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> peterv, I choose you! ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #4
Serge GAUTHERIE <gautheri@noos.fr> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> No super-review from <bienvenu@nventure.com> since '2004-04-26' :-( ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #3
Serge GAUTHERIE <gautheri@noos.fr> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 193698] "attachment" content shows a checkbox for "don't ask" : [Attachment 126900] fix other implementers
Christian Biesinger <cbiesinger@web.de> has asked Darin Fisher <darin@netscape.com> for superreview: Bug 193698: "attachment" content shows a checkbox for "don't ask" http://bugzilla.mozilla.org/show_bug.cgi?id=193698 Attachment 126900: fix other implementers http://bugzilla.mozilla.org/attachment.cgi?id=126900&action=edit ------- Additional Comments from Christian Biesinger <cbiesinger@web.de> bz: ok, I'll file those bugs when I checkin this patch ...

superreview requested: [Bug 241209] "Show File Location" and "Launch File" buttons (on download progress dialog) don't work : [Attachment 147465] patch
Christian Biesinger <cbiesinger@gmx.at> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 241209: "Show File Location" and "Launch File" buttons (on download progress dialog) don't work http://bugzilla.mozilla.org/show_bug.cgi?id=241209 Attachment 147465: patch http://bugzilla.mozilla.org/attachment.cgi?id=147465&action=edit ...

superreview requested: [Bug 216479] when saving drafts and templates, we don't save the "return receipts" and "attach vcard" info : [ Attachment 295016] proposed fix
Magnus Melin <mkmelin+mozilla@iki.fi> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 216479: when saving drafts and templates, we don't save the "return receipts" and "attach vcard" info https://bugzilla.mozilla.org/show_bug.cgi?id=216479 Attachment 295016: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=295016&action=edit ------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi> Everything else is in place, it's just that the parsed values were always overridden by the identity prefs...

superreview granted: [Bug 67873] [FIX][FILE]onchange for input type="file" doesn't behave correctly : [Attachment 141215] This fixes both testcases and the various tests I've tried with it
Peter Van der Beken <peterv@propagandism.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 67873: [FIX][FILE]onchange for input type="file" doesn't behave correctly http://bugzilla.mozilla.org/show_bug.cgi?id=67873 Attachment 141215: This fixes both testcases and the various tests I've tried with it http://bugzilla.mozilla.org/attachment.cgi?id=141215&action=edit ...

superreview requested: [Bug 383545] "Are you sure you want to quit?" dialog dismissal button should read "Don't Quit" : [Attachment 294627] Don 't Quit, now with better caps
Chris Lawson (cl-bugs) <cl-bugs@chrislawson.net> has asked Mark Mentovai <mark@moxienet.com> for superreview: Bug 383545: "Are you sure you want to quit?" dialog dismissal button should read "Don't Quit" https://bugzilla.mozilla.org/show_bug.cgi?id=383545 Attachment 294627: Don't Quit, now with better caps https://bugzilla.mozilla.org/attachment.cgi?id=294627&action=edit ------- Additional Comments from Chris Lawson (cl-bugs) <cl-bugs@chrislawson.net> r=me. Thanks for fixing the code as well. ...

superreview requested: [Bug 416063] "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) : [Attachment 304041] fix
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> for superreview: Bug 416063: "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) https://bugzilla.mozilla.org/show_bug.cgi?id=416063 Attachment 304041: fix https://bugzilla.mozilla.org/attachment.cgi?id=304041&action=edit ...

superreview requested: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1: "with no function call") : [Attachment 137553] (Iv1b) </xpinstall/*>, with no function call
Benjamin Smedberg <bsmedberg@covad.net> has asked Daniel Veditz <dveditz+bmo@cruzio.com> for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 137553: (Iv1b) </xpinstall/*>, with no function call http://bugzilla.mozilla.org/attachment.cgi?id=137553&action=edit ...

superreview requested: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 137544] (Gv1b) </mailnews/*>, with no function call
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 137544: (Gv1b) </mailnews/*>, with no function call http://bugzilla.mozilla.org/attachment.cgi?id=137544&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> 'r=?': (see comment 23) (moving sspitzer from r? to sr?) ...

superreview requested: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 137550] (Mv1) </embedding/*>, with no function call
Serge GAUTHERIE <gautheri@noos.fr> has asked Alec Flett <alecf@flett.org> for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 137550: (Mv1) </embedding/*>, with no function call http://bugzilla.mozilla.org/attachment.cgi?id=137550&action=edit ...

superreview requested: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 137533] (Av1c) </xpcom/*>, with no function call
Serge GAUTHERIE <gautheri@noos.fr> has asked Henry Jia <Henry.Jia@sun.com> for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 137533: (Av1c) </xpcom/*>, with no function call http://bugzilla.mozilla.org/attachment.cgi?id=137533&action=edit ...

Web resources about - superreview requested: [Bug 451123] [FIX]"ASSERTION: Don't call SetValueInternal for file inputs" : [Attachment 334733] Same as diff -w - mozilla.dev.super-review

Resources last updated: 1/12/2016 7:01:09 PM