superreview requested: [Bug 432132] Use <textbox type="number"> in Composer where applicable : [Attachment 320953] Fix textboxes in editor/ui

Stefan <stefanh@inbox.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for
superreview:
Bug 432132: Use <textbox type="number"> in Composer where applicable
https://bugzilla.mozilla.org/show_bug.cgi?id=432132

Attachment 320953: Fix textboxes in editor/ui
https://bugzilla.mozilla.org/attachment.cgi?id=320953&action=edit

------- Additional Comments from Stefan <stefanh@inbox.com>
Interestingly, if you type "99999999999999999999" in a number textbox the value
gets rounded to "100000000000000000000"...

This patch:
-Should fix all textboxes in editor/ui
-Removes some redundant js
-Removes some css because I decided to use size="3" on all textboxes that had
class="narrow"

There seem to be a lot of calls to ValidateNumber in the js, but it doesn't
seem to be used/working. At one stage, I think I noticed the dialog popping up,
even after I removed the call to ValidateNumber in the main prefs. But now it
doesn't seem to show up anymore anywere.

I'm not sure I like the spinbuttons when you have a menulist beside them, but I
guess that's the way it should be done.
0
bugzilla
5/14/2008 6:42:00 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
503 Views

Similar Articles

[PageSpeed] 36
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview denied: [Bug 432132] Use <textbox type="number"> in Composer where applicable : [Attachment 320953] Fix textboxes in editor/ui
neil@parkwaycc.co.uk <neil@httl.net> has denied Stefan <stefanh@inbox.com>'s request for superreview: Bug 432132: Use <textbox type="number"> in Composer where applicable https://bugzilla.mozilla.org/show_bug.cgi?id=432132 Attachment 320953: Fix textboxes in editor/ui https://bugzilla.mozilla.org/attachment.cgi?id=320953&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Well, type="number" seems to have a few issues in some of the dialogs. Some I noticed are: 1. Can't have an empty value (this ...

superreview requested: [Bug 432132] Use <textbox type="number"> in Composer where applicable : [Attachment 321090] Just fix editor/ui/composer/content/pref-composer.xul
Stefan <stefanh@inbox.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 432132: Use <textbox type="number"> in Composer where applicable https://bugzilla.mozilla.org/show_bug.cgi?id=432132 Attachment 321090: Just fix editor/ui/composer/content/pref-composer.xul https://bugzilla.mozilla.org/attachment.cgi?id=321090&action=edit ------- Additional Comments from Stefan <stefanh@inbox.com> As IanN suggests in comment #5... ...

superreview granted: [Bug 432132] Use <textbox type="number"> in Composer where applicable : [Attachment 321090] Just fix editor/ui/composer/content/pref-composer.xul
neil@parkwaycc.co.uk <neil@httl.net> has granted Stefan <stefanh@inbox.com>= 's request for superreview: Bug 432132: Use <textbox type=3D"number"> in Composer where applicable https://bugzilla.mozilla.org/show_bug.cgi?id=3D432132 Attachment 321090: Just fix editor/ui/composer/content/pref-composer.xul https://bugzilla.mozilla.org/attachment.cgi?id=3D321090&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >- oninput=3D" ValidateNumber(this, null, 0, 99); LimitStringLength('recentFiles',...

superreview requested: [Bug 345510] Add <textbox type="number"> : [Attachment 230578] Address review comments
Neil Deakin <enndeakin@sympatico.ca> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 345510: Add <textbox type="number"> https://bugzilla.mozilla.org/show_bug.cgi?id=345510 Attachment 230578: Address review comments https://bugzilla.mozilla.org/attachment.cgi?id=230578&action=edit ------- Additional Comments from Neil Deakin <enndeakin@sympatico.ca> >+ <property name="min"> > minvalue feels better to me. I used min and max to be consistent with <scale>. Do you think I should change scale to mi...

superreview requested: [Bug 345510] Add <textbox type="number"> : [Attachment 230935] address review comments
Neil Deakin <enndeakin@sympatico.ca> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 345510: Add <textbox type="number"> https://bugzilla.mozilla.org/show_bug.cgi?id=345510 Attachment 230935: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=230935&action=edit ------- Additional Comments from Neil Deakin <enndeakin@sympatico.ca> Hopefully, I've addressed all the review comments ...

superreview requested: [Bug 452415] Switch from <textbox type="timed"> to type="search" : [Attachment 335716] Patch for mailnews/addrbook/
neil@parkwaycc.co.uk <neil@httl.net> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 452415: Switch from <textbox type="timed"> to type="search" https://bugzilla.mozilla.org/show_bug.cgi?id=452415 Attachment 335716: Patch for mailnews/addrbook/ https://bugzilla.mozilla.org/attachment.cgi?id=335716&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> The real patch this time... ...

superreview requested: [Bug 452415] Switch from <textbox type="timed"> to type="search" : [Attachment 335715] Patch for mailnews/base/
neil@parkwaycc.co.uk <neil@httl.net> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 452415: Switch from <textbox type="timed"> to type="search" https://bugzilla.mozilla.org/show_bug.cgi?id=452415 Attachment 335715: Patch for mailnews/base/ https://bugzilla.mozilla.org/attachment.cgi?id=335715&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> ....since subscribe.xul is still shared, right? ...

superreview requested: [Bug 452415] Switch from <textbox type="timed"> to type="search" : [Attachment 335715] Patch for mailnews/base/ #2
Phil Ringnalda (:philor) <philringnalda@gmail.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 452415: Switch from <textbox type="timed"> to type="search" https://bugzilla.mozilla.org/show_bug.cgi?id=452415 Attachment 335715: Patch for mailnews/base/ https://bugzilla.mozilla.org/attachment.cgi?id=335715&action=edit ------- Additional Comments from Phil Ringnalda (:philor) <philringnalda@gmail.com> Nope, not shared - I already changed our fork, though I didn't have quite enough nerve to drop the 300ms tim...

superreview requested: [Bug 345510] Add <textbox type="number"> : [Attachment 230170] Add numberbox
Neil Deakin <enndeakin@sympatico.ca> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 345510: Add <textbox type="number"> https://bugzilla.mozilla.org/show_bug.cgi?id=345510 Attachment 230170: Add numberbox https://bugzilla.mozilla.org/attachment.cgi?id=230170&action=edit ...

superreview cancelled: [Bug 345510] Add <textbox type="number"> : [Attachment 230578] Address review comments
Neil Deakin <enndeakin@sympatico.ca> has cancelled Neil Deakin <enndeakin@sympatico.ca>'s request for superreview: Bug 345510: Add <textbox type="number"> https://bugzilla.mozilla.org/show_bug.cgi?id=345510 Attachment 230578: Address review comments https://bugzilla.mozilla.org/attachment.cgi?id=230578&action=edit ------- Additional Comments from Neil Deakin <enndeakin@sympatico.ca> Hopefully, I've addressed all the review comments ...

superreview granted: [Bug 345510] Add <textbox type="number"> : [Attachment 230935] address review comments
neil@parkwaycc.co.uk <neil@httl.net> has granted Neil Deakin <enndeakin@sympatico.ca>'s request for superreview: Bug 345510: Add <textbox type="number"> https://bugzilla.mozilla.org/show_bug.cgi?id=345510 Attachment 230935: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=230935&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >Index: themes/classic/global/win/numberbox.css >+.numberbox-input-box { >+ -moz-box-align: center; >+} The weirdness that is <html:input size=...

superreview requested: [Bug 399545] <textbox type="number"> spin buttons look wrong with some GTK themes : [Attachment 293922] patch, v1.2
Sylvain Pasche <sylvain.pasche@gmail.com> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 399545: <textbox type="number"> spin buttons look wrong with some GTK themes https://bugzilla.mozilla.org/show_bug.cgi?id=399545 Attachment 293922: patch, v1.2 https://bugzilla.mozilla.org/attachment.cgi?id=293922&action=edit ------- Additional Comments from Sylvain Pasche <sylvain.pasche@gmail.com> unbitrot ...

superreview requested: [Bug 399545] <textbox type="number"> spin buttons look wrong with some GTK themes : [Attachment 293943] add GTK theming for spinner and spinner-textfield
Teune van Steeg <twanno@lycos.nl> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 399545: <textbox type="number"> spin buttons look wrong with some GTK themes https://bugzilla.mozilla.org/show_bug.cgi?id=399545 Attachment 293943: add GTK theming for spinner and spinner-textfield https://bugzilla.mozilla.org/attachment.cgi?id=293943&action=edit ------- Additional Comments from Teune van Steeg <twanno@lycos.nl> This is the same patch as Sylvain posted, updated to use NS_THEME_SPINNER_TEXTFIELD to allow the entry p...

superreview canceled: [Bug 452415] Switch from <textbox type="timed"> to type="search" : [Attachment 335715] Patch for mailnews/base/
Phil Ringnalda (:philor) <philringnalda@gmail.com> has canceled Phil Ringnalda (:philor) <philringnalda@gmail.com>'s request for superreview: Bug 452415: Switch from <textbox type="timed"> to type="search" https://bugzilla.mozilla.org/show_bug.cgi?id=452415 Attachment 335715: Patch for mailnews/base/ https://bugzilla.mozilla.org/attachment.cgi?id=335715&action=edit ------- Additional Comments from Phil Ringnalda (:philor) <philringnalda@gmail.com> Which, fortunately, means you don't need the sr that you had before I midaired ...

Web resources about - superreview requested: [Bug 432132] Use <textbox type="number"> in Composer where applicable : [Attachment 320953] Fix textboxes in editor/ui - mozilla.dev.super-review

Resources last updated: 11/30/2015 2:04:10 PM