superreview requested: [Bug 428482] Add support for Kerberised LDAP to extensions/auth : [Attachment 315070] Patch for extenstions/auth

Simon Wilkinson <simon@sxw.org.uk> has asked Dan Mosedale <dmose@mozilla.org>
for superreview:
Bug 428482: Add support for Kerberised LDAP to extensions/auth
https://bugzilla.mozilla.org/show_bug.cgi?id=428482

Attachment 315070: Patch for extenstions/auth
https://bugzilla.mozilla.org/attachment.cgi?id=315070&action=edit

------- Additional Comments from Simon Wilkinson <simon@sxw.org.uk>
The extensions/auth module maintains a list of 'mailnews' protocols. Adding
Kerberised LDAP support to mailnews requires the addition of the LDAP service
name to this list.

Mailnews also requires the use of the THREADSAFE form of NS_IMPL_ISUPPORTS

The first change will not affect Firefox at all, the second is low risk for
Firefox. Both changes are required in order to add Kerberised LDAP support
(#308118) to Thunderbird.

The change was already reviewed in bug #308118 by bienvenu
0
bugzilla
4/11/2008 9:47:47 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
646 Views

Similar Articles

[PageSpeed] 30
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview canceled: [Bug 428482] Add support for Kerberised LDAP to extensions/auth : [Attachment 315070] Patch for extenstions/auth
Simon Wilkinson <simon@sxw.org.uk> has canceled Simon Wilkinson <simon@sxw.org.uk>'s request for superreview: Bug 428482: Add support for Kerberised LDAP to extensions/auth https://bugzilla.mozilla.org/show_bug.cgi?id=428482 Attachment 315070: Patch for extenstions/auth https://bugzilla.mozilla.org/attachment.cgi?id=315070&action=edit ...

superreview requested: [Bug 428482] Add support for Kerberised LDAP to extensions/auth : [Attachment 315118] Patch, with additional commentary
Simon Wilkinson <simon@sxw.org.uk> has asked for superreview: Bug 428482: Add support for Kerberised LDAP to extensions/auth https://bugzilla.mozilla.org/show_bug.cgi?id=428482 Attachment 315118: Patch, with additional commentary https://bugzilla.mozilla.org/attachment.cgi?id=315118&action=edit ...

superreview requested: [Bug 428482] Add support for Kerberised LDAP to extensions/auth : [Attachment 315118] Patch, with additional commentary #2
Simon Wilkinson <simon@sxw.org.uk> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 428482: Add support for Kerberised LDAP to extensions/auth https://bugzilla.mozilla.org/show_bug.cgi?id=428482 Attachment 315118: Patch, with additional commentary https://bugzilla.mozilla.org/attachment.cgi?id=315118&action=edit ...

superreview granted: [Bug 428482] Add support for Kerberised LDAP to extensions/auth : [Attachment 315118] Patch, with additional commentary
Dan Mosedale <dmose@mozilla.org> has granted Simon Wilkinson <simon@sxw.org.uk>'s request for superreview: Bug 428482: Add support for Kerberised LDAP to extensions/auth https://bugzilla.mozilla.org/show_bug.cgi?id=428482 Attachment 315118: Patch, with additional commentary https://bugzilla.mozilla.org/attachment.cgi?id=315118&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> Looks good; sr=dmose. Carrying forward bienvenu's r+ from the other bug. ...

superreview requested: [Bug 332483] LDAP userCertificate requests fail for ldap servers that require auth : [Attachment 219790] support login and password for cert certificate ldap searching
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 332483: LDAP userCertificate requests fail for ldap servers that require auth https://bugzilla.mozilla.org/show_bug.cgi?id=332483 Attachment 219790: support login and password for cert certificate ldap searching https://bugzilla.mozilla.org/attachment.cgi?id=219790&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> trying david. ...

superreview requested: [Bug 220380] Add SSL client auth stress tests. : [Attachment 222740] auth patch
Alexei Volkov <alexei.volkov.bugs@sun.com> has asked Julien Pierre <julien.pierre.bugs@sun.com> for superreview: Bug 220380: Add SSL client auth stress tests. https://bugzilla.mozilla.org/show_bug.cgi?id=220380 Attachment 222740: auth patch https://bugzilla.mozilla.org/attachment.cgi?id=222740&action=edit ...

superreview requested: [Bug 316995] When migrating from Internet Explorer http auth passwords are not migrated : [Attachment 229907] Add support for importing HTTP auth passwords from IE
Michael Wu <michael.wu@mozilla.com> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 316995: When migrating from Internet Explorer http auth passwords are not migrated https://bugzilla.mozilla.org/show_bug.cgi?id=316995 Attachment 229907: Add support for importing HTTP auth passwords from IE https://bugzilla.mozilla.org/attachment.cgi?id=229907&action=edit ------- Additional Comments from Michael Wu <michael.wu@mozilla.com> Ok, so I was wrong about http auth info not being stored in PStore. This patch adds support for importing HTTP auth data ...

superreview requested: [Bug 303160] Add support for GSSAPI Authentication to IMAP : [Attachment 192366] Revised sasl-auth patch
David Bienvenu <bienvenu@nventure.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 303160: Add support for GSSAPI Authentication to IMAP https://bugzilla.mozilla.org/show_bug.cgi?id=303160 Attachment 192366: Revised sasl-auth patch https://bugzilla.mozilla.org/attachment.cgi?id=192366&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> Yes, in the interest of trying to get it in today, I think Darin should review - Christopher has seen the code and I think is OK with the approach. ...

superreview requested: [Bug 303160] Add support for GSSAPI Authentication to IMAP : [Attachment 192409] Re-revised sasl-auth patch
Simon Wilkinson <simon@sxw.org.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 303160: Add support for GSSAPI Authentication to IMAP https://bugzilla.mozilla.org/show_bug.cgi?id=303160 Attachment 192409: Re-revised sasl-auth patch https://bugzilla.mozilla.org/attachment.cgi?id=192409&action=edit ------- Additional Comments from Simon Wilkinson <simon@sxw.org.uk> I've revised this patch to take into account Darin's comments: *) We're now called nsAuthSASL *) mGSSAPIModule is now mInnerModule I've kept the name as ...

superreview granted: [Bug 332483] LDAP userCertificate requests fail for ldap servers that require auth : [Attachment 219790] support login and password for cert certificate ldap searching
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 332483: LDAP userCertificate requests fail for ldap servers that require auth https://bugzilla.mozilla.org/show_bug.cgi?id=332483 Attachment 219790: support login and password for cert certificate ldap searching https://bugzilla.mozilla.org/attachment.cgi?id=219790&action=edit ...

superreview requested: [Bug 259031] Patch: Add support for displaying certificate extensions : [Attachment 192140] Patch v5
Wan-Teh Chang <wtchang@redhat.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 259031: Patch: Add support for displaying certificate extensions https://bugzilla.mozilla.org/show_bug.cgi?id=259031 Attachment 192140: Patch v5 https://bugzilla.mozilla.org/attachment.cgi?id=192140&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> Kai, Simon, could you review this very useful patch that improves our certificate display? Thanks. ...

superreview requested: [Bug 259031] Patch: Add support for displaying certificate extensions : [Attachment 206410] Patch v7
Kai Engert (kaie) <kengert@redhat.com> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 259031: Patch: Add support for displaying certificate extensions https://bugzilla.mozilla.org/show_bug.cgi?id=259031 Attachment 206410: Patch v7 https://bugzilla.mozilla.org/attachment.cgi?id=206410&action=edit ------- Additional Comments from Kai Engert (kaie) <kengert@redhat.com> This patch has Wan-Teh's requested change. carrying forward r=wtc Mike, could you please review again? Here are the differences between the patch you had already reviewed...

superreview requested: [Bug 259031] Patch: Add support for displaying certificate extensions : [Attachment 192140] Patch v5 #2
Kai Engert (kaie) <kengert@redhat.com> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 259031: Patch: Add support for displaying certificate extensions https://bugzilla.mozilla.org/show_bug.cgi?id=259031 Attachment 192140: Patch v5 https://bugzilla.mozilla.org/attachment.cgi?id=192140&action=edit ...

superreview requested: [Bug 259031] Patch: Add support for displaying certificate extensions : [Attachment 206410] Patch v7 #2
Kai Engert (kaie) <kengert@redhat.com> has asked Robert Relyea <rrelyea@redhat.com> for superreview: Bug 259031: Patch: Add support for displaying certificate extensions https://bugzilla.mozilla.org/show_bug.cgi?id=259031 Attachment 206410: Patch v7 https://bugzilla.mozilla.org/attachment.cgi?id=206410&action=edit ------- Additional Comments from Kai Engert (kaie) <kengert@redhat.com> Bob, can you please review the new snippets in this patch (see previous comment). ...

Web resources about - superreview requested: [Bug 428482] Add support for Kerberised LDAP to extensions/auth : [Attachment 315070] Patch for extenstions/auth - mozilla.dev.super-review

Resources last updated: 11/21/2015 3:35:50 PM