superreview requested: [Bug 428332] Add the MoFo EULA line back to SeaMonkey's about:license now that bug 368091 is fixed : [Attachment 316649] Fix, v1

Smokey Ardisson (behind; no bugmail - do not email) <alqahira@ardisson.org> has
asked neil@parkwaycc.co.uk <neil@httl.net> for superreview:
Bug 428332: Add the MoFo EULA line back to SeaMonkey's about:license now that
bug 368091 is fixed
https://bugzilla.mozilla.org/show_bug.cgi?id=428332

Attachment 316649: Fix, v1
https://bugzilla.mozilla.org/attachment.cgi?id=316649&action=edit

------- Additional Comments from Smokey Ardisson (behind; no bugmail - do not
email) <alqahira@ardisson.org>
This was a breeze to fix :)

Some notes:

1) I stuck this in suite/common since a license seemed like a file that would
be common to the whole suite.

2) Every project/module I've worked in so far seems to have slightly different
rules for where they stick certain hunks in a Makefile in relation to other
hunks, so if you prefer something somewhere else, I'm happy to change things
around (plus I wasn't sure of the best way to handle the DEFINES plus the
existing comment).

3) The wacky $(abs_srcdir) stuff there is to prevent Sun boxen from breaking
since $(srcdir) apparently confused them when I did this in Firefox.

4) I've only tested this (and only have access to) a Mac, but it's a straight
port of the Firefox bits, so unless you have more exotic platforms with other
strange Makefile variable behaviors, it should work fine.

The suggestion from #SeaMonkey was that this is mostly cross-module and UI, so
ask for r+sr=neil.
0
bugzilla
4/20/2008 5:50:32 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
843 Views

Similar Articles

[PageSpeed] 17
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview granted: [Bug 428332] Add the MoFo EULA line back to SeaMonkey's about:license now that bug 368091 is fixed : [Attachment 316649] Fix, v1
neil@parkwaycc.co.uk <neil@httl.net> has granted Smokey Ardisson (behind; no bugmail - do not email) <alqahira@ardisson.org>'s request for superreview: Bug 428332: Add the MoFo EULA line back to SeaMonkey's about:license now th= at bug 368091 is fixed https://bugzilla.mozilla.org/show_bug.cgi?id=3D428332 Attachment 316649: Fix, v1 https://bugzilla.mozilla.org/attachment.cgi?id=3D316649&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Thanks for doing this!=0D =0D >+# the following files are suite-specific overri...

superreview requested: [Bug 245066] [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) : [Attachment 156344] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 245066: [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) http://bugzilla.mozilla.org/show_bug.cgi?id=245066 Attachment 156344: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=156344&action=edit ...

superreview requested: [Bug 280947] Fix for bug 279945 breaks dragging of dynamic images : [Attachment 173629] Fix bz's issues.
Johnny Stenback <jst@mozilla.org> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 280947: Fix for bug 279945 breaks dragging of dynamic images https://bugzilla.mozilla.org/show_bug.cgi?id=280947 Attachment 173629: Fix bz's issues. https://bugzilla.mozilla.org/attachment.cgi?id=173629&action=edit ...

superreview requested: [Bug 360511] [FIX]Going back to page with URL hash (#foo) doesn't show hash part : [Attachment 245427] Fixes bug, as expected
Boris Zbarsky <bzbarsky@mit.edu> has asked Jonas Sicking <bugmail@sicking.cc> for superreview: Bug 360511: [FIX]Going back to page with URL hash (#foo) doesn't show hash part https://bugzilla.mozilla.org/show_bug.cgi?id=360511 Attachment 245427: Fixes bug, as expected https://bugzilla.mozilla.org/attachment.cgi?id=245427&action=edit ...

superreview requested: [Bug 229737] [RFE] Favicons for XUL error pages : [Attachment 193389] address Neil's comments, fix seamonkey's check
Mike Connor <mconnor@steelgryphon.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 229737: [RFE] Favicons for XUL error pages https://bugzilla.mozilla.org/show_bug.cgi?id=229737 Attachment 193389: address Neil's comments, fix seamonkey's check https://bugzilla.mozilla.org/attachment.cgi?id=193389&action=edit ------- Additional Comments from Mike Connor <mconnor@steelgryphon.com> this addresses all but the 256 color-safe issue, which is an edge case ...

superreview requested: [Bug 404513] Add Makefile target to launch solo xpcshell test without interactive mode : [Attachment 292421] Patch which fixes the Bz's bug
Laurent Jouanneau <laurent@xulfr.org> has asked Ted Mielczarek (:luser) <ted.mielczarek@gmail.com> for superreview: Bug 404513: Add Makefile target to launch solo xpcshell test without interactive mode https://bugzilla.mozilla.org/show_bug.cgi?id=404513 Attachment 292421: Patch which fixes the Bz's bug https://bugzilla.mozilla.org/attachment.cgi?id=292421&action=edit ------- Additional Comments from Laurent Jouanneau <laurent@xulfr.org> Here is a little patch which fix the bug found by Boris. ...

superreview requested: [Bug 92686] Return inserts line break, should insert paragraph break : [Attachment 156598] fix #3, in answer to brade's and akkana's comments
Johnny Stenback <jst@mozilla.jstenback.com> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 92686: Return inserts line break, should insert paragraph break https://bugzilla.mozilla.org/show_bug.cgi?id=92686 Attachment 156598: fix #3, in answer to brade's and akkana's comments https://bugzilla.mozilla.org/attachment.cgi?id=156598&action=edit ...

superreview requested: [Bug 360579] [FIX]Fix for bug 326009 doesn't work quite right with more than 2 tabs : [Attachment 245463] Fix
Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 360579: [FIX]Fix for bug 326009 doesn't work quite right with more than 2 tabs https://bugzilla.mozilla.org/show_bug.cgi?id=360579 Attachment 245463: Fix https://bugzilla.mozilla.org/attachment.cgi?id=245463&action=edit ...

superreview requested: [Bug 269581] NSS calls C_GetAttributeValue unnecessarily when token is logged in : [Attachment 175370] fixes integrating Bob and Wan-Teh's review comments. Also fix bogus logic
Julien Pierre <julien.pierre.bugs@sun.com> has asked Robert Relyea <rrelyea@redhat.com> for superreview: Bug 269581: NSS calls C_GetAttributeValue unnecessarily when token is logged in https://bugzilla.mozilla.org/show_bug.cgi?id=269581 Attachment 175370: fixes integrating Bob and Wan-Teh's review comments. Also fix bogus logic https://bugzilla.mozilla.org/attachment.cgi?id=175370&action=edit ...

superreview requested: [Bug 292268] Standardize SeaMonkey package/installer filenames based on toolkit's package-name.mk : [Attachment 188113] simpler win stub installer fix v1.2
Ian Neal <bugzilla@arlen.demon.co.uk> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 292268: Standardize SeaMonkey package/installer filenames based on toolkit's package-name.mk https://bugzilla.mozilla.org/show_bug.cgi?id=292268 Attachment 188113: simpler win stub installer fix v1.2 https://bugzilla.mozilla.org/attachment.cgi?id=188113&action=edit ...

superreview requested: [Bug 242441] Port fix to bug 242082 to SeaMonkey : [Attachment 148964] Fix issues
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked Alec Flett <alecf@flett.org> for superreview: Bug 242441: Port fix to bug 242082 to SeaMonkey http://bugzilla.mozilla.org/show_bug.cgi?id=242441 Attachment 148964: Fix issues http://bugzilla.mozilla.org/attachment.cgi?id=148964&action=edit ...

superreview requested: [Bug 103638] targets with same name in different windows open in wrong window with javascript : [Attachment 170288] Proposed fix, bz's fix with window.open() etc fixed.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 103638: targets with same name in different windows open in wrong window with javascript https://bugzilla.mozilla.org/show_bug.cgi?id=103638 Attachment 170288: Proposed fix, bz's fix with window.open() etc fixed. https://bugzilla.mozilla.org/attachment.cgi?id=170288&action=edit ...

superreview requested: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293607] fix assert
Robert O'Callahan (:roc) <roc@ocallahan.org> has asked Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293607: fix assert https://bugzilla.mozilla.org/attachment.cgi?id=293607&action=edit ------- Additional Comments from Robert O'Callahan (:roc) <roc@ocallahan.org> This patch creates nsBlockFrame* nsLayoutUtils::GetAsBlock wh...

superreview requested: [Bug 21616] Space after ::first-letter pseudo-element line is larger than between other lines : [Attachment 166184] fix based on MathML's GetBoundingMetrics
rbs@maths.uq.edu.au has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 21616: Space after ::first-letter pseudo-element line is larger than between other lines https://bugzilla.mozilla.org/show_bug.cgi?id=21616 Attachment 166184: fix based on MathML's GetBoundingMetrics https://bugzilla.mozilla.org/attachment.cgi?id=166184&action=edit ------- Additional Comments from rbs@maths.uq.edu.au Asking r/sr to beautify ::first-letter by default at little cost (since MathML is on by default these days). ...

Web resources about - superreview requested: [Bug 428332] Add the MoFo EULA line back to SeaMonkey's about:license now that bug 368091 is fixed : [Attachment 316649] Fix, v1 - mozilla.dev.super-review

Resources last updated: 1/13/2016 7:14:15 PM