superreview requested: [Bug 423998] Fix repainting regression(s) and multiple invalidation bugs : [Attachment 313859] address review comments

Robert Longson <longsonr@gmail.com> has asked Robert O'Callahan (:roc) (reduced
activity March 18 to April 9) <roc@ocallahan.org> for superreview:
Bug 423998: Fix repainting regression(s) and multiple invalidation bugs
https://bugzilla.mozilla.org/show_bug.cgi?id=423998

Attachment 313859: address review comments
https://bugzilla.mozilla.org/attachment.cgi?id=313859&action=edit

------- Additional Comments from Robert Longson <longsonr@gmail.com>
(In reply to comment #17)

> nsSVGUtils.cpp: The DoUpdate changes are not necessary. Please revert them
for
> now. 

Done.

> In UpdateGraphic the NS_STATE_SVG_NONDISPLAY_CHILD check is not valid for
> all nsIFrame implementations. That bit is used for different things on
non-SVG
> frames. You should be able to just change the argument to be of type
> nsISVGChildFrame* and kill the QI.

Done, however GetStateBits is a method of nsIFrame so I still need a QI. Doing
it your way I need it from nsISVGChildFrame to nsIFrame rather than vice versa.


We could put guards into various functions using IsFrameOfType in some other
followup bug I guess.

> 
> My only other comment would be that the UpdateGlyphPositioning call in
> nsSVGTextFrame::NotifyGlyphMetricsChange seems quite undesirable. If that's
the
> way it was before then you're right, probably safest to just put it back for
> now.
> 

It's necessary to prevent some of the redraw regressions.
0
bugzilla
4/5/2008 10:46:41 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
651 Views

Similar Articles

[PageSpeed] 56
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview canceled: [Bug 423998] Fix repainting regression(s) and multiple invalidation bugs : [Attachment 313859] address review comments
Robert Longson <longsonr@gmail.com> has canceled Robert Longson <longsonr@gmail.com>'s request for superreview: Bug 423998: Fix repainting regression(s) and multiple invalidation bugs https://bugzilla.mozilla.org/show_bug.cgi?id=423998 Attachment 313859: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=313859&action=edit ...

superreview requested: [Bug 423998] Fix repainting regression(s) and multiple invalidation bugs : [Attachment 313860] oops redid the wrong bit
Robert Longson <longsonr@gmail.com> has asked Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> for superreview: Bug 423998: Fix repainting regression(s) and multiple invalidation bugs https://bugzilla.mozilla.org/show_bug.cgi?id=423998 Attachment 313860: oops redid the wrong bit https://bugzilla.mozilla.org/attachment.cgi?id=313860&action=edit ...

superreview granted: [Bug 423998] Fix repainting regression(s) and multiple invalidation bugs : [Attachment 313860] oops redid the wrong bit
Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> has granted Robert Longson <longsonr@gmail.com>'s request for superreview: Bug 423998: Fix repainting regression(s) and multiple invalidation bugs https://bugzilla.mozilla.org/show_bug.cgi?id=423998 Attachment 313860: oops redid the wrong bit https://bugzilla.mozilla.org/attachment.cgi?id=313860&action=edit ------- Additional Comments from Robert O'Callahan (:roc) (reduced activity March 18 to April 9) <roc@ocallahan.org> + nsISVGChildFrame* svgChildFrame = nsnu...

superreview requested: [Bug 269581] NSS calls C_GetAttributeValue unnecessarily when token is logged in : [Attachment 175370] fixes integrating Bob and Wan-Teh's review comments. Also fix bogus logic
Julien Pierre <julien.pierre.bugs@sun.com> has asked Robert Relyea <rrelyea@redhat.com> for superreview: Bug 269581: NSS calls C_GetAttributeValue unnecessarily when token is logged in https://bugzilla.mozilla.org/show_bug.cgi?id=269581 Attachment 175370: fixes integrating Bob and Wan-Teh's review comments. Also fix bogus logic https://bugzilla.mozilla.org/attachment.cgi?id=175370&action=edit ...

superreview requested: [Bug 348455] Review comments in bug 285727 never got addressed : [Attachment 233863] Patch
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 348455: Review comments in bug 285727 never got addressed https://bugzilla.mozilla.org/show_bug.cgi?id=348455 Attachment 233863: Patch https://bugzilla.mozilla.org/attachment.cgi?id=233863&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> bernd is out of town ...

superreview granted: [Bug 348455] [FIX]Review comments in bug 285727 never got addressed : [Attachment 233863] Patch
David Baron <dbaron@mozilla.com> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 348455: [FIX]Review comments in bug 285727 never got addressed https://bugzilla.mozilla.org/show_bug.cgi?id=348455 Attachment 233863: Patch https://bugzilla.mozilla.org/attachment.cgi?id=233863&action=edit ...

superreview requested: [Bug 233721] Port of Firefox bug 182928 to Seamonkey (Add confirmation for Set As Wallpaper) : [Attachment 141129] Addressed review comments
timeless@myrealbox.com (working) <timeless@bemail.org> has asked tor@acm.org for superreview: Bug 233721: Port of Firefox bug 182928 to Seamonkey (Add confirmation for Set As Wallpaper) http://bugzilla.mozilla.org/show_bug.cgi?id=233721 Attachment 141129: Addressed review comments http://bugzilla.mozilla.org/attachment.cgi?id=141129&action=edit ...

superreview requested: [Bug 309837] Port fix to bug 296012 to Suite's help viewer : [Attachment 199473] Patch with comments addressed
Jeff Walden (remove +fxhelp to email) <jwalden+fxhelp@mit.edu> has asked Alec Flett <alecf@flett.org> for superreview: Bug 309837: Port fix to bug 296012 to Suite's help viewer https://bugzilla.mozilla.org/show_bug.cgi?id=309837 Attachment 199473: Patch with comments addressed https://bugzilla.mozilla.org/attachment.cgi?id=199473&action=edit ...

superreview requested: [Bug 274083] nsXFormsSchemaValidator : [Attachment 168647] shim with darin's review comments fixed.
Doron Rosenberg (IBM) <doronr@gmail.com> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 274083: nsXFormsSchemaValidator https://bugzilla.mozilla.org/show_bug.cgi?id=274083 Attachment 168647: shim with darin's review comments fixed. https://bugzilla.mozilla.org/attachment.cgi?id=168647&action=edit ...

superreview requested: [Bug 345418] ASSERTION: trying to construct an SVGTSpanFrame for an invalid container : [Attachment 232675] address review comment
Robert Longson <longsonr@gmail.com> has asked T Rowley (IBM) <tor@acm.org> for superreview: Bug 345418: ASSERTION: trying to construct an SVGTSpanFrame for an invalid container https://bugzilla.mozilla.org/show_bug.cgi?id=345418 Attachment 232675: address review comment https://bugzilla.mozilla.org/attachment.cgi?id=232675&action=edit ...

superreview requested: [Bug 299757] Dates in Go menu not localizable : [Attachment 188580] Addressing's reviewer comments
Ludovic Hirlimann <qa-mozilla@hirlimann.net> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 299757: Dates in Go menu not localizable https://bugzilla.mozilla.org/show_bug.cgi?id=299757 Attachment 188580: Addressing's reviewer comments https://bugzilla.mozilla.org/attachment.cgi?id=188580&action=edit ...

superreview requested: [Bug 357630] [FIX]Have a way to insert identical elements into an nsTArray : [Attachment 244382] Address review comments
Boris Zbarsky <bzbarsky@mit.edu> has asked for superreview: Bug 357630: [FIX]Have a way to insert identical elements into an nsTArray https://bugzilla.mozilla.org/show_bug.cgi?id=357630 Attachment 244382: Address review comments https://bugzilla.mozilla.org/attachment.cgi?id=244382&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Made Jonas' changes, renamed to InsertElementsAt, made it return elem_type* like the other InsertElementsAt methods. ...

superreview requested: [Bug 334587] Unify event handling for links and fix various XLink bugs : [Attachment 219749] patch - address smaug's comments
Jonathan Watt <jwatt@jwatt.org> has asked Jonas Sicking <bugmail@sicking.cc> for superreview: Bug 334587: Unify event handling for links and fix various XLink bugs https://bugzilla.mozilla.org/show_bug.cgi?id=334587 Attachment 219749: patch - address smaug's comments https://bugzilla.mozilla.org/attachment.cgi?id=219749&action=edit ...

superreview requested: [Bug 155484] Edit menu should apply to bookmarks : [Attachment 179214] smfr's review comments addressed
Bruce Davidson <Bruce.Davidson@iplbath.com> has asked Mike Pinkerton <pinkerton@aol.net> for superreview: Bug 155484: Edit menu should apply to bookmarks https://bugzilla.mozilla.org/show_bug.cgi?id=155484 Attachment 179214: smfr's review comments addressed https://bugzilla.mozilla.org/attachment.cgi?id=179214&action=edit ------- Additional Comments from Bruce Davidson <Bruce.Davidson@iplbath.com> Revised patch that addresses all Simon's review comments except moving code to BookmarkManager. Discussed on IRC, not thought to be worth doing. MozURLTyp...

Web resources about - superreview requested: [Bug 423998] Fix repainting regression(s) and multiple invalidation bugs : [Attachment 313859] address review comments - mozilla.dev.super-review

Resources last updated: 1/17/2016 1:43:20 AM