superreview requested: [Bug 412360] Download Manager remains empty, downloads don't start, with this 3.0b2 downloads.sqlite : [Attachment 306041] v1

Edward Lee (Mardak) <edilee@gmail.com> has asked  for superreview:
Bug 412360: Download Manager remains empty, downloads don't start, with this
3.0b2 downloads.sqlite
https://bugzilla.mozilla.org/show_bug.cgi?id=412360

Attachment 306041: v1
https://bugzilla.mozilla.org/attachment.cgi?id=306041&action=edit

------- Additional Comments from Edward Lee (Mardak) <edilee@gmail.com>
data:text/html,<a href="javascript:alert(5)">javascript uris fail to save</a>

Load that and alt-click it to download. webbrowserpersist and download will be
added but saveURI fails without letting the nsITransfer download know about it,
so the download stays in QUEUED state.

This patch fixes the problem of getting into the state of the attached
downloads.sqlite by having WBP fail the download.

Also, without the nsDownloadManager change, it would also fix the problem of
starting the download manager with the downloads.sqlite because the *second*
time you load the download manager service, the javascript: uri download will
already have been set to failed.

*With* the nsDownloadManager change, we ignore the fact that the download
failed when starting, and the user will see a failed message for the download
the first time they try opening the download manager.
0
bugzilla
2/27/2008 5:49:13 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
598 Views

Similar Articles

[PageSpeed] 5

Reply:

Similar Artilces:

superreview requested: [Bug 412360] Download Manager remains empty, downloads don't start, with this 3.0b2 downloads.sqlite : [Attachment 306041] v1 #2
Edward Lee (Mardak) <edilee@gmail.com> has asked Christian :Biesinger <cbiesinger@gmx.at> for superreview: Bug 412360: Download Manager remains empty, downloads don't start, with this 3.0b2 downloads.sqlite https://bugzilla.mozilla.org/show_bug.cgi?id=412360 Attachment 306041: v1 https://bugzilla.mozilla.org/attachment.cgi?id=306041&action=edit ...

superreview granted: [Bug 412360] Download Manager remains empty, downloads don't start, with this 3.0b2 downloads.sqlite : [Attachment 306041] v1
Christian :Biesinger <cbiesinger@gmail.com> has granted Edward Lee (Mardak) <edilee@gmail.com>'s request for superreview: Bug 412360: Download Manager remains empty, downloads don't start, with this 3.0b2 downloads.sqlite https://bugzilla.mozilla.org/show_bug.cgi?id=3D412360 Attachment 306041: v1 https://bugzilla.mozilla.org/attachment.cgi?id=3D306041&action=3Dedit ------- Additional Comments from Christian :Biesinger <cbiesinger@gmail.com> + SendErrorStatusChange(PR_TRUE, rv, nsnull, aFile);=0D =0D hmm... why not pass the channel here instead o...

superreview granted: [Bug 397935] Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") : [Attachment 3 #3
Mike Connor <mconnor@mozilla.com> has granted Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns.com>'s request for superreview: Bug 397935: Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") https://bugzilla.mozilla.org/show_bug.cgi?id=397935 Attachment 312112: v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=312112&action=edit ------- Additional Comments from Mike Connor <mconnor@mozilla.com> sr=mconnor, I would probably explici...

superreview requested: [Bug 397935] Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") : [Attachment
Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns.com> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 397935: Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") https://bugzilla.mozilla.org/show_bug.cgi?id=397935 Attachment 312112: v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=312112&action=edit ...

superreview granted: [Bug 299839] If I use the option 'reset camino' it removes downloaded files out of my download location. : [Attachment 189206] Alternative patch, don't cancel finnished downloads
Mike Pinkerton <pinkerton@aol.net> has granted Mike Pinkerton <pinkerton@aol.net>'s request for superreview: Bug 299839: If I use the option 'reset camino' it removes downloaded files out of my download location. https://bugzilla.mozilla.org/show_bug.cgi?id=299839 Attachment 189206: Alternative patch, don't cancel finnished downloads https://bugzilla.mozilla.org/attachment.cgi?id=189206&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink. i prefer this as well. ...

superreview requested: [Bug 397935] Download Manager ("Downloads") window doesn' t stay open when clicking on download-complete alert notification with auto-close pref ("close when done") : [Attachmen #3
Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns.com> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 397935: Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") https://bugzilla.mozilla.org/show_bug.cgi?id=397935 Attachment 312112: v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=312112&action=edit ------- Additional Comments from Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns.com> Incorporates test update, revi...

superreview granted: [Bug 397935] Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") : [Attachment 3 #2
Benjamin Smedberg [:bs] (bsmedberg) <benjamin@smedbergs.us> has granted Shawn Wilsher (sdwilsh) <sdwilsh@forerunnerdesigns.com>'s request for superreview: Bug 397935: Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done") https://bugzilla.mozilla.org/show_bug.cgi?id=397935 Attachment 312093: xpcom test v.10 https://bugzilla.mozilla.org/attachment.cgi?id=312093&action=edit ...

superreview requested: [Bug 343762] Zoom All zooms downloads window (even when it's not visible) : [Attachment 228390] Don't Zoom Downloads Solution
froodiantherapy <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 343762: Zoom All zooms downloads window (even when it's not visible) https://bugzilla.mozilla.org/show_bug.cgi?id=343762 Attachment 228390: Don't Zoom Downloads Solution https://bugzilla.mozilla.org/attachment.cgi?id=228390&action=edit ...

superreview requested: [Bug 293350] Don't show download status in status bar (since it shows in the DL manager) : [Attachment 194557] v1 patch
Darin Fisher <darin@meer.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 293350: Don't show download status in status bar (since it shows in the DL manager) https://bugzilla.mozilla.org/show_bug.cgi?id=293350 Attachment 194557: v1 patch https://bugzilla.mozilla.org/attachment.cgi?id=194557&action=edit ------- Additional Comments from Darin Fisher <darin@meer.net> Fixes most channels. I left out changes to nsMsgProtocol and nsLDAPChannel because 1) they don't apply to this bug and 2) it isn't obvious how to fix them or if it ...

superreview requested: [Bug 264897] Inconsistent behavior when clicking the Download Manager toolbar button with the Download Manager already open : [Attachment 196373] implement 'toggle' behavior fo
Vladimir Vukicevic (:vlad) <vladimir@pobox.com> has asked Mike Connor <mconnor@mozilla.com> for superreview: Bug 264897: Inconsistent behavior when clicking the Download Manager toolbar button with the Download Manager already open https://bugzilla.mozilla.org/show_bug.cgi?id=264897 Attachment 196373: implement 'toggle' behavior for Downloads Button https://bugzilla.mozilla.org/attachment.cgi?id=196373&action=edit ------- Additional Comments from Vladimir Vukicevic (:vlad) <vladimir@pobox.com> r=me on the functional part of the patch; however; the UI ...

superreview requested: [Bug 239006] Download manager doesn't account for filesize when presenting combined percentages : [Attachment 167869] add patch for ./camino/src/download
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 239006: Download manager doesn't account for filesize when presenting combined percentages https://bugzilla.mozilla.org/show_bug.cgi?id=239006 Attachment 167869: add patch for ./camino/src/download https://bugzilla.mozilla.org/attachment.cgi?id=167869&action=edit ------- Additional Comments from Christian Biesinger (:bi) <cbiesinger@gmx.at> r=biesi if darin sr's, and if you get the ok from a toolkit peer. ...

superreview requested: [Bug 259649] header only downloaded pop3 messages don't download correctly if filters sent header to different folder : [Attachment 159016] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 259649: header only downloaded pop3 messages don't download correctly if filters sent header to different folder http://bugzilla.mozilla.org/show_bug.cgi?id=259649 Attachment 159016: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=159016&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> It's gonna take Howard a while to try this, so I think I should get it checked in... ...

superreview requested: [Bug 291230] HTTP downloads don't progress beyond (filesize % 4GB) : [Attachment 181648] Allow downloads > 4GB for persistent non-chunked HTTP connections
Mark Mentovai <mark@moxienet.com> has asked Darin Fisher <darin@meer.net> for superreview: Bug 291230: HTTP downloads don't progress beyond (filesize % 4GB) https://bugzilla.mozilla.org/show_bug.cgi?id=291230 Attachment 181648: Allow downloads > 4GB for persistent non-chunked HTTP connections https://bugzilla.mozilla.org/attachment.cgi?id=181648&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> This turned out to be a problem only for persistent non-chunked HTTP connections. Of course, that's what most HTTP connections...

superreview requested: [Bug 291230] HTTP downloads don't progress beyond (filesize % 4GB) : [Attachment 181667] v2/Allow downloads > 4GB for persistent non-chunked HTTP connections
Mark Mentovai <mark@moxienet.com> has asked Darin Fisher <darin@meer.net> for superreview: Bug 291230: HTTP downloads don't progress beyond (filesize % 4GB) https://bugzilla.mozilla.org/show_bug.cgi?id=291230 Attachment 181667: v2/Allow downloads > 4GB for persistent non-chunked HTTP connections https://bugzilla.mozilla.org/attachment.cgi?id=181667&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> Updated to use temporary variable. ...

Web resources about - superreview requested: [Bug 412360] Download Manager remains empty, downloads don't start, with this 3.0b2 downloads.sqlite : [Attachment 306041] v1 - mozilla.dev.super-review

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 1/11/2016 3:26:01 PM