superreview granted: [Bug 395033]=?UTF-8?Q?=20Use=20Gecko=2Dbased=20thum?= =?UTF-8?Q?bnailing=20for=20Tabspos?==?UTF-8?Q?=C3=A9?=
Mike Pinkerton <mikepinkerton@mac.com> has granted Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 395033: Use Gecko-based thumbnailing for Tabspos=C3=A9 https://bugzilla.mozilla.org/show_bug.cgi?id=3D395033 Attachment 279747: trunk fix https://bugzilla.mozilla.org/attachment.cgi?id=3D279747&action=3Dedit ------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com> sr=3Dpink= ...

superreview requested: [Bug 377248] [SoC] Camino : =?UTF-8?Q?=20Tabos=C3=A9=20?=(=?UTF-8?Q?or=20Tabspos=C3=A9=20or=20Tabpo?= =?UTF-8?Q?s=C3=A9?=)
Jeff Dlouhy <Jeff.Dlouhy@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 377248: [SoC] Camino : Tabos=C3=A9 (or Tabspos=C3=A9 or Tabpos=C3=A9) https://bugzilla.mozilla.org/show_bug.cgi?id=3D377248 Attachment 273847: Initial Patch (revised v7) https://bugzilla.mozilla.org/attachment.cgi?id=3D273847&action=3Dedit ------- Additional Comments from Jeff Dlouhy <Jeff.Dlouhy@gmail.com> Made final changes, removed spaces from whitespace, and fixed the 'selectTabViewItem' hack with smorgan's hack.= ...

superreview requested: [Bug 377248] [SoC] Camino : =?UTF-8?Q?=20Tabos=C3=A9=20?=(=?UTF-8?Q?or=20Tabspos=C3=A9=20or=20Tabpo?= =?UTF-8?Q?s=C3=A9?=) #2
Jeff Dlouhy <Jeff.Dlouhy@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 377248: [SoC] Camino : Tabos=C3=A9 (or Tabspos=C3=A9 or Tabpos=C3=A9) https://bugzilla.mozilla.org/show_bug.cgi?id=3D377248 Attachment 274688: Initial Patch (revised v8) https://bugzilla.mozilla.org/attachment.cgi?id=3D274688&action=3Dedit= ...

superreview requested: [Bug 390909] =?UTF-8?Q?=20Tabspos=C3=A9=20allows=20cli?= =?UTF-8?Q?cking=20in=20bookmark=20bar?= =?UTF-8?Q?=20without=20reflecting=20a?==?UTF-8?Q?ction?=
Jeff Dlouhy <Jeff.Dlouhy@gmail.com> has asked Stuart Morgan <stuart.morgan@alumni.case.edu> for superreview: Bug 390909: Tabspos=C3=A9 allows clicking in bookmark bar without reflectin= g action https://bugzilla.mozilla.org/show_bug.cgi?id=3D390909 Attachment 282503: Disable Actions Patch v4 https://bugzilla.mozilla.org/attachment.cgi?id=3D282503&action=3Dedit ------- Additional Comments from Jeff Dlouhy <Jeff.Dlouhy@gmail.com> Fixes nits and comments stated above= ...

superreview granted: [Bug 377248] [SoC] Camino : =?UTF-8?Q?=20Tabos=C3=A9=20?=(=?UTF-8?Q?or=20Tabspos=C3=A9=20or=20Tabpo?= =?UTF-8?Q?s=C3=A9?=)
Stuart Morgan <stuart.morgan@alumni.case.edu> has granted superreview: Bug 377248: [SoC] Camino : Tabos=C3=A9 (or Tabspos=C3=A9 or Tabpos=C3=A9) https://bugzilla.mozilla.org/show_bug.cgi?id=3D377248 Attachment 274702: Initial Patch (revised v9) https://bugzilla.mozilla.org/attachment.cgi?id=3D274702&action=3Dedit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.e= du> (Adding pink's sr+ flag)= ...

superreview canceled: [Bug 377248] [SoC] Camino : =?UTF-8?Q?=20Tabos=C3=A9=20?=(=?UTF-8?Q?or=20Tabspos=C3=A9=20or=20Tabpo?= =?UTF-8?Q?s=C3=A9?=)
Jeff Dlouhy <Jeff.Dlouhy@gmail.com> has canceled Jeff Dlouhy <Jeff.Dlouhy@gmail.com>'s request for superreview: Bug 377248: [SoC] Camino : Tabos=C3=A9 (or Tabspos=C3=A9 or Tabpos=C3=A9) https://bugzilla.mozilla.org/show_bug.cgi?id=3D377248 Attachment 273847: Initial Patch (revised v7) https://bugzilla.mozilla.org/attachment.cgi?id=3D273847&action=3Dedit ------- Additional Comments from Jeff Dlouhy <Jeff.Dlouhy@gmail.com> Fixed problems in comment #23 and comment #24.=0D =0D Also switched from using setFrame: to resizeSubviewsWithOldSize: as per IRC conve...

superreview canceled: [Bug 377248] [SoC] Camino : =?UTF-8?Q?=20Tabos=C3=A9=20?=(=?UTF-8?Q?or=20Tabspos=C3=A9=20or=20Tabpo?= =?UTF-8?Q?s=C3=A9?=) #2
Jeff Dlouhy <Jeff.Dlouhy@gmail.com> has canceled Jeff Dlouhy <Jeff.Dlouhy@gmail.com>'s request for superreview: Bug 377248: [SoC] Camino : Tabos=C3=A9 (or Tabspos=C3=A9 or Tabpos=C3=A9) https://bugzilla.mozilla.org/show_bug.cgi?id=3D377248 Attachment 274688: Initial Patch (revised v8) https://bugzilla.mozilla.org/attachment.cgi?id=3D274688&action=3Dedit ------- Additional Comments from Jeff Dlouhy <Jeff.Dlouhy@gmail.com> Removed setBounds: initWithFrame: and changed dates from 2002 to 2007.= ...

superreview granted: [Bug 390909] =?UTF-8?Q?=20Tabspos=C3=A9=20allows=20cli?= =?UTF-8?Q?cking=20in=20bookmark=20bar?= =?UTF-8?Q?=20without=20reflecting=20a?==?UTF-8?Q?ction?=
Stuart Morgan <stuart.morgan@alumni.case.edu> has granted Jeff Dlouhy <Jeff.Dlouhy@gmail.com>'s request for superreview: Bug 390909: Tabspos=C3=A9 allows clicking in bookmark bar without reflectin= g action https://bugzilla.mozilla.org/show_bug.cgi?id=3D390909 Attachment 282503: Disable Actions Patch v4 https://bugzilla.mozilla.org/attachment.cgi?id=3D282503&action=3Dedit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.e= du> >+ [[NSApp delegate] delayedAdjustBookmarksMenuItemsEnabling];=0D =0D BVC doesn't (and shouldn&...

superreview requested: [Bug 388356] nsXULPopupManager.h:124: warning: =?UTF-8?Q?=20=E2=80=98DirectionFromKeyC?= =?UTF-8?Q?ode=5Flr=5Ftb=E2=80=99=20defined=20?==?UTF-8?Q?but=20not=20used?=
Blake Kaplan <mrbkap@gmail.com> has asked Johnny Stenback <jst@mozilla.org>= for superreview: Bug 388356: nsXULPopupManager.h:124: warning: =E2=80=98DirectionFromKeyCode= _lr_tb=E2=80=99 defined but not used https://bugzilla.mozilla.org/show_bug.cgi?id=3D388356 Attachment 272552: Fix warnings https://bugzilla.mozilla.org/attachment.cgi?id=3D272552&action=3Dedit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> The problem is that there are two arrays that are declared as being 'static= ' in a header file. This is generally incorrect...

superreview requested: [Bug 390575] =?UTF-8?Q?=20Make=20Tabspos=C3=A9=20handl?==?UTF-8?Q?e=20mouse=20clicks?=
Jeff Dlouhy <Jeff.Dlouhy@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 390575: Make Tabspos=C3=A9 handle mouse clicks https://bugzilla.mozilla.org/show_bug.cgi?id=3D390575 Attachment 275263: Click Handling Patch v4 https://bugzilla.mozilla.org/attachment.cgi?id=3D275263&action=3Dedit ------- Additional Comments from Jeff Dlouhy <Jeff.Dlouhy@gmail.com> Fixed and agreed with all of murph's concerns. I switched the click to mouseUp:, this was something I was wondering about doing before since I wou= ld like to add dragging...

superreview requested: [Bug 382685] =?UTF-8?Q?=20Allow=20selection=20of=20f?= =?UTF-8?Q?iles=20with=20type=20TEXT=20i?= =?UTF-8?Q?n=20Open=20File=E2=80=A6=20dialog?=
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has ask= ed Stuart Morgan <stuart.morgan@alumni.case.edu> for superreview: Bug 382685: Allow selection of files with type TEXT in Open File=E2=80=A6 d= ialog https://bugzilla.mozilla.org/show_bug.cgi?id=3D382685 Attachment 266806: patch https://bugzilla.mozilla.org/attachment.cgi?id=3D266806&action=3Dedit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> Marking cl's r+ from comment 1 and targeting smorgan for sr.= ...

=?utf-8?q?=23webmakerbrww_Orienta=C3=A7=C3=B5es_para_localiza?= =?utf-8?q?=C3=A7=C3=A3o_e_revis=C3=A3o_do_Webmaker_e_projetos_relacionado?= =?utf-8?q?s?=
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Olá, Hoje rolou uma reunião dos revisores do Webmaker e projetos relacionados como parte do Webmaker Brasil Work Weekend, na qual eu e Marcus Saad participamos, e instruções para localização e revisão do Webmaker foram definidas. Um ponto importante discutido e acordado entre os revisores anteriormente: se você é um revisor, você conhece e concorda com essas instruções. Então, para os revisores atuais, leiam, opinem, comentem, .... Para aqueles que querem virar revisor...

superreview granted: [Bug 388356] nsXULPopupManager.h:124: warning: =?UTF-8?Q?=20=E2=80=98DirectionFromKeyC?= =?UTF-8?Q?ode=5Flr=5Ftb=E2=80=99=20defined=20?==?UTF-8?Q?but=20not=20used?=
Johnny Stenback <jst@mozilla.org> has granted Blake Kaplan <mrbkap@gmail.co= m>'s request for superreview: Bug 388356: nsXULPopupManager.h:124: warning: =E2=80=98DirectionFromKeyCode= _lr_tb=E2=80=99 defined but not used https://bugzilla.mozilla.org/show_bug.cgi?id=3D388356 Attachment 272552: Fix warnings https://bugzilla.mozilla.org/attachment.cgi?id=3D272552&action=3Dedit= ...

superreview canceled: [Bug 390575] =?UTF-8?Q?=20Make=20Tabspos=C3=A9=20handl?==?UTF-8?Q?e=20mouse=20clicks?=
H=C3=A5kan Waara <hwaara@gmail.com> has canceled Jeff Dlouhy <Jeff.Dlouhy@gmail.com>'s request for superreview: Bug 390575: Make Tabspos=C3=A9 handle mouse clicks https://bugzilla.mozilla.org/show_bug.cgi?id=3D390575 Attachment 275263: Click Handling Patch v4 https://bugzilla.mozilla.org/attachment.cgi?id=3D275263&action=3Dedit ------- Additional Comments from H=C3=A5kan Waara <hwaara@gmail.com> I've been looking at the Tabspose changes, and playing around with it on tr= unk and it's great!=0D =0D > - (void)removeSubviews=0D =0D I know ther...