superreview requested: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build #3
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has asked Mark Mentovai <mark@moxienet.com> for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=392918 Attachment 285687: trunk patch, v2 https://bugzilla.mozilla.org/attachment.cgi?id=285687&action=edit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> OK, here's the trunk patch that (I think) implements all of mento's suggestions as he wanted. Some notes: 1) Since we're doing the whole shadow hierarchy, I moved all-camino in there where it belongs and gave all three of our existing (notfox) rules the mkdir -p $(dir $@) treatment for consistency. 2) I couldn't get RegionNames.strings's tabs to look right consistently across editors, so I just made them all spaces like all the other .strings files. Slightly harder to read, but prettier overall, I think.
|
0 |
|
bugzilla
10/21/2007 11:22:56 PM
mozilla.dev.super-review
29307 articles. 
3 followers.
0 Replies
538 Views
Similar Artilces:
superreview requested: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has ask= ed Mark Mentovai <mark@moxienet.com> for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and i= conv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=3D392918 Attachment 284885: trunk patch https://bugzilla.mozilla.org/attachment.cgi?id=3D284885&action=3Dedit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> Who said Sunday afternoons had to be boring? Our .strings files w...
superreview requested: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build #2
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has asked Mark Mentovai <mark@moxienet.com> for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=392918 Attachment 284886: branch patch (project and makefile only) https://bugzilla.mozilla.org/attachment.cgi?id=284886&action=edit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> Pretty much the same story here, except I've ...
superreview requested: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build #4
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has asked Mark Mentovai <mark@moxienet.com> for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=392918 Attachment 285688: branch patch, v2 (project and makefile only) https://bugzilla.mozilla.org/attachment.cgi?id=285688&action=edit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> Pretty much the same story here, except I'...
superreview canceled: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build
Mark Mentovai <mark@moxienet.com> has canceled Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org>'s request for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=392918 Attachment 284886: branch patch (project and makefile only) https://bugzilla.mozilla.org/attachment.cgi?id=284886&action=edit ...
superreview granted: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build
Mark Mentovai <mark@moxienet.com> has granted Smokey Ardisson (no bugmail -= do not email) <alqahira@ardisson.org>'s request for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and i= conv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=3D392918 Attachment 285687: trunk patch, v2 https://bugzilla.mozilla.org/attachment.cgi?id=3D285687&action=3Dedit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> Smokey, this looks really good. There are some minor notes that you can ta= ke ...
superreview denied: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build
Mark Mentovai <mark@moxienet.com> has denied Smokey Ardisson (no bugmail - = do not email) <alqahira@ardisson.org>'s request for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and i= conv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=3D392918 Attachment 284885: trunk patch https://bugzilla.mozilla.org/attachment.cgi?id=3D284885&action=3Dedit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> In the Makefile:=0D =0D When you find yourself writing the same thing over and over ...
superreview granted: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build #2
Mark Mentovai <mark@moxienet.com> has granted Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org>'s request for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=392918 Attachment 285688: branch patch, v2 (project and makefile only) https://bugzilla.mozilla.org/attachment.cgi?id=285688&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> All of the same comments apply to this patch as to the trunk pat...
superreview requested: [Bug 383465] Compiling with --with-native-uconv reveals invalid utf-8 files, mailnews unusable : [Attachment 267581] Makes four files utf-8 encoded
Magnus Melin <mkmelin+mozilla@iki.fi> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 383465: Compiling with --with-native-uconv reveals invalid utf-8 files, mailnews unusable https://bugzilla.mozilla.org/show_bug.cgi?id=383465 Attachment 267581: Makes four files utf-8 encoded https://bugzilla.mozilla.org/attachment.cgi?id=267581&action=edit ------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi> No (and it still needs sr). Neil was this good for sr too? ...
superreview requested: [Bug 390909] =?UTF-8?Q?=20Tabspos=C3=A9=20allows=20cli?= =?UTF-8?Q?cking=20in=20bookmark=20bar?= =?UTF-8?Q?=20without=20reflecting=20a?==?UTF-8?Q?ction?=
Jeff Dlouhy <Jeff.Dlouhy@gmail.com> has asked Stuart Morgan <stuart.morgan@alumni.case.edu> for superreview: Bug 390909: Tabspos=C3=A9 allows clicking in bookmark bar without reflectin= g action https://bugzilla.mozilla.org/show_bug.cgi?id=3D390909 Attachment 282503: Disable Actions Patch v4 https://bugzilla.mozilla.org/attachment.cgi?id=3D282503&action=3Dedit ------- Additional Comments from Jeff Dlouhy <Jeff.Dlouhy@gmail.com> Fixes nits and comments stated above= ...
superreview requested: [Bug 261249] activex should treat utf-8 strings as utf-8 : [Attachment 159875] patch
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 261249: activex should treat utf-8 strings as utf-8 https://bugzilla.mozilla.org/show_bug.cgi?id=261249 Attachment 159875: patch https://bugzilla.mozilla.org/attachment.cgi?id=159875&action=edit ...
superreview requested: [Bug 395033] =?UTF-8?Q?=20Use=20Gecko=2Dbased=20thum?= =?UTF-8?Q?bnailing=20for=20Tabspos?==?UTF-8?Q?=C3=A9?=
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 395033: Use Gecko-based thumbnailing for Tabspos=C3=A9 https://bugzilla.mozilla.org/show_bug.cgi?id=3D395033 Attachment 279747: trunk fix https://bugzilla.mozilla.org/attachment.cgi?id=3D279747&action=3Dedit= ...
superreview requested: [Bug 377248] [SoC] Camino : =?UTF-8?Q?=20Tabos=C3=A9=20?=(=?UTF-8?Q?or=20Tabspos=C3=A9=20or=20Tabpo?= =?UTF-8?Q?s=C3=A9?=)
Jeff Dlouhy <Jeff.Dlouhy@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 377248: [SoC] Camino : Tabos=C3=A9 (or Tabspos=C3=A9 or Tabpos=C3=A9) https://bugzilla.mozilla.org/show_bug.cgi?id=3D377248 Attachment 273847: Initial Patch (revised v7) https://bugzilla.mozilla.org/attachment.cgi?id=3D273847&action=3Dedit ------- Additional Comments from Jeff Dlouhy <Jeff.Dlouhy@gmail.com> Made final changes, removed spaces from whitespace, and fixed the 'selectTabViewItem' hack with smorgan's hack.= ...
superreview requested: [Bug 377248] [SoC] Camino : =?UTF-8?Q?=20Tabos=C3=A9=20?=(=?UTF-8?Q?or=20Tabspos=C3=A9=20or=20Tabpo?= =?UTF-8?Q?s=C3=A9?=) #2
Jeff Dlouhy <Jeff.Dlouhy@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 377248: [SoC] Camino : Tabos=C3=A9 (or Tabspos=C3=A9 or Tabpos=C3=A9) https://bugzilla.mozilla.org/show_bug.cgi?id=3D377248 Attachment 274688: Initial Patch (revised v8) https://bugzilla.mozilla.org/attachment.cgi?id=3D274688&action=3Dedit= ...
superreview requested: [Bug 382685] =?UTF-8?Q?=20Allow=20selection=20of=20f?= =?UTF-8?Q?iles=20with=20type=20TEXT=20i?= =?UTF-8?Q?n=20Open=20File=E2=80=A6=20dialog?=
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has ask= ed Stuart Morgan <stuart.morgan@alumni.case.edu> for superreview: Bug 382685: Allow selection of files with type TEXT in Open File=E2=80=A6 d= ialog https://bugzilla.mozilla.org/show_bug.cgi?id=3D382685 Attachment 266806: patch https://bugzilla.mozilla.org/attachment.cgi?id=3D266806&action=3Dedit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> Marking cl's r+ from comment 1 and targeting smorgan for sr.= ...
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has ask= ed Mark Mentovai <mark@moxienet.com> for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and i= conv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=3D392918 Attachment 284885: trunk patch https://bugzilla.mozilla.org/attachment.cgi?id=3D284885&action=3Dedit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> Who said Sunday afternoons had to be boring? Our .strings files w...
superreview requested: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build #2
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has asked Mark Mentovai <mark@moxienet.com> for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=392918 Attachment 284886: branch patch (project and makefile only) https://bugzilla.mozilla.org/attachment.cgi?id=284886&action=edit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> Pretty much the same story here, except I've ...
superreview requested: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build #4
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has asked Mark Mentovai <mark@moxienet.com> for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=392918 Attachment 285688: branch patch, v2 (project and makefile only) https://bugzilla.mozilla.org/attachment.cgi?id=285688&action=edit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> Pretty much the same story here, except I'...
superreview canceled: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build
Mark Mentovai <mark@moxienet.com> has canceled Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org>'s request for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=392918 Attachment 284886: branch patch (project and makefile only) https://bugzilla.mozilla.org/attachment.cgi?id=284886&action=edit ...
superreview granted: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build
Mark Mentovai <mark@moxienet.com> has granted Smokey Ardisson (no bugmail -= do not email) <alqahira@ardisson.org>'s request for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and i= conv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=3D392918 Attachment 285687: trunk patch, v2 https://bugzilla.mozilla.org/attachment.cgi?id=3D285687&action=3Dedit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> Smokey, this looks really good. There are some minor notes that you can ta= ke ...
superreview denied: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build
Mark Mentovai <mark@moxienet.com> has denied Smokey Ardisson (no bugmail - = do not email) <alqahira@ardisson.org>'s request for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and i= conv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=3D392918 Attachment 284885: trunk patch https://bugzilla.mozilla.org/attachment.cgi?id=3D284885&action=3Dedit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> In the Makefile:=0D =0D When you find yourself writing the same thing over and over ...
superreview granted: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build #2
Mark Mentovai <mark@moxienet.com> has granted Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org>'s request for superreview: Bug 392918: Convert all .strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build https://bugzilla.mozilla.org/show_bug.cgi?id=392918 Attachment 285688: branch patch, v2 (project and makefile only) https://bugzilla.mozilla.org/attachment.cgi?id=285688&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> All of the same comments apply to this patch as to the trunk pat...
superreview requested: [Bug 383465] Compiling with --with-native-uconv reveals invalid utf-8 files, mailnews unusable : [Attachment 267581] Makes four files utf-8 encoded
Magnus Melin <mkmelin+mozilla@iki.fi> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 383465: Compiling with --with-native-uconv reveals invalid utf-8 files, mailnews unusable https://bugzilla.mozilla.org/show_bug.cgi?id=383465 Attachment 267581: Makes four files utf-8 encoded https://bugzilla.mozilla.org/attachment.cgi?id=267581&action=edit ------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi> No (and it still needs sr). Neil was this good for sr too? ...
superreview requested: [Bug 390909] =?UTF-8?Q?=20Tabspos=C3=A9=20allows=20cli?= =?UTF-8?Q?cking=20in=20bookmark=20bar?= =?UTF-8?Q?=20without=20reflecting=20a?==?UTF-8?Q?ction?=
Jeff Dlouhy <Jeff.Dlouhy@gmail.com> has asked Stuart Morgan <stuart.morgan@alumni.case.edu> for superreview: Bug 390909: Tabspos=C3=A9 allows clicking in bookmark bar without reflectin= g action https://bugzilla.mozilla.org/show_bug.cgi?id=3D390909 Attachment 282503: Disable Actions Patch v4 https://bugzilla.mozilla.org/attachment.cgi?id=3D282503&action=3Dedit ------- Additional Comments from Jeff Dlouhy <Jeff.Dlouhy@gmail.com> Fixes nits and comments stated above= ...
superreview requested: [Bug 261249] activex should treat utf-8 strings as utf-8 : [Attachment 159875] patch
Christian Biesinger (:bi) <cbiesinger@gmx.at> has asked Darin Fisher (IBM) <darin@meer.net> for superreview: Bug 261249: activex should treat utf-8 strings as utf-8 https://bugzilla.mozilla.org/show_bug.cgi?id=261249 Attachment 159875: patch https://bugzilla.mozilla.org/attachment.cgi?id=159875&action=edit ...
superreview requested: [Bug 395033] =?UTF-8?Q?=20Use=20Gecko=2Dbased=20thum?= =?UTF-8?Q?bnailing=20for=20Tabspos?==?UTF-8?Q?=C3=A9?=
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 395033: Use Gecko-based thumbnailing for Tabspos=C3=A9 https://bugzilla.mozilla.org/show_bug.cgi?id=3D395033 Attachment 279747: trunk fix https://bugzilla.mozilla.org/attachment.cgi?id=3D279747&action=3Dedit= ...
superreview requested: [Bug 377248] [SoC] Camino : =?UTF-8?Q?=20Tabos=C3=A9=20?=(=?UTF-8?Q?or=20Tabspos=C3=A9=20or=20Tabpo?= =?UTF-8?Q?s=C3=A9?=)
Jeff Dlouhy <Jeff.Dlouhy@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 377248: [SoC] Camino : Tabos=C3=A9 (or Tabspos=C3=A9 or Tabpos=C3=A9) https://bugzilla.mozilla.org/show_bug.cgi?id=3D377248 Attachment 273847: Initial Patch (revised v7) https://bugzilla.mozilla.org/attachment.cgi?id=3D273847&action=3Dedit ------- Additional Comments from Jeff Dlouhy <Jeff.Dlouhy@gmail.com> Made final changes, removed spaces from whitespace, and fixed the 'selectTabViewItem' hack with smorgan's hack.= ...
superreview requested: [Bug 377248] [SoC] Camino : =?UTF-8?Q?=20Tabos=C3=A9=20?=(=?UTF-8?Q?or=20Tabspos=C3=A9=20or=20Tabpo?= =?UTF-8?Q?s=C3=A9?=) #2
Jeff Dlouhy <Jeff.Dlouhy@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 377248: [SoC] Camino : Tabos=C3=A9 (or Tabspos=C3=A9 or Tabpos=C3=A9) https://bugzilla.mozilla.org/show_bug.cgi?id=3D377248 Attachment 274688: Initial Patch (revised v8) https://bugzilla.mozilla.org/attachment.cgi?id=3D274688&action=3Dedit= ...
superreview requested: [Bug 382685] =?UTF-8?Q?=20Allow=20selection=20of=20f?= =?UTF-8?Q?iles=20with=20type=20TEXT=20i?= =?UTF-8?Q?n=20Open=20File=E2=80=A6=20dialog?=
Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> has ask= ed Stuart Morgan <stuart.morgan@alumni.case.edu> for superreview: Bug 382685: Allow selection of files with type TEXT in Open File=E2=80=A6 d= ialog https://bugzilla.mozilla.org/show_bug.cgi?id=3D382685 Attachment 266806: patch https://bugzilla.mozilla.org/attachment.cgi?id=3D266806&action=3Dedit ------- Additional Comments from Smokey Ardisson (no bugmail - do not email) <alqahira@ardisson.org> Marking cl's r+ from comment 1 and targeting smorgan for sr.= ...
Web resources about - superreview requested: [Bug 392918] Convert all . strings files to UTF-8 for diff-friendliness and iconv them to UTF-16 during build #3 - mozilla.dev.super-reviewResources last updated: 11/28/2015 8:40:47 AM