superreview requested: [Bug 378991] Enable IDN link support in messages for Thunderbird and don't pass only punycode values to external apps : [Attachment 319969] Enable IDN and change handlers to pas
Mark Banner <bugzilla@standard8.plus.com> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 378991: Enable IDN link support in messages for Thunderbird and don't pass only punycode values to external apps https://bugzilla.mozilla.org/show_bug.cgi?id=378991 Attachment 319969: Enable IDN and change handlers to pass punycode and provide mochitest https://bugzilla.mozilla.org/attachment.cgi?id=319969&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> This patch fixes all the instances that I could find in uriloader/exthandler where we are loading URIs for external applications - they should now all be in punycode. Also provides a mochitest for testing this. I have had problems with the mac mochitest - I think it doesn't work mainly because its not an application bundle, I'm not sure how to set that up either (and I may be wrong). Given where we are, I'd just like to get this into the tree and if anyone can help fix the mac case then we can do that after. Note that the WriteApplication purposely doesn't use any xpcom items due to the way it is being called (the shared libraries wouldn't load). Hence the reason for the pre-processing. I've tested the patch on Mac and Linux and it works as expected (FF & SM & TB - TB w/o mochitest), unable to test on Windows as I don't have a build environment (and the try servers don't do mochitests :-( ).
|
0 |
|
bugzilla
5/8/2008 12:17:28 PM
mozilla.dev.super-review
29307 articles. 
3 followers.
0 Replies
1348 Views
Similar Artilces:
superreview granted: [Bug 378991] Enable IDN link support in messages for Thunderbird and don't pass only punycode values to external apps : [Attachment 319969] Enable IDN and change handlers to pass
Christian :Biesinger <cbiesinger@gmail.com> has granted Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 378991: Enable IDN link support in messages for Thunderbird and don't p= ass only punycode values to external apps https://bugzilla.mozilla.org/show_bug.cgi?id=3D378991 Attachment 319969: Enable IDN and change handlers to pass punycode and prov= ide mochitest https://bugzilla.mozilla.org/attachment.cgi?id=3D319969&action=3Dedit ------- Additional Comments from Christian :Biesinger <cbiesinger@gmail.com> +++ uriloader/extha...
superreview requested: [Bug 378991] IDN link support in messages : [Attachment 318153] Enable IDN and change mac to send punycode
Mark Banner <bugzilla@standard8.plus.com> has asked Benjamin Smedberg [:bs] (bsmedberg) <benjamin@smedbergs.us> for superreview: Bug 378991: IDN link support in messages https://bugzilla.mozilla.org/show_bug.cgi?id=378991 Attachment 318153: Enable IDN and change mac to send punycode https://bugzilla.mozilla.org/attachment.cgi?id=318153&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> Dan, please confirm we're happy with the Thunderbird prefs change. Benjamin, please could you sr these changes for the uriloader? ...
superreview requested: [Bug 378991] IDN link support in messages : [Attachment 318153] Enable IDN and change mac to send punycode #2
Benjamin Smedberg [:bs] (bsmedberg) <benjamin@smedbergs.us> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 378991: IDN link support in messages https://bugzilla.mozilla.org/show_bug.cgi?id=378991 Attachment 318153: Enable IDN and change mac to send punycode https://bugzilla.mozilla.org/attachment.cgi?id=318153&action=edit ...
superreview granted: [Bug 378991] IDN link support in messages : [Attachment 318153] Enable IDN and change mac to send punycode
Christian :Biesinger <cbiesinger@gmail.com> has granted Benjamin Smedberg [:bs] (bsmedberg) <benjamin@smedbergs.us>'s request for superreview: Bug 378991: IDN link support in messages https://bugzilla.mozilla.org/show_bug.cgi?id=378991 Attachment 318153: Enable IDN and change mac to send punycode https://bugzilla.mozilla.org/attachment.cgi?id=318153&action=edit ------- Additional Comments from Christian :Biesinger <cbiesinger@gmail.com> can you please use more context next time? it looks like there are also a few more places that should be updated for t...
superreview requested: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 179246] Like so
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozilla.org> for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 179246: Like so https://bugzilla.mozilla.org/attachment.cgi?id=179246&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This would be simpler if we could depend on the bit on mData, but since we can't... ...
superreview requested: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 180304] Same as diff -w
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozillafoundation.org> for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 180304: Same as diff -w https://bugzilla.mozilla.org/attachment.cgi?id=180304&action=edit ...
superreview requested: [Bug 248606] "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame : [Attachment 151705] patch
David Baron <dbaron@dbaron.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 248606: "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame http://bugzilla.mozilla.org/show_bug.cgi?id=248606 Attachment 151705: patch http://bugzilla.mozilla.org/attachment.cgi?id=151705&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> This patch separates the two coordinate transformations (so they're more like they used to be before bug 20022), and restores the baseV...
superreview requested: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ...
superreview requested: [Bug 338880] SuiteRunner doesn't compile with --enable-debug : [Attachment 222933] don't build appleevents twice
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 338880: SuiteRunner doesn't compile with --enable-debug https://bugzilla.mozilla.org/show_bug.cgi?id=338880 Attachment 222933: don't build appleevents twice https://bugzilla.mozilla.org/attachment.cgi?id=222933&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> (In reply to comment #6) > > We still need to make sure that non-debug builds still work > > They do, just tested it (--disable-d...
superreview requested: [Bug 338880] SuiteRunner doesn't compile with --enable-debug : [Attachment 223226] don't build appleevents twice and tidy up some ifdefs
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 338880: SuiteRunner doesn't compile with --enable-debug https://bugzilla.mozilla.org/show_bug.cgi?id=338880 Attachment 223226: don't build appleevents twice and tidy up some ifdefs https://bugzilla.mozilla.org/attachment.cgi?id=223226&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Revised patch using checks on just MOZ_XUL_APP, I've also included a few other tidy ups now that we know more about ...
superreview requested: [Bug 338880] SuiteRunner doesn't compile with --enable-debug : [Attachment 223488] don't build appleevents and lots of tidy up v2
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 338880: SuiteRunner doesn't compile with --enable-debug https://bugzilla.mozilla.org/show_bug.cgi?id=338880 Attachment 223488: don't build appleevents and lots of tidy up v2 https://bugzilla.mozilla.org/attachment.cgi?id=223488&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Fixed a couple of bugs I'd introduced and corrected #if defined() to #ifdef in the couple of places I'd moved stuff but...
superreview requested: [Bug 331614] window.open unnecessarily escapes all URLs (can't handle IDN/extended domain-names) : [Attachment 217983] don't escape
Gavin Sharp <gavin.sharp@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 331614: window.open unnecessarily escapes all URLs (can't handle IDN/extended domain-names) https://bugzilla.mozilla.org/show_bug.cgi?id=331614 Attachment 217983: don't escape https://bugzilla.mozilla.org/attachment.cgi?id=217983&action=edit ...
superreview requested: [Bug 340443] Not possible to use the XPCOM glue when linking against static CRT, crash on startup with tests enabled : [Attachment 237820] Don't use stderr, rev. 3.1
Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 340443: Not possible to use the XPCOM glue when linking against static CRT, crash on startup with tests enabled https://bugzilla.mozilla.org/show_bug.cgi?id=340443 Attachment 237820: Don't use stderr, rev. 3.1 https://bugzilla.mozilla.org/attachment.cgi?id=237820&action=edit ...
superreview denied: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 179246] Like so
David Baron <dbaron@mozilla.org> has denied Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 179246: Like so https://bugzilla.mozilla.org/attachment.cgi?id=179246&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.org> >@@ -752,17 +758,18 @@ CSSParserImpl::ParseAndAppendDeclaration >+ if (!ParseDeclaration(errorCode, aDeclaration, PR_FALSE, >+ PR_FAL...
Christian :Biesinger <cbiesinger@gmail.com> has granted Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 378991: Enable IDN link support in messages for Thunderbird and don't p= ass only punycode values to external apps https://bugzilla.mozilla.org/show_bug.cgi?id=3D378991 Attachment 319969: Enable IDN and change handlers to pass punycode and prov= ide mochitest https://bugzilla.mozilla.org/attachment.cgi?id=3D319969&action=3Dedit ------- Additional Comments from Christian :Biesinger <cbiesinger@gmail.com> +++ uriloader/extha...
superreview requested: [Bug 378991] IDN link support in messages : [Attachment 318153] Enable IDN and change mac to send punycode
Mark Banner <bugzilla@standard8.plus.com> has asked Benjamin Smedberg [:bs] (bsmedberg) <benjamin@smedbergs.us> for superreview: Bug 378991: IDN link support in messages https://bugzilla.mozilla.org/show_bug.cgi?id=378991 Attachment 318153: Enable IDN and change mac to send punycode https://bugzilla.mozilla.org/attachment.cgi?id=318153&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> Dan, please confirm we're happy with the Thunderbird prefs change. Benjamin, please could you sr these changes for the uriloader? ...
superreview requested: [Bug 378991] IDN link support in messages : [Attachment 318153] Enable IDN and change mac to send punycode #2
Benjamin Smedberg [:bs] (bsmedberg) <benjamin@smedbergs.us> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 378991: IDN link support in messages https://bugzilla.mozilla.org/show_bug.cgi?id=378991 Attachment 318153: Enable IDN and change mac to send punycode https://bugzilla.mozilla.org/attachment.cgi?id=318153&action=edit ...
superreview granted: [Bug 378991] IDN link support in messages : [Attachment 318153] Enable IDN and change mac to send punycode
Christian :Biesinger <cbiesinger@gmail.com> has granted Benjamin Smedberg [:bs] (bsmedberg) <benjamin@smedbergs.us>'s request for superreview: Bug 378991: IDN link support in messages https://bugzilla.mozilla.org/show_bug.cgi?id=378991 Attachment 318153: Enable IDN and change mac to send punycode https://bugzilla.mozilla.org/attachment.cgi?id=318153&action=edit ------- Additional Comments from Christian :Biesinger <cbiesinger@gmail.com> can you please use more context next time? it looks like there are also a few more places that should be updated for t...
superreview requested: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 179246] Like so
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozilla.org> for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 179246: Like so https://bugzilla.mozilla.org/attachment.cgi?id=179246&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This would be simpler if we could depend on the bit on mData, but since we can't... ...
superreview requested: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 180304] Same as diff -w
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozillafoundation.org> for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 180304: Same as diff -w https://bugzilla.mozilla.org/attachment.cgi?id=180304&action=edit ...
superreview requested: [Bug 248606] "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame : [Attachment 151705] patch
David Baron <dbaron@dbaron.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 248606: "arrow" doesn't change to hand over links, links don't get bold font-weight inside frame http://bugzilla.mozilla.org/show_bug.cgi?id=248606 Attachment 151705: patch http://bugzilla.mozilla.org/attachment.cgi?id=151705&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> This patch separates the two coordinate transformations (so they're more like they used to be before bug 20022), and restores the baseV...
superreview requested: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ...
superreview requested: [Bug 338880] SuiteRunner doesn't compile with --enable-debug : [Attachment 222933] don't build appleevents twice
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 338880: SuiteRunner doesn't compile with --enable-debug https://bugzilla.mozilla.org/show_bug.cgi?id=338880 Attachment 222933: don't build appleevents twice https://bugzilla.mozilla.org/attachment.cgi?id=222933&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> (In reply to comment #6) > > We still need to make sure that non-debug builds still work > > They do, just tested it (--disable-d...
superreview requested: [Bug 338880] SuiteRunner doesn't compile with --enable-debug : [Attachment 223226] don't build appleevents twice and tidy up some ifdefs
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 338880: SuiteRunner doesn't compile with --enable-debug https://bugzilla.mozilla.org/show_bug.cgi?id=338880 Attachment 223226: don't build appleevents twice and tidy up some ifdefs https://bugzilla.mozilla.org/attachment.cgi?id=223226&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Revised patch using checks on just MOZ_XUL_APP, I've also included a few other tidy ups now that we know more about ...
superreview requested: [Bug 338880] SuiteRunner doesn't compile with --enable-debug : [Attachment 223488] don't build appleevents and lots of tidy up v2
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 338880: SuiteRunner doesn't compile with --enable-debug https://bugzilla.mozilla.org/show_bug.cgi?id=338880 Attachment 223488: don't build appleevents and lots of tidy up v2 https://bugzilla.mozilla.org/attachment.cgi?id=223488&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Fixed a couple of bugs I'd introduced and corrected #if defined() to #ifdef in the couple of places I'd moved stuff but...
superreview requested: [Bug 331614] window.open unnecessarily escapes all URLs (can't handle IDN/extended domain-names) : [Attachment 217983] don't escape
Gavin Sharp <gavin.sharp@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 331614: window.open unnecessarily escapes all URLs (can't handle IDN/extended domain-names) https://bugzilla.mozilla.org/show_bug.cgi?id=331614 Attachment 217983: don't escape https://bugzilla.mozilla.org/attachment.cgi?id=217983&action=edit ...
superreview requested: [Bug 340443] Not possible to use the XPCOM glue when linking against static CRT, crash on startup with tests enabled : [Attachment 237820] Don't use stderr, rev. 3.1
Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 340443: Not possible to use the XPCOM glue when linking against static CRT, crash on startup with tests enabled https://bugzilla.mozilla.org/show_bug.cgi?id=340443 Attachment 237820: Don't use stderr, rev. 3.1 https://bugzilla.mozilla.org/attachment.cgi?id=237820&action=edit ...
superreview denied: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 179246] Like so
David Baron <dbaron@mozilla.org> has denied Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 179246: Like so https://bugzilla.mozilla.org/attachment.cgi?id=179246&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.org> >@@ -752,17 +758,18 @@ CSSParserImpl::ParseAndAppendDeclaration >+ if (!ParseDeclaration(errorCode, aDeclaration, PR_FALSE, >+ PR_FAL...
Web resources about - superreview requested: [Bug 378991] Enable IDN link support in messages for Thunderbird and don't pass only punycode values to external apps : [Attachment 319969] Enable IDN and change handlers to pas - mozilla.dev.super-review Biz & Finance Magazines
Australian magazine subscriptions price comparison.
Australian magazine subscriptions price comparison.
Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...
Resources last updated: 1/5/2016 1:13:49 AM