superreview granted: [Bug 363654] .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch : [Attachment 248458] disables .url in file:openStuart Morgan <stuart.morgan@alumni.case.edu> has granted Smokey Ardisson
(unreliable; no bugmail) <alqahira@ardisson.org>'s request for superreview:
Bug 363654: .url files opened via File:Open don't open/don't open properly on
the 1.8.0 branch
https://bugzilla.mozilla.org/show_bug.cgi?id=363654
Attachment 248458: disables .url in file:open
https://bugzilla.mozilla.org/attachment.cgi?id=248458&action=edit
------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu>
Well, that kinda sucks.
...
superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143792] patch v4Christian Biesinger <cbiesinger@gmx.at> has asked Brian Ryner (IBM)
<bryner@brianryner.com> for superreview:
Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File |
Open or file protocol)
http://bugzilla.mozilla.org/show_bug.cgi?id=69114
Attachment 143792: patch v4
http://bugzilla.mozilla.org/attachment.cgi?id=143792&action=edit
------- Additional Comments from Christian Biesinger <cbiesinger@gmx.at>
I'll change nsIFileProtocolHandler's uuid before checking in
...
superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143792] patch v4 #2Christian Biesinger <cbiesinger@gmx.at> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File |
Open or file protocol)
http://bugzilla.mozilla.org/show_bug.cgi?id=69114
Attachment 143792: patch v4
http://bugzilla.mozilla.org/attachment.cgi?id=143792&action=edit
...
superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143888] patch for callers, v2Christian Biesinger <cbiesinger@gmx.at> has asked Brian Ryner (IBM)
<bryner@brianryner.com> for superreview:
Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File |
Open or file protocol)
http://bugzilla.mozilla.org/show_bug.cgi?id=69114
Attachment 143888: patch for callers, v2
http://bugzilla.mozilla.org/attachment.cgi?id=143888&action=edit
------- Additional Comments from Christian Biesinger <cbiesinger@gmx.at>
I'll make those changes
...
superreview requested: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143888] patch for callers, v2 #2Christian Biesinger <cbiesinger@gmx.at> has asked Boris Zbarsky
<bzbarsky@mit.edu> for superreview:
Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File |
Open or file protocol)
http://bugzilla.mozilla.org/show_bug.cgi?id=69114
Attachment 143888: patch for callers, v2
http://bugzilla.mozilla.org/attachment.cgi?id=143888&action=edit
...
superreview granted: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143792] patch v4Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger
<cbiesinger@gmx.at>'s request for superreview:
Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File |
Open or file protocol)
http://bugzilla.mozilla.org/show_bug.cgi?id=69114
Attachment 143792: patch v4
http://bugzilla.mozilla.org/attachment.cgi?id=143792&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
sr=bzbarsky, but I didn't verify general correctness of the win32 mumbo-jumbo
(I don't know enough about win32 to do that).
...
superreview granted: [Bug 69114] Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file protocol) : [Attachment 143888] patch for callers, v2Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger
<cbiesinger@gmx.at>'s request for superreview:
Bug 69114: Opening Internet Shortcuts (.url files) doesn't work (using File |
Open or file protocol)
http://bugzilla.mozilla.org/show_bug.cgi?id=69114
Attachment 143888: patch for callers, v2
http://bugzilla.mozilla.org/attachment.cgi?id=143888&action=edit
------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu>
>Index: xpfe/components/bookmarks/src/nsBookmarksService.cpp
The changes to this are fine. File a bug on firefox t...
superreview requested: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 161419] don't divert window.open to a new tab if the named wiDan M <danm.moz@gmail.com> has asked Johnny Stenback
<jst@mozilla.jstenback.com> for superreview:
Bug 172962: Options for where to open URLs from other applications (reuse tab,
new tab, new window)
https://bugzilla.mozilla.org/show_bug.cgi?id=172962
Attachment 161419: don't divert window.open to a new tab if the named window
exists
https://bugzilla.mozilla.org/attachment.cgi?id=161419&action=edit
...
superreview requested: [Bug 364380] Don't open new windows/ tabs for apple events if the url is already openfroodian (unreliable 12/20 - 1/21) <stridey@gmail.com> has asked Mike Pinkerton
<mikepinkerton@mac.com> for superreview:
Bug 364380: Don't open new windows/tabs for apple events if the url is already
open
https://bugzilla.mozilla.org/show_bug.cgi?id=364380
Attachment 249935: v2
https://bugzilla.mozilla.org/attachment.cgi?id=249935&action=edit
...
superreview requested: [Bug 331614] window.open unnecessarily escapes all URLs (can't handle IDN/extended domain-names) : [Attachment 217983] don't escapeGavin Sharp <gavin.sharp@gmail.com> has asked Darin Fisher (Google)
<darin@meer.net> for superreview:
Bug 331614: window.open unnecessarily escapes all URLs (can't handle
IDN/extended domain-names)
https://bugzilla.mozilla.org/show_bug.cgi?id=331614
Attachment 217983: don't escape
https://bugzilla.mozilla.org/attachment.cgi?id=217983&action=edit
...
superreview requested: [Bug 355894] Open file dialog doesn't allow me to open XUL documents : [Attachment 241861] Fix v2Josh Aas <joshmoz@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com>
for superreview:
Bug 355894: Open file dialog doesn't allow me to open XUL documents
https://bugzilla.mozilla.org/show_bug.cgi?id=355894
Attachment 241861: Fix v2
https://bugzilla.mozilla.org/attachment.cgi?id=241861&action=edit
...
superreview requested: [Bug 267590] don't try to open separators as tabs when doing open folder in tabs : [Attachment 164503] fix v1.0Josh Aas <joshmoz@gmail.com> has asked Mike Pinkerton <pinkerton@aol.net> for
superreview:
Bug 267590: don't try to open separators as tabs when doing open folder in tabs
https://bugzilla.mozilla.org/show_bug.cgi?id=267590
Attachment 164503: fix v1.0
https://bugzilla.mozilla.org/attachment.cgi?id=164503&action=edit
...
superreview requested: [Bug 355894] Open file dialog doesn't allow me to open XUL documents : [Attachment 241861] Fix v2 #2Mike Pinkerton <mikepinkerton@mac.com> has asked for superreview:
Bug 355894: Open file dialog doesn't allow me to open XUL documents
https://bugzilla.mozilla.org/show_bug.cgi?id=355894
Attachment 241861: Fix v2
https://bugzilla.mozilla.org/attachment.cgi?id=241861&action=edit
------- Additional Comments from Mike Pinkerton <mikepinkerton@mac.com>
sr=pink
...
superreview requested: [Bug 232933] javascript window.open('file or bookmark', '_self') does nothing.. : [Attachment 140810] popup blocker once again tolerates window.open targeted to _self, _top et.Dan M <danm-moz@comcast.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for
superreview:
Bug 232933: javascript window.open('file or bookmark', '_self') does nothing..
http://bugzilla.mozilla.org/show_bug.cgi?id=232933
Attachment 140810: popup blocker once again tolerates window.open targeted to
_self, _top et.al.
http://bugzilla.mozilla.org/attachment.cgi?id=140810&action=edit
...