superreview requested: [Bug 355657] window.open()ed links fail in a new tab, same window : [Attachment 241578] untested patch

Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked
neil@parkwaycc.co.uk <neil@httl.net> for superreview:
Bug 355657: window.open()ed links fail in a new tab, same window
https://bugzilla.mozilla.org/show_bug.cgi?id=355657

Attachment 241578: untested patch
https://bugzilla.mozilla.org/attachment.cgi?id=241578&action=edit

------- Additional Comments from Chris Thomas (CTho) [formerly
cst@andrew.cmu.edu] <cst@yecc.com>
Can't test this.  tabbrowser.xml changes don't get picked up in my build.
0
bugzilla
10/7/2006 8:12:58 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
680 Views

Similar Articles

[PageSpeed] 36
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview cancelled: [Bug 355657] window.open()ed links fail in a new tab, same window : [Attachment 241578] untested patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has cancelled Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 355657: window.open()ed links fail in a new tab, same window https://bugzilla.mozilla.org/show_bug.cgi?id=355657 Attachment 241578: untested patch https://bugzilla.mozilla.org/attachment.cgi?id=241578&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> Neil seemed to think this might be a better way to do it. This works, and ...

superreview requested: [Bug 355657] window.open()ed links fail in a new tab, same window : [Attachment 241641] tested patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 355657: window.open()ed links fail in a new tab, same window https://bugzilla.mozilla.org/show_bug.cgi?id=355657 Attachment 241641: tested patch https://bugzilla.mozilla.org/attachment.cgi?id=241641&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> Neil seemed to think this might be a better way to do it. This works, and does reasonable things even after undoing the cl...

superreview requested: [Bug 355657] window.open()ed links fail in a new tab, same window : [Attachment 242120] address review comments
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 355657: window.open()ed links fail in a new tab, same window https://bugzilla.mozilla.org/show_bug.cgi?id=355657 Attachment 242120: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=242120&action=edit ...

superreview denied: [Bug 355657] window.open()ed links fail in a new tab, same window : [Attachment 241641] tested patch
neil@parkwaycc.co.uk <neil@httl.net> has denied Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 355657: window.open()ed links fail in a new tab, same window https://bugzilla.mozilla.org/show_bug.cgi?id=355657 Attachment 241641: tested patch https://bugzilla.mozilla.org/attachment.cgi?id=241641&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> As per IRC comments. ...

superreview granted: [Bug 355657] window.open()ed links fail in a new tab, same window : [Attachment 242120] address review comments
neil@parkwaycc.co.uk <neil@httl.net> has granted Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 355657: window.open()ed links fail in a new tab, same window https://bugzilla.mozilla.org/show_bug.cgi?id=355657 Attachment 242120: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=242120&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> I'd prefer if the lines didn't move. ...

superreview requested: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177879] Patch to make externally-launched links open in new window (Seamonkey only)
Jeremy Morton <bugzilla@game-point.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177879: Patch to make externally-launched links open in new window (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177879&action=edit ...

superreview requested: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177878] Patch to make externally-launched links open in new tab (Seamonkey only)
Jeremy Morton <bugzilla@game-point.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177878: Patch to make externally-launched links open in new tab (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177878&action=edit ...

superreview granted: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177879] Patch to make externally-launched links open in new window (Seamonkey only)
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Jeremy Morton <bugzilla@game-point.net>'s request for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177879: Patch to make externally-launched links open in new window (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177879&action=edit ...

superreview requested: [Bug 275430] change "open links from other applications" to be "a new tab in the most recent window" instead of "the most recent tab/window" : [Attachment 177848] Patch to make
Jeremy Morton <bugzilla@game-point.net> has asked Ben Goodger <bugs@bengoodger.com> for superreview: Bug 275430: change "open links from other applications" to be "a new tab in the most recent window" instead of "the most recent tab/window" https://bugzilla.mozilla.org/show_bug.cgi?id=275430 Attachment 177848: Patch to make externally-launched links open in new window https://bugzilla.mozilla.org/attachment.cgi?id=177848&action=edit ...

superreview requested: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 159443] optional addition to divert window.open to a new tab
Dan M <danm.moz@gmail.com> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 159443: optional addition to divert window.open to a new tab https://bugzilla.mozilla.org/attachment.cgi?id=159443&action=edit ...

superreview requested: [Bug 172962] Options for where to open URLs from other applications (reuse tab, new tab, new window) : [Attachment 161419] don't divert window.open to a new tab if the named wi
Dan M <danm.moz@gmail.com> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 172962: Options for where to open URLs from other applications (reuse tab, new tab, new window) https://bugzilla.mozilla.org/show_bug.cgi?id=172962 Attachment 161419: don't divert window.open to a new tab if the named window exists https://bugzilla.mozilla.org/attachment.cgi?id=161419&action=edit ...

superreview requested: [Bug 310395] Open Link in New Window
froodiantherapy (mostly gone until June 4) <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 310395: Open Link in New Window - new background windows open with Address bar focused https://bugzilla.mozilla.org/show_bug.cgi?id=310395 Attachment 223629: Last Patch before sr? https://bugzilla.mozilla.org/attachment.cgi?id=223629&action=edit ------- Additional Comments from froodiantherapy (mostly gone until June 4) <stridey@gmail.com> Assuming that this has cl+ too. ;) ...

superreview cancelled: [Bug 286745] Open externally-launched links in a new tab or window : [Attachment 177878] Patch to make externally-launched links open in new tab (Seamonkey only)
Jeremy Morton <bugzilla@game-point.net> has cancelled Jeremy Morton <bugzilla@game-point.net>'s request for superreview: Bug 286745: Open externally-launched links in a new tab or window https://bugzilla.mozilla.org/show_bug.cgi?id=286745 Attachment 177878: Patch to make externally-launched links open in new tab (Seamonkey only) https://bugzilla.mozilla.org/attachment.cgi?id=177878&action=edit ...

superreview requested: [Bug 279495] A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] : [Attachment 172585] Patch
Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 279495: A link with an URL and additional javascript open shows a popup and an unwanted new window [link with TARGET and onClick=window.open] https://bugzilla.mozilla.org/show_bug.cgi?id=279495 Attachment 172585: Patch https://bugzilla.mozilla.org/attachment.cgi?id=172585&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This basically backs out the "fix" for bug 135811. Now I can't figure out how finding targe...

Web resources about - superreview requested: [Bug 355657] window.open()ed links fail in a new tab, same window : [Attachment 241578] untested patch - mozilla.dev.super-review

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 11/26/2015 8:45:02 AM