superreview requested: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch

Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked
neil@parkwaycc.co.uk <neil@httl.net> for superreview:
Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab
bar when only one tab is open"] pref is ignored)
https://bugzilla.mozilla.org/show_bug.cgi?id=351289

Attachment 236765: patch
https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit

------- Additional Comments from Chris Thomas (CTho) [formerly
cst@andrew.cmu.edu] <cst@yecc.com>
If you show the tab bar:
 Ctrl+F4 => close tab

If you hide the tab bar:
 Ctrl+F4 => ignored
0
bugzilla
9/5/2006 2:43:37 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
1321 Views

Similar Articles

[PageSpeed] 35
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview denied: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch
neil@parkwaycc.co.uk <neil@httl.net> has denied Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=351289 Attachment 236765: patch https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> 1. You shouldn't early return, you should reverse your conditi...

superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank l
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 233414: blank last tab https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> Same as the Firefox imple...

superreview granted: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank las
neil@parkwaycc.co.uk <neil@httl.net> has granted Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 156082: Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 233414: blank last tab https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> This will cause me dataloss, because I...

superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked
Asaf Romano <bugs.mano@mail-central.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit ------- Additional Comments from Asaf Romano <bugs.mano@mail-central.com> requesting r/sr for your patch. ...

superreview denied: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked
jag (Peter Annema) <jag@tty.nl> has denied Asaf Romano <bugs.mano@mail-central.com>'s request for superreview: Bug 156082: Don't hide the tab bar when clicking the close box https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> Erh, you shouldn't have to check the autohide pref, if that is set to true, with onl...

superreview requested: [Bug 143866] Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows : [Attachment 167118] Patch v0.1a
Ian Neal <bugzilla@arlen.demon.co.uk> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 143866: Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows https://bugzilla.mozilla.org/show_bug.cgi?id=143866 Attachment 167118: Patch v0.1a - tidier patch to show tabstrip only when more than one tab is open with toolbar=no https://bugzilla.mozilla.org/attachment.cgi?id=167118&action=edit ...

superreview cancelled: [Bug 143866] Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows : [Attachment 167118] Patch v0.1a
Ian Neal <bugzilla@arlen.demon.co.uk> has cancelled Ian Neal <bugzilla@arlen.demon.co.uk>'s request for superreview: Bug 143866: Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows https://bugzilla.mozilla.org/show_bug.cgi?id=143866 Attachment 167118: Patch v0.1a - tidier patch to show tabstrip only when more than one tab is open with toolbar=no https://bugzilla.mozilla.org/attachment.cgi?id=167118&action=edit ...

superreview requested: [Bug 143866] Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows : [Attachment 149199] Path
met - martin hassman <hassman@czilla.cz> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 143866: Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows http://bugzilla.mozilla.org/show_bug.cgi?id=143866 Attachment 149199: Path - don't hide tabbrowser with toolbar=no http://bugzilla.mozilla.org/attachment.cgi?id=149199&action=edit ------- Additional Comments from met - martin hassman <hassman@czilla.cz> Some tip for the sr ? ...

superreview requested: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 237073] A Patch Not On Crack
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items https://bugzilla.mozilla.org/show_bug.cgi?id=290212 Attachment 237073: A Patch Not On Crack https://bugzilla.mozilla.org/attachment.cgi?id=237073&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> r=me. Style stuff: >+ NSMenuItem* menuItem = [[NSMenuItem alloc] initWithTitle:NSL...

superreview requested: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 241797] r=smorgan patch
froodian (unreliable 10/7-10/12) <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items https://bugzilla.mozilla.org/show_bug.cgi?id=290212 Attachment 241797: r=smorgan patch https://bugzilla.mozilla.org/attachment.cgi?id=241797&action=edit ...

superreview cancelled: [Bug 143866] Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows : [Attachment 149199] Path
Ian Neal <bugzilla@arlen.demon.co.uk> has cancelled Met - Martin Hassman <hassman@czilla.cz>'s request for superreview: Bug 143866: Ctrl+T opens new tabs in tab-bar-less (popup, no toolbar) windows https://bugzilla.mozilla.org/show_bug.cgi?id=143866 Attachment 149199: Path - don't hide tabbrowser with toolbar=no https://bugzilla.mozilla.org/attachment.cgi?id=149199&action=edit ------- Additional Comments from Ian Neal <bugzilla@arlen.demon.co.uk> Cancelling old sr request ...

superreview requested: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224087] updated patch, thanks gavin
Seth Spitzer <sspitzer@mozilla.com> has asked for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224087: updated patch, thanks gavin https://bugzilla.mozilla.org/attachment.cgi?id=224087&action=edit ...

superreview requested: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224127] revised patch, with two additional changes per gavin
Seth Spitzer <sspitzer@mozilla.com> has asked for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224127: revised patch, with two additional changes per gavin https://bugzilla.mozilla.org/attachment.cgi?id=224127&action=edit ...

superreview requested: [Bug 327873] Return-to-parent tab doesn't work for tabs opened by target="_blank" links : [Attachment 223184] patch v2
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 327873: Return-to-parent tab doesn't work for tabs opened by target="_blank" links https://bugzilla.mozilla.org/show_bug.cgi?id=327873 Attachment 223184: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=223184&action=edit ...

Web resources about - superreview requested: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch - mozilla.dev.super-review

Resources last updated: 1/19/2016 5:04:35 PM