superreview requested: [Bug 345510] Add <textbox type="number"> : [Attachment 230578] Address review comments

Neil Deakin <enndeakin@sympatico.ca> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 345510: Add <textbox type="number">
https://bugzilla.mozilla.org/show_bug.cgi?id=345510

Attachment 230578: Address review comments
https://bugzilla.mozilla.org/attachment.cgi?id=230578&action=edit

------- Additional Comments from Neil Deakin <enndeakin@sympatico.ca>
>+	<property name="min">
> minvalue feels better to me.

I used min and max to be consistent with <scale>. Do you think I should change
scale to minvalue/minValue?
0
bugzilla
7/25/2006 3:03:32 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
519 Views

Similar Articles

[PageSpeed] 44
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview cancelled: [Bug 345510] Add <textbox type="number"> : [Attachment 230578] Address review comments
Neil Deakin <enndeakin@sympatico.ca> has cancelled Neil Deakin <enndeakin@sympatico.ca>'s request for superreview: Bug 345510: Add <textbox type="number"> https://bugzilla.mozilla.org/show_bug.cgi?id=345510 Attachment 230578: Address review comments https://bugzilla.mozilla.org/attachment.cgi?id=230578&action=edit ------- Additional Comments from Neil Deakin <enndeakin@sympatico.ca> Hopefully, I've addressed all the review comments ...

superreview requested: [Bug 345510] Add <textbox type="number"> : [Attachment 230935] address review comments
Neil Deakin <enndeakin@sympatico.ca> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 345510: Add <textbox type="number"> https://bugzilla.mozilla.org/show_bug.cgi?id=345510 Attachment 230935: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=230935&action=edit ------- Additional Comments from Neil Deakin <enndeakin@sympatico.ca> Hopefully, I've addressed all the review comments ...

superreview granted: [Bug 345510] Add <textbox type="number"> : [Attachment 230935] address review comments
neil@parkwaycc.co.uk <neil@httl.net> has granted Neil Deakin <enndeakin@sympatico.ca>'s request for superreview: Bug 345510: Add <textbox type="number"> https://bugzilla.mozilla.org/show_bug.cgi?id=345510 Attachment 230935: address review comments https://bugzilla.mozilla.org/attachment.cgi?id=230935&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >Index: themes/classic/global/win/numberbox.css >+.numberbox-input-box { >+ -moz-box-align: center; >+} The weirdness that is <html:input size=...

superreview requested: [Bug 345510] Add <textbox type="number"> : [Attachment 230170] Add numberbox
Neil Deakin <enndeakin@sympatico.ca> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 345510: Add <textbox type="number"> https://bugzilla.mozilla.org/show_bug.cgi?id=345510 Attachment 230170: Add numberbox https://bugzilla.mozilla.org/attachment.cgi?id=230170&action=edit ...

superreview denied: [Bug 345510] Add <textbox type="number"> : [Attachment 230170] Add numberbox
neil@parkwaycc.co.uk <neil@httl.net> has denied Neil Deakin <enndeakin@sympatico.ca>'s request for superreview: Bug 345510: Add <textbox type="number"> https://bugzilla.mozilla.org/show_bug.cgi?id=345510 Attachment 230170: Add numberbox https://bugzilla.mozilla.org/attachment.cgi?id=230170&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >Index: themes/classic/global/mac/numberbox.css I don't have a Mac; maybe you could get Mano or someone to review this bit? >Index: themes/classic/global/unix/n...

superreview granted: [Bug 407818] Leak nsGenericDOMDataNode with <ol>, <li> , execCommand("selectall") : [Attachment 292509] patch addressing dbaron' s review comments
Jesse Ruderman <jruderman@gmail.com> has granted superreview: Bug 407818: Leak nsGenericDOMDataNode with <ol>, <li>, execCommand("selectall") https://bugzilla.mozilla.org/show_bug.cgi?id=407818 Attachment 292509: patch addressing dbaron's review comments https://bugzilla.mozilla.org/attachment.cgi?id=292509&action=edit ...

superreview requested: [Bug 399545] <textbox type="number"> spin buttons look wrong with some GTK themes : [Attachment 293943] add GTK theming for spinner and spinner-textfield
Teune van Steeg <twanno@lycos.nl> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 399545: <textbox type="number"> spin buttons look wrong with some GTK themes https://bugzilla.mozilla.org/show_bug.cgi?id=399545 Attachment 293943: add GTK theming for spinner and spinner-textfield https://bugzilla.mozilla.org/attachment.cgi?id=293943&action=edit ------- Additional Comments from Teune van Steeg <twanno@lycos.nl> This is the same patch as Sylvain posted, updated to use NS_THEME_SPINNER_TEXTFIELD to allow the entry p...

superreview requested: [Bug 452415] Switch from <textbox type="timed"> to type="search" : [Attachment 335715] Patch for mailnews/base/
neil@parkwaycc.co.uk <neil@httl.net> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 452415: Switch from <textbox type="timed"> to type="search" https://bugzilla.mozilla.org/show_bug.cgi?id=452415 Attachment 335715: Patch for mailnews/base/ https://bugzilla.mozilla.org/attachment.cgi?id=335715&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> ....since subscribe.xul is still shared, right? ...

superreview requested: [Bug 452415] Switch from <textbox type="timed"> to type="search" : [Attachment 335716] Patch for mailnews/addrbook/
neil@parkwaycc.co.uk <neil@httl.net> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 452415: Switch from <textbox type="timed"> to type="search" https://bugzilla.mozilla.org/show_bug.cgi?id=452415 Attachment 335716: Patch for mailnews/addrbook/ https://bugzilla.mozilla.org/attachment.cgi?id=335716&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> The real patch this time... ...

superreview requested: [Bug 452415] Switch from <textbox type="timed"> to type="search" : [Attachment 335715] Patch for mailnews/base/ #2
Phil Ringnalda (:philor) <philringnalda@gmail.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 452415: Switch from <textbox type="timed"> to type="search" https://bugzilla.mozilla.org/show_bug.cgi?id=452415 Attachment 335715: Patch for mailnews/base/ https://bugzilla.mozilla.org/attachment.cgi?id=335715&action=edit ------- Additional Comments from Phil Ringnalda (:philor) <philringnalda@gmail.com> Nope, not shared - I already changed our fork, though I didn't have quite enough nerve to drop the 300ms tim...

superreview requested: [Bug 432132] Use <textbox type="number"> in Composer where applicable : [Attachment 320953] Fix textboxes in editor/ui
Stefan <stefanh@inbox.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 432132: Use <textbox type="number"> in Composer where applicable https://bugzilla.mozilla.org/show_bug.cgi?id=432132 Attachment 320953: Fix textboxes in editor/ui https://bugzilla.mozilla.org/attachment.cgi?id=320953&action=edit ------- Additional Comments from Stefan <stefanh@inbox.com> Interestingly, if you type "99999999999999999999" in a number textbox the value gets rounded to "100000000000000000000"... This patch: -Should...

superreview requested: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 180129] Cleaned up patch, moving review requests
Torben <torben@despammed.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 90918: RFE: Add url in "comments" field of the "get info" window when download file. https://bugzilla.mozilla.org/show_bug.cgi?id=90918 Attachment 180129: Cleaned up patch, moving review requests https://bugzilla.mozilla.org/attachment.cgi?id=180129&action=edit ...

superreview requested: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 137491] (Cv2) <Wallet*.*> (+ <*pref*>)
Serge GAUTHERIE <gautheri@noos.fr> has asked Ben Goodger (I don't read bugmail) <bugs@bengoodger.com> for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 137491: (Cv2) <Wallet*.*> (+ <*pref*>) http://bugzilla.mozilla.org/attachment.cgi?id=137491&action=edit ...

superreview requested: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 137678] (Cv2b) <Wallet*.*>
Serge GAUTHERIE <gautheri@noos.fr> has asked Ben Goodger (I don't read bugmail) <bugs@bengoodger.com> for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 137678: (Cv2b) <Wallet*.*> http://bugzilla.mozilla.org/attachment.cgi?id=137678&action=edit ...

Web resources about - superreview requested: [Bug 345510] Add <textbox type="number"> : [Attachment 230578] Address review comments - mozilla.dev.super-review

Resources last updated: 12/13/2015 9:38:24 AM