superreview requested: [Bug 343599] "WARNING: NS_ENSURE_TRUE(mSuspendCount > 0) failed" with <img src="javascript:5"> : [Attachment 228282] patch that doesn't work

Christian Biesinger (:bi) (CA) <cbiesinger@gmx.at> has asked Darin Fisher
(Google) <darin@meer.net> for superreview:
Bug 343599: "WARNING: NS_ENSURE_TRUE(mSuspendCount > 0) failed" with <img
src="javascript:5">
https://bugzilla.mozilla.org/show_bug.cgi?id=343599

Attachment 228282: patch that doesn't work
https://bugzilla.mozilla.org/attachment.cgi?id=228282&action=edit

------- Additional Comments from Christian Biesinger (:bi) (CA)
<cbiesinger@gmx.at>
while this doesn't fix the bug, it's probably still a good thing to have.
0
bugzilla
7/21/2006 1:05:26 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
641 Views

Similar Articles

[PageSpeed] 42

Reply:

Similar Artilces:

superreview granted: [Bug 343599] "WARNING: NS_ENSURE_TRUE(mSuspendCount > 0) failed" with <img src="javascript:5"> : [Attachment 228282] patch part I
Darin Fisher (Google) <darin@meer.net> has granted Christian Biesinger (:bi) (CA) <cbiesinger@gmx.at>'s request for superreview: Bug 343599: "WARNING: NS_ENSURE_TRUE(mSuspendCount > 0) failed" with <img src="javascript:5"> https://bugzilla.mozilla.org/show_bug.cgi?id=343599 Attachment 228282: patch part I https://bugzilla.mozilla.org/attachment.cgi?id=228282&action=edit ...

superreview requested: [Bug 343599] "WARNING: NS_ENSURE_TRUE(mSuspendCount > 0) failed" with <img src="javascript:5"> : [Attachment 230058] patch part II
Christian Biesinger (:bi) (CA) <cbiesinger@gmx.at> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 343599: "WARNING: NS_ENSURE_TRUE(mSuspendCount > 0) failed" with <img src="javascript:5"> https://bugzilla.mozilla.org/show_bug.cgi?id=343599 Attachment 230058: patch part II https://bugzilla.mozilla.org/attachment.cgi?id=230058&action=edit ------- Additional Comments from Christian Biesinger (:bi) (CA) <cbiesinger@gmx.at> this does fix the bug by not forcefully unsuspending the pump when Cancel is called. See the co...

superreview granted: [Bug 343599] "WARNING: NS_ENSURE_TRUE(mSuspendCount > 0) failed" with <img src="javascript:5"> : [Attachment 230058] patch part II
Boris Zbarsky <bzbarsky@mit.edu> has granted Christian Biesinger (:bi) (CA) <cbiesinger@gmx.at>'s request for superreview: Bug 343599: "WARNING: NS_ENSURE_TRUE(mSuspendCount > 0) failed" with <img src="javascript:5"> https://bugzilla.mozilla.org/show_bug.cgi?id=343599 Attachment 230058: patch part II https://bugzilla.mozilla.org/attachment.cgi?id=230058&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> OK, I buy this.... ...

superreview requested: [Bug 315633] "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" : [Attachment 206616] Use Mac-appropriate text in profile #3
Daniel Veditz <dveditz@cruzio.com> has asked Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> for superreview: Bug 315633: "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" https://bugzilla.mozilla.org/show_bug.cgi?id=315633 Attachment 206616: Use Mac-appropriate text in profile creation https://bugzilla.mozilla.org/attachment.cgi?id=206616&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> blame says bsmed...

superreview requested: [Bug 315633] "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" : [Attachment 206616] Use Mac-appropriate text in profile #2
Steuard Jensen <steuard+mozilla@slimy.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 315633: "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" https://bugzilla.mozilla.org/show_bug.cgi?id=315633 Attachment 206616: Use Mac-appropriate text in profile creation https://bugzilla.mozilla.org/attachment.cgi?id=206616&action=edit ...

superreview requested: [Bug 226958] Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> : [Attachment 136628] <xpistatus.*> patch v3
Serge GAUTHERIE <gautheri@noos.fr> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 226958: Bug 197315, "other" files: Convert <window class="dialog"> to <dialog> http://bugzilla.mozilla.org/show_bug.cgi?id=226958 Attachment 136628: <xpistatus.*> patch v3 http://bugzilla.mozilla.org/attachment.cgi?id=136628&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> 'approval1.6b=?': Trivial U.I. code cleanup. ...

superreview requested: [Bug 398157] "ASSERTION: didn' t subtract all that we added" with <select>, <div style="margin: 0 100%; ">
Daniel Holbert [:dholbert] <dholbert@mozilla.com> has asked for superreview: Bug 398157: "ASSERTION: didn't subtract all that we added" with <select>, <div style="margin: 0 100%;"> https://bugzilla.mozilla.org/show_bug.cgi?id=398157 Attachment 283036: fix https://bugzilla.mozilla.org/attachment.cgi?id=283036&action=edit ------- Additional Comments from Daniel Holbert [:dholbert] <dholbert@mozilla.com> Trivial fix. Issue arises when "width" is nscoord_MAX in ComputeColumnWidths. We'd been subtracting directly of...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 137549] (Lv1) </widget/src/mac/*> (cleanup only)
Serge GAUTHERIE <gautheri@noos.fr> has asked Christopher Blizzard <blizzard@mozilla.org> for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 137549: (Lv1) </widget/src/mac/*> (cleanup only) http://bugzilla.mozilla.org/attachment.cgi?id=137549&action=edit ...

superreview requested: [Bug 380538] <body ononline="..." onoffline="..."> doesn't work
Chris Double <chris.double@double.co.nz> has asked Jonas Sicking <jonas@sicking.cc> for superreview: Bug 380538: <body ononline="..." onoffline="..."> doesn't work https://bugzilla.mozilla.org/show_bug.cgi?id=380538 Attachment 264962: Patch to fix issue when defining both offline and online handles in the body element https://bugzilla.mozilla.org/attachment.cgi?id=264962&action=edit ------- Additional Comments from Chris Double <chris.double@double.co.nz> Fixes the problem where if both an ononline and onoffline attribute was used...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #3
Serge GAUTHERIE <gautheri@noos.fr> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #4
Serge GAUTHERIE <gautheri@noos.fr> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> No super-review from <bienvenu@nventure.com> since '2004-04-26' :-( ...

superreview requested: [Bug 398157] "ASSERTION: didn' t subtract all that we added" with <select>, <div style="margin: 0 100%; "> #2
Daniel Holbert [:dholbert] <dholbert@mozilla.com> has asked Robert O'Callahan (:roc) <roc@ocallahan.org> for superreview: Bug 398157: "ASSERTION: didn't subtract all that we added" with <select>, <div style="margin: 0 100%;"> https://bugzilla.mozilla.org/show_bug.cgi?id=398157 Attachment 283036: fix https://bugzilla.mozilla.org/attachment.cgi?id=283036&action=edit ...

Web resources about - superreview requested: [Bug 343599] "WARNING: NS_ENSURE_TRUE(mSuspendCount > 0) failed" with <img src="javascript:5"> : [Attachment 228282] patch that doesn't work - mozilla.dev.super-review

Resources last updated: 12/21/2015 10:15:59 AM