superreview requested: [Bug 343179] JS error by message tags, if using a Thunderbird locale in combination with a profile created with an other locale : [Attachment 227706] better fix

Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu
<bienvenu@nventure.com> for superreview:
Bug 343179: JS error by message tags, if using a Thunderbird locale in
combination with a profile created with an other locale
https://bugzilla.mozilla.org/show_bug.cgi?id=343179

Attachment 227706: better fix
https://bugzilla.mozilla.org/attachment.cgi?id=227706&action=edit
0
bugzilla
7/1/2006 2:15:52 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
672 Views

Similar Articles

[PageSpeed] 6
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview granted: [Bug 343179] JS error by message tags, if using a Thunderbird locale in combination with a profile created with an other locale : [Attachment 227706] better fix
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 343179: JS error by message tags, if using a Thunderbird locale in combination with a profile created with an other locale https://bugzilla.mozilla.org/show_bug.cgi?id=343179 Attachment 227706: better fix https://bugzilla.mozilla.org/attachment.cgi?id=227706&action=edit ...

superreview requested: [Bug 250828] When i use global inbox, thunderbird does not use localized string "Inbox". : [Attachment 160458] possible fix
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 250828: When i use global inbox, thunderbird does not use localized string "Inbox". https://bugzilla.mozilla.org/show_bug.cgi?id=250828 Attachment 160458: possible fix https://bugzilla.mozilla.org/attachment.cgi?id=160458&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> What do you think of this David? On startup, we weren't setting the MSG_FOLDER_FLAG_INBOX on the root local folder. As a result we nev...

superreview requested: [Bug 203570] [message/rfc822] opening a fwd local message has original messages's attachments : [Attachment 199818] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 203570: [message/rfc822] opening a fwd local message has original messages's attachments https://bugzilla.mozilla.org/show_bug.cgi?id=203570 Attachment 199818: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=199818&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> this fixes two problems with local msgs: 1. Opening a forwarded message with inline image attachments displayed broken images. 2. The forwa...

superreview requested: [Bug 342886] Crash when removing the last tag on a local message : [Attachment 227637] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 342886: Crash when removing the last tag on a local message https://bugzilla.mozilla.org/show_bug.cgi?id=342886 Attachment 227637: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=227637&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> I was able to reproduce this as follows: Add tag1 add tag2 remove tag2 this leaves us with "tag1 " then, add tag2 this leaves us with "tag1 tag2" (no...

superreview requested: [Bug 286108] Build Thunderbird Locales from CVS (--enable-ui-locale) : [Attachment 186335] Tbird: use standardized package names, rev. 1
Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 286108: Build Thunderbird Locales from CVS (--enable-ui-locale) https://bugzilla.mozilla.org/show_bug.cgi?id=286108 Attachment 186335: Tbird: use standardized package names, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=186335&action=edit ...

superreview requested: [Bug 362989] custom tags lost by moving message from IMAP to local folder : [Attachment 247985] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 362989: custom tags lost by moving message from IMAP to local folder https://bugzilla.mozilla.org/show_bug.cgi?id=362989 Attachment 247985: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=247985&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> darn, I've had this fix in my tree for a while - I can't find it in bugzilla, so I must have forgotten about it :-( ...

superreview requested: [Bug 439132] removing tags from local messages sometimes doesn't survive rebuild index : [Attachment 325031] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 439132: removing tags from local messages sometimes doesn't survive rebuild index https://bugzilla.mozilla.org/show_bug.cgi?id=439132 Attachment 325031: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=325031&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> ugh, this code is truly horrible, but until it can be rewritten, this should fix the problem I was seeing. Basically, as we're iterating over the...

superreview requested: [Bug 314297] deleting one attachment from a locally stored message deletes multiple attachments : [Attachment 244151] proposed fix
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 314297: deleting one attachment from a locally stored message deletes multiple attachments https://bugzilla.mozilla.org/show_bug.cgi?id=314297 Attachment 244151: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=244151&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> make sure the part is an exact match, or the text after the match is a '.', not a number, i.e., that it's really a sub-part ...

superreview requested: [Bug 343766] localize anti-phishing reporting urls : [Attachment 229173] v1: use {moz:locale} for locale
Tony Chang (Google) <tony@ponderer.org> has asked Brian Ryner <bryner@gmail.com> for superreview: Bug 343766: localize anti-phishing reporting urls https://bugzilla.mozilla.org/show_bug.cgi?id=343766 Attachment 229173: v1: use {moz:locale} for locale https://bugzilla.mozilla.org/attachment.cgi?id=229173&action=edit ...

superreview requested: [Bug 296113] Thunderbird seems to refuse to display e-mails in Local Folders if profile path contains # character : [Attachment 185177] a patch to fix escape flags
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 296113: Thunderbird seems to refuse to display e-mails in Local Folders if profile path contains # character https://bugzilla.mozilla.org/show_bug.cgi?id=296113 Attachment 185177: a patch to fix escape flags https://bugzilla.mozilla.org/attachment.cgi?id=185177&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> I've run with this a bit - I made sure that folders with '#' in the name still work... ...

superreview requested: [Bug 339415] In <builtinURLs.js>, |var SinkObserver| leaks once, as reported by Leak Monitor extension : [Attachment 234600] fix pref-locales to not use builtinURLs
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 339415: In <builtinURLs.js>, |var SinkObserver| leaks once, as reported by Leak Monitor extension https://bugzilla.mozilla.org/show_bug.cgi?id=339415 Attachment 234600: fix pref-locales to not use builtinURLs https://bugzilla.mozilla.org/attachment.cgi?id=234600&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> This patch fixes pref-locales to also go through a localized pref instead of builtinURLs. With this, we should be ready ...

superreview requested: [Bug 286108] Build Thunderbird Locales from CVS (--enable-ui-locale) : [Attachment 183307] Localized installer packaging, rev. 1
Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 286108: Build Thunderbird Locales from CVS (--enable-ui-locale) https://bugzilla.mozilla.org/show_bug.cgi?id=286108 Attachment 183307: Localized installer packaging, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=183307&action=edit ------- Additional Comments from Benjamin Smedberg [:bs] (formerly bsmedberg@covad.net) <benjamin@smedbergs.us> This is basically a copy of the l10n build scripts that we use for...

superreview requested: [Bug 151188] Pid-signature on profile lock not unique (was: No option to ignore profile lock), results in "profile is in use" message after crash : [Attachment 190038] fix
Robert O'Callahan (Novell) <roc@ocallahan.org> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 151188: Pid-signature on profile lock not unique (was: No option to ignore profile lock), results in "profile is in use" message after crash https://bugzilla.mozilla.org/show_bug.cgi?id=151188 Attachment 190038: fix https://bugzilla.mozilla.org/attachment.cgi?id=190038&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> This patch does that. It works. ...

superreview requested: [Bug 151188] Pid-signature on profile lock not unique (was: No option to ignore profile lock), results in "profile is in use" message after crash : [Attachment 190043] real fix
Robert O'Callahan (Novell) <roc@ocallahan.org> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 151188: Pid-signature on profile lock not unique (was: No option to ignore profile lock), results in "profile is in use" message after crash https://bugzilla.mozilla.org/show_bug.cgi?id=151188 Attachment 190043: real fix https://bugzilla.mozilla.org/attachment.cgi?id=190043&action=edit ------- Additional Comments from Robert O'Callahan (Novell) <roc@ocallahan.org> Sorry, the previous patch was the wrong patch. This is the right pat...

Web resources about - superreview requested: [Bug 343179] JS error by message tags, if using a Thunderbird locale in combination with a profile created with an other locale : [Attachment 227706] better fix - mozilla.dev.super-review

Resources last updated: 12/13/2015 9:51:12 AM