superreview cancelled: [Bug 342432] After Undo Close Tab, content area of newly-opened page isn't focused : [Attachment 236968] always focus the reopened tab's content area
Aaron Leventhal <aaronleventhal@moonset.net> has cancelled Simon B�nzli <zeniko@gmail.com>'s request for superreview: Bug 342432: After Undo Close Tab, content area of newly-opened page isn't focused https://bugzilla.mozilla.org/show_bug.cgi?id=342432 Attachment 236968: always focus the reopened tab's content area https://bugzilla.mozilla.org/attachment.cgi?id=236968&action=edit ------- Additional Comments from Aaron Leventhal <aaronleventhal@moonset.net> I can't do superreviews and anyway you don't need them for chrome. You need a toolkit...

superreview requested: [Bug 269318] TAB doesn't start from selection text after mouse click : [Attachment 166255] If element gets focused, move selection to focus if focus isn't already inside the s
Aaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 269318: TAB doesn't start from selection text after mouse click https://bugzilla.mozilla.org/show_bug.cgi?id=269318 Attachment 166255: If element gets focused, move selection to focus if focus isn't already inside the selection. mLastFocusedWith is no longer needed for making tab not move relative to selection after a mouse click https://bugzilla.mozilla.org/attachment.cgi?id=166255&action=edit ...

superreview requested: [Bug 300095] regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus : [Attachment 189863] Don't validate control r
Mark Mentovai <mark@moxienet.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 300095: regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus https://bugzilla.mozilla.org/show_bug.cgi?id=300095 Attachment 189863: Don't validate control rects https://bugzilla.mozilla.org/attachment.cgi?id=189863&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> By the time the validate happens, it's too late for us to really care. Might as well leave the re...

superreview granted: [Bug 269318] TAB doesn't start from selection text after mouse click : [Attachment 166255] If element gets focused, move selection to focus if focus isn't already inside the sel
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 269318: TAB doesn't start from selection text after mouse click https://bugzilla.mozilla.org/show_bug.cgi?id=269318 Attachment 166255: If element gets focused, move selection to focus if focus isn't already inside the selection. mLastFocusedWith is no longer needed for making tab not move relative to selection after a mouse click https://bugzilla.mozilla.org/attachment.cgi?id=166255&action=edit ------- Addition...

superreview granted: [Bug 300095] regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus : [Attachment 189863] Don't validate control rec
Simon Fraser <sfraser_bugs@smfr.org> has granted Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 300095: regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus https://bugzilla.mozilla.org/show_bug.cgi?id=300095 Attachment 189863: Don't validate control rects https://bugzilla.mozilla.org/attachment.cgi?id=189863&action=edit ...

superreview cancelled: [Bug 193011] Some tabs unresponsive/won't close when many tabs are open: followup from bug 156405 : [Attachment 129304] Patch to consider identical ?'s the same
Randell Jesup <rjesup@wgate.com> has cancelled Randell Jesup <rjesup@wgate.com>'s request for superreview: Bug 193011: Some tabs unresponsive/won't close when many tabs are open: followup from bug 156405 http://bugzilla.mozilla.org/show_bug.cgi?id=193011 Attachment 129304: Patch to consider identical ?'s the same http://bugzilla.mozilla.org/attachment.cgi?id=129304&action=edit ...

superreview requested: [Bug 193011] Some tabs unresponsive/won't close when many tabs are open: followup from bug 156405 : [Attachment 129377] Updated patch for review
Randell Jesup <rjesup@wgate.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 193011: Some tabs unresponsive/won't close when many tabs are open: followup from bug 156405 http://bugzilla.mozilla.org/show_bug.cgi?id=193011 Attachment 129377: Updated patch for review http://bugzilla.mozilla.org/attachment.cgi?id=129377&action=edit ...

superreview requested: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224087] updated patch, thanks gavin
Seth Spitzer <sspitzer@mozilla.com> has asked for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224087: updated patch, thanks gavin https://bugzilla.mozilla.org/attachment.cgi?id=224087&action=edit ...

superreview requested: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224127] revised patch, with two additional changes per gavin
Seth Spitzer <sspitzer@mozilla.com> has asked for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224127: revised patch, with two additional changes per gavin https://bugzilla.mozilla.org/attachment.cgi?id=224127&action=edit ...

superreview requested: [Bug 241972] new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins : [Attachment 227564] fixes in response to Darin's
Marria Nazif <marria@gmail.com> has asked Darin Fisher (Google) <darin@meer.net> for superreview: Bug 241972: new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins https://bugzilla.mozilla.org/show_bug.cgi?id=241972 Attachment 227564: fixes in response to Darin's review https://bugzilla.mozilla.org/attachment.cgi?id=227564&action=edit ------- Additional Comments from Marria Nazif <marria@gmail.com> > >+ /** > >+ * This is set based on whether the channel indica...

superreview requested: [Bug 267188] [MSAA] Expose tab number out of number of tabs in tab description : [Attachment 167693] Don't count on parent being cached. It often isn't.
Aaron Leventhal <aaronleventhal@moonset.net> has asked for superreview: Bug 267188: [MSAA] Expose tab number out of number of tabs in tab description https://bugzilla.mozilla.org/show_bug.cgi?id=267188 Attachment 167693: Don't count on parent being cached. It often isn't. https://bugzilla.mozilla.org/attachment.cgi?id=167693&action=edit ...

superreview requested: [Bug 303730] <textarea>s in other tabs mess up focus in current 'tab' : [Attachment 200072] trunk patch
Christian Persch <chpe@gnome.org> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 303730: <textarea>s in other tabs mess up focus in current 'tab' https://bugzilla.mozilla.org/show_bug.cgi?id=303730 Attachment 200072: trunk patch https://bugzilla.mozilla.org/attachment.cgi?id=200072&action=edit ...

superreview requested: [Bug 303730] <textarea>s in other tabs mess up focus in current 'tab' : [Attachment 191835] proposed fix
Christian Persch <chpe@gnome.org> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 303730: <textarea>s in other tabs mess up focus in current 'tab' https://bugzilla.mozilla.org/show_bug.cgi?id=303730 Attachment 191835: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=191835&action=edit ------- Additional Comments from Christian Persch <chpe@gnome.org> Let's request r/sr... (I hope I picked the right ones) ...

superreview requested: [Bug 267188] [MSAA] Expose tab number out of number of tabs in tab description : [Attachment 167693] Don't count on parent being cached. It often isn't. #2
Aaron Leventhal <aaronleventhal@moonset.net> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 267188: [MSAA] Expose tab number out of number of tabs in tab description https://bugzilla.mozilla.org/show_bug.cgi?id=267188 Attachment 167693: Don't count on parent being cached. It often isn't. https://bugzilla.mozilla.org/attachment.cgi?id=167693&action=edit ...