superreview requested: [Bug 342105] Close button not shown if there is only one tab : [Attachment 229158] don't treat a single tab in a special way

Seth Spitzer [:ss] <sspitzer@mozilla.com> has asked Mike Connor
<mconnor@mozilla.com> for superreview:
Bug 342105: Close button not shown if there is only one tab
https://bugzilla.mozilla.org/show_bug.cgi?id=342105

Attachment 229158: don't treat a single tab in a special way
https://bugzilla.mozilla.org/attachment.cgi?id=229158&action=edit

------- Additional Comments from Seth Spitzer [:ss] <sspitzer@mozilla.com>
r=sspitzer, seeking sr= from mconnor.
0
bugzilla
7/21/2006 8:10:51 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
568 Views

Similar Articles

[PageSpeed] 39
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview granted: [Bug 342105] Close button not shown if there is only one tab : [Attachment 229158] don't treat a single tab in a special way
Mike Connor <mconnor@mozilla.com> has granted Seth Spitzer [:ss] <sspitzer@mozilla.com>'s request for superreview: Bug 342105: Close button not shown if there is only one tab https://bugzilla.mozilla.org/show_bug.cgi?id=342105 Attachment 229158: don't treat a single tab in a special way https://bugzilla.mozilla.org/attachment.cgi?id=229158&action=edit ------- Additional Comments from Mike Connor <mconnor@mozilla.com> So, I don't know what error either, and this might be a legacy piece from where I relocated a bunch of that code, but without knowing...

superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank l
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 233414: blank last tab https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> Same as the Firefox imple...

superreview requested: [Bug 300095] regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus : [Attachment 189863] Don't validate control r
Mark Mentovai <mark@moxienet.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 300095: regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus https://bugzilla.mozilla.org/show_bug.cgi?id=300095 Attachment 189863: Don't validate control rects https://bugzilla.mozilla.org/attachment.cgi?id=189863&action=edit ------- Additional Comments from Mark Mentovai <mark@moxienet.com> By the time the validate happens, it's too late for us to really care. Might as well leave the re...

superreview requested: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=351289 Attachment 236765: patch https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> If you show the tab bar: Ctrl+F4 => close tab ...

superreview granted: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank las
neil@parkwaycc.co.uk <neil@httl.net> has granted Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 156082: Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 233414: blank last tab https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> This will cause me dataloss, because I...

superreview granted: [Bug 300095] regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus : [Attachment 189863] Don't validate control rec
Simon Fraser <sfraser_bugs@smfr.org> has granted Mark Mentovai <mark@moxienet.com>'s request for superreview: Bug 300095: regression: Tab close button draws over top of scroll bar of first tab after closing second tab, when page has focus https://bugzilla.mozilla.org/show_bug.cgi?id=300095 Attachment 189863: Don't validate control rects https://bugzilla.mozilla.org/attachment.cgi?id=189863&action=edit ...

superreview denied: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch
neil@parkwaycc.co.uk <neil@httl.net> has denied Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=351289 Attachment 236765: patch https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> 1. You shouldn't early return, you should reverse your conditi...

superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked
Asaf Romano <bugs.mano@mail-central.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit ------- Additional Comments from Asaf Romano <bugs.mano@mail-central.com> requesting r/sr for your patch. ...

superreview requested: [Bug 267188] [MSAA] Expose tab number out of number of tabs in tab description : [Attachment 167693] Don't count on parent being cached. It often isn't.
Aaron Leventhal <aaronleventhal@moonset.net> has asked for superreview: Bug 267188: [MSAA] Expose tab number out of number of tabs in tab description https://bugzilla.mozilla.org/show_bug.cgi?id=267188 Attachment 167693: Don't count on parent being cached. It often isn't. https://bugzilla.mozilla.org/attachment.cgi?id=167693&action=edit ...

superreview requested: [Bug 267188] [MSAA] Expose tab number out of number of tabs in tab description : [Attachment 167693] Don't count on parent being cached. It often isn't. #2
Aaron Leventhal <aaronleventhal@moonset.net> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 267188: [MSAA] Expose tab number out of number of tabs in tab description https://bugzilla.mozilla.org/show_bug.cgi?id=267188 Attachment 167693: Don't count on parent being cached. It often isn't. https://bugzilla.mozilla.org/attachment.cgi?id=167693&action=edit ...

superreview requested: [Bug 193011] Some tabs unresponsive/won't close when many tabs are open: followup from bug 156405 : [Attachment 129377] Updated patch for review
Randell Jesup <rjesup@wgate.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 193011: Some tabs unresponsive/won't close when many tabs are open: followup from bug 156405 http://bugzilla.mozilla.org/show_bug.cgi?id=193011 Attachment 129377: Updated patch for review http://bugzilla.mozilla.org/attachment.cgi?id=129377&action=edit ...

superreview requested: [Bug 430552] Browsing on the given site and closing the tab results in no active tab and keyboard shortcuts don't work until you refocus any element : [Attachment 318163] Fix.
Johnny Stenback (:jst) <jst@mozilla.org> has asked Blake Kaplan <mrbkap@gmail.com> for superreview: Bug 430552: Browsing on the given site and closing the tab results in no active tab and keyboard shortcuts don't work until you refocus any element https://bugzilla.mozilla.org/show_bug.cgi?id=430552 Attachment 318163: Fix. https://bugzilla.mozilla.org/attachment.cgi?id=318163&action=edit ------- Additional Comments from Johnny Stenback (:jst) <jst@mozilla.org> This fixes this problem. The issue is that we're in JS on context A (chrome) calling removeCh...

superreview requested: [Bug 430552] Browsing on the given site and closing the tab results in no active tab and keyboard shortcuts don't work until you refocus any element : [Attachment 318254] More c
ben turner [:bent] <bent.mozilla@gmail.com> has asked Blake Kaplan <mrbkap@gmail.com> for superreview: Bug 430552: Browsing on the given site and closing the tab results in no active tab and keyboard shortcuts don't work until you refocus any element https://bugzilla.mozilla.org/show_bug.cgi?id=430552 Attachment 318254: More complete fix https://bugzilla.mozilla.org/attachment.cgi?id=318254&action=edit ------- Additional Comments from ben turner [:bent] <bent.mozilla@gmail.com> There were several other places where we could call the security code without a...

superreview requested: [Bug 336216] Tabs don't do mouse tracking correctly across key window changes : [Attachment 227489] Patch (Fixed: added condition to tab buttons needing re-display)
Aaron Schulman <aschulm@gmail.com> has asked for superreview: Bug 336216: Tabs don't do mouse tracking correctly across key window changes https://bugzilla.mozilla.org/show_bug.cgi?id=336216 Attachment 227489: Patch (Fixed: added condition to tab buttons needing re-display) https://bugzilla.mozilla.org/attachment.cgi?id=227489&action=edit ...

Web resources about - superreview requested: [Bug 342105] Close button not shown if there is only one tab : [Attachment 229158] don't treat a single tab in a special way - mozilla.dev.super-review

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 12/16/2015 3:21:28 PM