superreview requested: [Bug 339415] In <builtinURLs.js>, |var SinkObserver| leaks once, as reported by Leak Monitor extension : [Attachment 234600] fix pref-locales to not use builtinURLs

Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net>
for superreview:
Bug 339415: In <builtinURLs.js>, |var SinkObserver| leaks once, as reported by
Leak Monitor extension
https://bugzilla.mozilla.org/show_bug.cgi?id=339415

Attachment 234600: fix pref-locales to not use builtinURLs
https://bugzilla.mozilla.org/attachment.cgi?id=234600&action=edit

------- Additional Comments from Robert Kaiser <kairo@kairo.at>
This patch fixes pref-locales to also go through a localized pref instead of 
builtinURLs. With this, we should be ready to kill the whole builtinURLs
mechanism in SeaMonkey.

I'm using a pref name that goes along with those used by Add-Ons, so that it
probably can be reused there once Add-Ons adds a separate section for locale
packs (along with switching, like for themes). Currently, it treats Language
packs just like other extensions, but there are plans for the future to support
them better from there.
0
bugzilla
8/19/2006 5:31:18 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
430 Views

Similar Articles

[PageSpeed] 28
Get it on Google Play
Get it on Apple App Store

Reply: