superreview cancelled: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224127] revised patch, with two additional changes per gavin
Seth Spitzer <sspitzer@mozilla.com> has cancelled Seth Spitzer <sspitzer@mozilla.com>'s request for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224127: revised patch, with two additional changes per gavin https://bugzilla.mozilla.org/attachment.cgi?id=224127&action=edit ------- Additional Comments from Seth Spitzer <sspitzer@mozilla.com> re-requesting review from mconnor ...

superreview requested: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224087] updated patch, thanks gavin
Seth Spitzer <sspitzer@mozilla.com> has asked for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224087: updated patch, thanks gavin https://bugzilla.mozilla.org/attachment.cgi?id=224087&action=edit ...

superreview cancelled: [Bug 339036] "focus parent tab on tab close" optimization shouldn't apply to new blank tabs : [Attachment 224087] updated patch, thanks gavin
Seth Spitzer <sspitzer@mozilla.com> has cancelled Seth Spitzer <sspitzer@mozilla.com>'s request for superreview: Bug 339036: "focus parent tab on tab close" optimization shouldn't apply to new blank tabs https://bugzilla.mozilla.org/show_bug.cgi?id=339036 Attachment 224087: updated patch, thanks gavin https://bugzilla.mozilla.org/attachment.cgi?id=224087&action=edit ...

superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked
Asaf Romano <bugs.mano@mail-central.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit ------- Additional Comments from Asaf Romano <bugs.mano@mail-central.com> requesting r/sr for your patch. ...

superreview requested: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank l
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 156082: Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 233414: blank last tab https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> Same as the Firefox imple...

superreview requested: [Bug 275430] change "open links from other applications" to be "a new tab in the most recent window" instead of "the most recent tab/window" : [Attachment 177848] Patch to make
Jeremy Morton <bugzilla@game-point.net> has asked Ben Goodger <bugs@bengoodger.com> for superreview: Bug 275430: change "open links from other applications" to be "a new tab in the most recent window" instead of "the most recent tab/window" https://bugzilla.mozilla.org/show_bug.cgi?id=275430 Attachment 177848: Patch to make externally-launched links open in new window https://bugzilla.mozilla.org/attachment.cgi?id=177848&action=edit ...

superreview requested: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=351289 Attachment 236765: patch https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> If you show the tab bar: Ctrl+F4 => close tab ...

superreview denied: [Bug 156082] Don't hide the tab bar when clicking the close box : [Attachment 160372] Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked
jag (Peter Annema) <jag@tty.nl> has denied Asaf Romano <bugs.mano@mail-central.com>'s request for superreview: Bug 156082: Don't hide the tab bar when clicking the close box https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 160372: Blanks last tab instead of hiding the Tab Bar if "Hide Tab Bar" option is unticked https://bugzilla.mozilla.org/attachment.cgi?id=160372&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> Erh, you shouldn't have to check the autohide pref, if that is set to true, with onl...

superreview granted: [Bug 156082] Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) : [Attachment 233414] blank las
neil@parkwaycc.co.uk <neil@httl.net> has granted Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 156082: Don't hide the tab bar when clicking the close box (pref for showing single tab ["Hide tab bar when only one tab is open"] is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=156082 Attachment 233414: blank last tab https://bugzilla.mozilla.org/attachment.cgi?id=233414&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> This will cause me dataloss, because I...

superreview requested: [Bug 327873] Return-to-parent tab doesn't work for tabs opened by target="_blank" links : [Attachment 223184] patch v2
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 327873: Return-to-parent tab doesn't work for tabs opened by target="_blank" links https://bugzilla.mozilla.org/show_bug.cgi?id=327873 Attachment 223184: patch v2 https://bugzilla.mozilla.org/attachment.cgi?id=223184&action=edit ...

superreview requested: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 237073] A Patch Not On Crack
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items https://bugzilla.mozilla.org/show_bug.cgi?id=290212 Attachment 237073: A Patch Not On Crack https://bugzilla.mozilla.org/attachment.cgi?id=237073&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> r=me. Style stuff: >+ NSMenuItem* menuItem = [[NSMenuItem alloc] initWithTitle:NSL...

superreview requested: [Bug 290212] Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items : [Attachment 241797] r=smorgan patch
froodian (unreliable 10/7-10/12) <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 290212: Implement bookmark folders' "Open in Tabs"/"Open in New Tabs" with alternate menu items https://bugzilla.mozilla.org/show_bug.cgi?id=290212 Attachment 241797: r=smorgan patch https://bugzilla.mozilla.org/attachment.cgi?id=241797&action=edit ...

superreview requested: [Bug 355204] Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group" : [Attachment 241740] New AddBookmark.nib
froodian (unreliable 10/7-10/12) <stridey@gmail.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 355204: Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group" https://bugzilla.mozilla.org/show_bug.cgi?id=355204 Attachment 241740: New AddBookmark.nib https://bugzilla.mozilla.org/attachment.cgi?id=241740&action=edit ------- Additional Comments from froodian (unreliable 10/7-10/12) <stridey@gmail.com> Same as last time, but sets the minimum size to 450, per comment 2. ...

superreview requested: [Bug 355204] Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group" : [Attachment 241643] new AddBookmark.nib
Smokey Ardisson (away indefinitely; no bugmail) <alqahira@mindspring.com> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 355204: Add Bookmark Sheet's "Bookmark All Tabs" Checkbox should read "Bookmark Current Tabs as Tab Group" https://bugzilla.mozilla.org/show_bug.cgi?id=355204 Attachment 241643: new AddBookmark.nib https://bugzilla.mozilla.org/attachment.cgi?id=241643&action=edit ------- Additional Comments from Smokey Ardisson (away indefinitely; no bugmail) <alqahira@mindspring.com> A minor niggle: the nib ge...