superreview requested: [Bug 337942] Remove some unused interface functions in address book : [Attachment 221984] Remove unused functions

Mark Banner <bugzilla@standard8.demon.co.uk> has asked Dan Mosedale
<dmose@mozilla.org> for superreview:
Bug 337942: Remove some unused interface functions in address book
https://bugzilla.mozilla.org/show_bug.cgi?id=337942

Attachment 221984: Remove unused functions
https://bugzilla.mozilla.org/attachment.cgi?id=221984&action=edit

------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk>
Simple patch to remove the unused functions as detailed in comment 0.
0
bugzilla
5/14/2006 9:05:34 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
749 Views

Similar Articles

[PageSpeed] 38
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview cancelled: [Bug 337942] Remove some unused interface functions in address book : [Attachment 221984] Remove unused functions
Mark Banner <bugzilla@standard8.demon.co.uk> has cancelled Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 337942: Remove some unused interface functions in address book https://bugzilla.mozilla.org/show_bug.cgi?id=337942 Attachment 221984: Remove unused functions https://bugzilla.mozilla.org/attachment.cgi?id=221984&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> I'm going to add the other function removal that I found to this patch before it gets reviewed... ...

superreview requested: [Bug 337942] Remove some unused interface functions in address book : [Attachment 222051] Remove unused functions v2
Mark Banner <bugzilla@standard8.demon.co.uk> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 337942: Remove some unused interface functions in address book https://bugzilla.mozilla.org/show_bug.cgi?id=337942 Attachment 222051: Remove unused functions v2 https://bugzilla.mozilla.org/attachment.cgi?id=222051&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Revised patch adding in the removal of the other redundant function I found. ...

superreview cancelled: [Bug 337942] Remove some unused interface functions in address book : [Attachment 221984] Remove unused functions #2
Mark Banner <bugzilla@standard8.demon.co.uk> has cancelled Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 337942: Remove some unused interface functions in address book https://bugzilla.mozilla.org/show_bug.cgi?id=337942 Attachment 221984: Remove unused functions https://bugzilla.mozilla.org/attachment.cgi?id=221984&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> I'm going to add the other function removal that I found to this patch before it gets reviewed... ...

superreview requested: [Bug 337942] Remove some unused interface functions in address book : [Attachment 222051] Remove unused functions v2 #2
Mark Banner <bugzilla@standard8.demon.co.uk> has asked David Bienvenu - not reading bug mail from May 10th-May 18th <bienvenu@nventure.com> for superreview: Bug 337942: Remove some unused interface functions in address book https://bugzilla.mozilla.org/show_bug.cgi?id=337942 Attachment 222051: Remove unused functions v2 https://bugzilla.mozilla.org/attachment.cgi?id=222051&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> I'm guessing Dan is busy with calendar/lightning, so I'm switching reviews to David now he&...

superreview granted: [Bug 337942] Remove some unused interface functions in address book : [Attachment 222051] Remove unused functions v2
David Bienvenu - not reading bug mail from May 10th-May 18th <bienvenu@nventure.com> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 337942: Remove some unused interface functions in address book https://bugzilla.mozilla.org/show_bug.cgi?id=337942 Attachment 222051: Remove unused functions v2 https://bugzilla.mozilla.org/attachment.cgi?id=222051&action=edit ------- Additional Comments from David Bienvenu - not reading bug mail from May 10th-May 18th <bienvenu@nventure.com> do we know that no extensions used get/set ...

superreview requested: [Bug 342687] Remove unused message type parameters in some compose js functions : [Attachment 226995] Removes unused parameters
Mark Banner <bugzilla@standard8.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 342687: Remove unused message type parameters in some compose js functions https://bugzilla.mozilla.org/show_bug.cgi?id=342687 Attachment 226995: Removes unused parameters https://bugzilla.mozilla.org/attachment.cgi?id=226995&action=edit ...

superreview requested: [Bug 219979] remove unused variable and function : [Attachment 131905] remove them
timeless@myrealbox.com <timeless@bemail.org> has asked Daniel Veditz <dveditz+bmo@cruzio.com> for superreview: Bug 219979: remove unused variable and function http://bugzilla.mozilla.org/show_bug.cgi?id=219979 Attachment 131905: remove them http://bugzilla.mozilla.org/attachment.cgi?id=131905&action=edit ...

superreview granted: [Bug 342687] Remove unused message type parameters in some compose js functions : [Attachment 226995] Removes unused parameters
David Bienvenu <bienvenu@nventure.com> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 342687: Remove unused message type parameters in some compose js functions https://bugzilla.mozilla.org/show_bug.cgi?id=342687 Attachment 226995: Removes unused parameters https://bugzilla.mozilla.org/attachment.cgi?id=226995&action=edit ...

superreview requested: [Bug 90906] Go through all modules and remove "unused variable" : [Attachment 137382] (Hv1) "Unused variable `[...]'", with no function call.
Serge GAUTHERIE <gautheri@noos.fr> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 90906: Go through all modules and remove "unused variable" http://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 137382: (Hv1) "Unused variable `[...]'", with no function call. http://bugzilla.mozilla.org/attachment.cgi?id=137382&action=edit ------- Additional Comments from Serge GAUTHERIE <gautheri@noos.fr> 'r=?': (see comment 18) Can you (super-)review, compile, test, check it in ? ...

superreview granted: [Bug 219979] remove unused variable and function : [Attachment 131905] remove them
Daniel Veditz <dveditz+bmo@cruzio.com> has granted timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 219979: remove unused variable and function http://bugzilla.mozilla.org/show_bug.cgi?id=219979 Attachment 131905: remove them http://bugzilla.mozilla.org/attachment.cgi?id=131905&action=edit ------- Additional Comments from Daniel Veditz <dveditz+bmo@cruzio.com> r+sr=dveditz ...

superreview requested: [Bug 319003] remove unused variable gSession from TestCacheService : [Attachment 204935] remove unused var
timeless@myrealbox.com <timeless@bemail.org> has asked Darin Fisher <darin@meer.net> for superreview: Bug 319003: remove unused variable gSession from TestCacheService https://bugzilla.mozilla.org/show_bug.cgi?id=319003 Attachment 204935: remove unused var https://bugzilla.mozilla.org/attachment.cgi?id=204935&action=edit ...

superreview requested: [Bug 291123] remove unused MOZ_THREADSAFE_RDF and locks from nsInMemoryDataSource : [Attachment 181288] remove unused lock code from nsInMemoryDataSource
Axel Hecht <axel@pike.org> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 291123: remove unused MOZ_THREADSAFE_RDF and locks from nsInMemoryDataSource https://bugzilla.mozilla.org/show_bug.cgi?id=291123 Attachment 181288: remove unused lock code from nsInMemoryDataSource https://bugzilla.mozilla.org/attachment.cgi?id=181288&action=edit ...

superreview requested: [Bug 290043] Tidy address book code (nsIAddrDBAnnouncer and nsIAddrDBListener) : [Attachment 182011] Remove unused parameters
Mark Banner <bugzilla@standard8.demon.co.uk> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 290043: Tidy address book code (nsIAddrDBAnnouncer and nsIAddrDBListener) https://bugzilla.mozilla.org/show_bug.cgi?id=290043 Attachment 182011: Remove unused parameters https://bugzilla.mozilla.org/attachment.cgi?id=182011&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Requesting sr. Scott, please also confirm your approval for the files nsAbRDFResource.h/.cpp in mailnews/addressbook/src/ to be removed as ...

superreview requested: [Bug 253794] mailnews need not reimplement strtok_r : [Attachment 170041] Remove unused functions from AB code.
Mark Banner <mark@standard8.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 253794: mailnews need not reimplement strtok_r https://bugzilla.mozilla.org/show_bug.cgi?id=253794 Attachment 170041: Remove unused functions from AB code. https://bugzilla.mozilla.org/attachment.cgi?id=170041&action=edit ------- Additional Comments from Mark Banner <mark@standard8.demon.co.uk> The instance of the duplicated strtok function in the address book code mentioned in bug 248768 is not actually required, the two functions that use it are no...

Web resources about - superreview requested: [Bug 337942] Remove some unused interface functions in address book : [Attachment 221984] Remove unused functions - mozilla.dev.super-review

Resources last updated: 12/6/2015 6:39:08 PM