superreview requested: [Bug 337025] Coverity 411, dead code in mozilla/security/nss/lib/certdb/stanpcertdb.c : [Attachment 222117] Remove more dead code

Wan-Teh Chang <wtchang@redhat.com> has asked Nelson Bolyard
<nelson@bolyard.com> for superreview:
Bug 337025: Coverity 411, dead code in
mozilla/security/nss/lib/certdb/stanpcertdb.c
https://bugzilla.mozilla.org/show_bug.cgi?id=337025

Attachment 222117: Remove more dead code
https://bugzilla.mozilla.org/attachment.cgi?id=222117&action=edit

------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com>
1. 'subject' is assigned but not used.
2. 'pprofTime' and 'pprofData' always have the
   values &profTime and &profData and so aren't
   necessary any more.
0
bugzilla
5/15/2006 11:38:35 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
534 Views

Similar Articles

[PageSpeed] 17

Reply:

Similar Artilces:

superreview requested: [Bug 357530] Remove dead code from DraggableImageAndTextCell : [Attachment 243037] removes dead code
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 357530: Remove dead code from DraggableImageAndTextCell https://bugzilla.mozilla.org/show_bug.cgi?id=357530 Attachment 243037: removes dead code https://bugzilla.mozilla.org/attachment.cgi?id=243037&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> Simon, since you're listed as the author I figure you're in the best position to know if there's any downside I'm missing to doing this. ...

superreview requested: [Bug 352406] Dead code in nsMsgDBView : [Attachment 238080] remove dead observer code
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 352406: Dead code in nsMsgDBView https://bugzilla.mozilla.org/show_bug.cgi?id=352406 Attachment 238080: remove dead observer code https://bugzilla.mozilla.org/attachment.cgi?id=238080&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> removes dead observer code that was listening for the old label pref names. We removed the observer registration code when the tags stuff landed. ...

superreview requested: [Bug 281744] Remove dead code and silly plugin code : [Attachment 173910] Remove silly code
Johnny Stenback <jst@mozilla.org> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 281744: Remove dead code and silly plugin code https://bugzilla.mozilla.org/show_bug.cgi?id=281744 Attachment 173910: Remove silly code https://bugzilla.mozilla.org/attachment.cgi?id=173910&action=edit ...

superreview granted: [Bug 357530] Remove dead code from DraggableImageAndTextCell : [Attachment 243037] removes dead code
Simon Fraser <sfraser_bugs@smfr.org> has granted Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 357530: Remove dead code from DraggableImageAndTextCell https://bugzilla.mozilla.org/show_bug.cgi?id=357530 Attachment 243037: removes dead code https://bugzilla.mozilla.org/attachment.cgi?id=243037&action=edit ...

superreview requested: [Bug 244895] gfx dead code removal : [Attachment 149440] remove code related to old svg implementation
T Rowley (IBM) <tor@acm.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244895: gfx dead code removal http://bugzilla.mozilla.org/show_bug.cgi?id=244895 Attachment 149440: remove code related to old svg implementation http://bugzilla.mozilla.org/attachment.cgi?id=149440&action=edit ...

superreview granted: [Bug 281744] Remove dead code and silly plugin code : [Attachment 173910] Remove silly code
Peter Van der Beken <peterv@propagandism.org> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 281744: Remove dead code and silly plugin code https://bugzilla.mozilla.org/show_bug.cgi?id=281744 Attachment 173910: Remove silly code https://bugzilla.mozilla.org/attachment.cgi?id=173910&action=edit ...

superreview granted: [Bug 352406] Dead code in nsMsgDBView : [Attachment 238080] remove dead observer code
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 352406: Dead code in nsMsgDBView https://bugzilla.mozilla.org/show_bug.cgi?id=352406 Attachment 238080: remove dead observer code https://bugzilla.mozilla.org/attachment.cgi?id=238080&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> I wonder if more stuff should be removed now - I'll look into it... ...

superreview requested: [Bug 244895] gfx dead code removal : [Attachment 149517] more dead methods
T Rowley (IBM) <tor@acm.org> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 244895: gfx dead code removal http://bugzilla.mozilla.org/show_bug.cgi?id=244895 Attachment 149517: more dead methods http://bugzilla.mozilla.org/attachment.cgi?id=149517&action=edit ...

superreview requested: [Bug 257693] EC_ValidatePublicKey needs actual checks in security/nss/lib/freebl/ec.c : [Attachment 198726] Set the error code correctly
Wan-Teh Chang <wtchang@redhat.com> has asked Robert Relyea <rrelyea@redhat.com> for superreview: Bug 257693: EC_ValidatePublicKey needs actual checks in security/nss/lib/freebl/ec.c https://bugzilla.mozilla.org/show_bug.cgi?id=257693 Attachment 198726: Set the error code correctly https://bugzilla.mozilla.org/attachment.cgi?id=198726&action=edit ...

superreview granted: [Bug 244895] gfx dead code removal : [Attachment 149440] remove code related to old svg implementation
Robert O'Callahan <roc@ocallahan.org> has granted T Rowley (IBM) <tor@acm.org>'s request for superreview: Bug 244895: gfx dead code removal http://bugzilla.mozilla.org/show_bug.cgi?id=244895 Attachment 149440: remove code related to old svg implementation http://bugzilla.mozilla.org/attachment.cgi?id=149440&action=edit ...

superreview granted: [Bug 244895] gfx dead code removal : [Attachment 149517] more dead methods
Robert O'Callahan <roc@ocallahan.org> has granted T Rowley (IBM) <tor@acm.org>'s request for superreview: Bug 244895: gfx dead code removal http://bugzilla.mozilla.org/show_bug.cgi?id=244895 Attachment 149517: more dead methods http://bugzilla.mozilla.org/attachment.cgi?id=149517&action=edit ...

superreview requested: [Bug 298962] Remove nssBestCertificate related dead code : [Attachment 187462] Proposed patch
Wan-Teh Chang <wtchang@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 298962: Remove nssBestCertificate related dead code https://bugzilla.mozilla.org/show_bug.cgi?id=298962 Attachment 187462: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=187462&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> Removed unused functions nssBestCertificate_SetArgs and nssBestCertificate_Callback and unused type nssBestCertificateCB. It is easy to verify with LXR that they are unused. (The two funct...

superreview requested: [Bug 338022] Dead code in buildASN1ObjectFromDER (security/manager/ssl/src/nsNSSASN1Object.cpp) : [Attachment 239701] Patch v1
Ryan Jones <sciguyryan+bugzilla@gmail.com> has asked Kai Engert <kaie@kuix.de> for superreview: Bug 338022: Dead code in buildASN1ObjectFromDER (security/manager/ssl/src/nsNSSASN1Object.cpp) https://bugzilla.mozilla.org/show_bug.cgi?id=338022 Attachment 239701: Patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=239701&action=edit ------- Additional Comments from Ryan Jones <sciguyryan+bugzilla@gmail.com> First try at a patch, remove dead code. ...

superreview requested: [Bug 295754] PK11_ListCertsInSlot crashes in subject_list_sort on a cert with unsupported critical extension : [Attachment 187441] Remove dead code nssBestCertificate_Callback
Wan-Teh Chang <wtchang@redhat.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 295754: PK11_ListCertsInSlot crashes in subject_list_sort on a cert with unsupported critical extension https://bugzilla.mozilla.org/show_bug.cgi?id=295754 Attachment 187441: Remove dead code nssBestCertificate_Callback https://bugzilla.mozilla.org/attachment.cgi?id=187441&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> Using LXR, it is easy to verify nssBestCertificate_Callback is dead code. On an unrelated note, at the end...

superreview requested: [Bug 239953] Remove duplicated code in nsContentUtils : [Attachment 145654] Remove duplicated code.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 239953: Remove duplicated code in nsContentUtils http://bugzilla.mozilla.org/show_bug.cgi?id=239953 Attachment 145654: Remove duplicated code. http://bugzilla.mozilla.org/attachment.cgi?id=145654&action=edit ...

Web resources about - superreview requested: [Bug 337025] Coverity 411, dead code in mozilla/security/nss/lib/certdb/stanpcertdb.c : [Attachment 222117] Remove more dead code - mozilla.dev.super-review

Resources last updated: 12/26/2015 3:30:59 PM