superreview cancelled: [Bug 335755] Extension XUL overlay errors should not create a gray bar : [Attachment 220937] Don't output error message for overlays that don't parse properly
Neil Deakin <enndeakin@sympatico.ca> has cancelled Neil Deakin <enndeakin@sympatico.ca>'s request for superreview: Bug 335755: Extension XUL overlay errors should not create a gray bar https://bugzilla.mozilla.org/show_bug.cgi?id=335755 Attachment 220937: Don't output error message for overlays that don't parse properly https://bugzilla.mozilla.org/attachment.cgi?id=220937&action=edit ...

superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs https://bugzilla.mozilla.org/show_bug.cgi?id=340083 Attachment 224205: don't create frames for content we don't handle, don't invalidate nondisplay content https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit ...

superreview requested: [Bug 430999] Console log error message: .sdef error: Operation could not be completed. (NSXMLParserErrorDomain error 27.) : [Attachment 317950] don't use &[lr]dquo;
Smokey Ardisson (behind; no bugmail - do not email) <alqahira@ardisson.org> has asked Stuart Morgan <stuart.morgan@alumni.case.edu> for superreview: Bug 430999: Console log error message: .sdef error: Operation could not be completed. (NSXMLParserErrorDomain error 27.) https://bugzilla.mozilla.org/show_bug.cgi?id=430999 Attachment 317950: don't use &[lr]dquo; https://bugzilla.mozilla.org/attachment.cgi?id=317950&action=edit ------- Additional Comments from Smokey Ardisson (behind; no bugmail - do not email) <alqahira@ardisson.org> Apparently I didn...

superreview requested: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ...

superreview requested: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ...

superreview requested: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 179246] Like so
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozilla.org> for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 179246: Like so https://bugzilla.mozilla.org/attachment.cgi?id=179246&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This would be simpler if we could depend on the bit on mData, but since we can't... ...

superreview requested: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 180304] Same as diff -w
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozillafoundation.org> for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 180304: Same as diff -w https://bugzilla.mozilla.org/attachment.cgi?id=180304&action=edit ...

superreview requested: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sense
timeless@myrealbox.com <timeless@bemail.org> has asked Johnny Stenback <jst@netscape.com> for superreview: Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape http://bugzilla.mozilla.org/show_bug.cgi?id=217896 Attachment 130691: don't do silly things that don't make sense http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit ...

superreview requested: [Bug 335755] Extension XUL overlay errors should not create a gray bar : [Attachment 220993] Address comments
Neil Deakin <enndeakin@sympatico.ca> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 335755: Extension XUL overlay errors should not create a gray bar https://bugzilla.mozilla.org/show_bug.cgi?id=335755 Attachment 220993: Address comments https://bugzilla.mozilla.org/attachment.cgi?id=220993&action=edit ...

superreview requested: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150529] patch for build error
Makoto Kato <m_kato@ga2.so-net.ne.jp> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150529: patch for build error http://bugzilla.mozilla.org/attachment.cgi?id=150529&action=edit ...

superreview requested: [Bug 363654] .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch : [Attachment 248458] disables .url in file:open
Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org> has asked Stuart Morgan <stuart.morgan@alumni.case.edu> for superreview: Bug 363654: .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch https://bugzilla.mozilla.org/show_bug.cgi?id=363654 Attachment 248458: disables .url in file:open https://bugzilla.mozilla.org/attachment.cgi?id=248458&action=edit ------- Additional Comments from Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org> Asking for sr on this 7-char patch in case we need to take it ...

superreview requested: [Bug 307363] Don't add '---^' to XML errors in the JS console : [Attachment 195151] v1
Peter Van der Beken <peterv@propagandism.org> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 307363: Don't add '---^' to XML errors in the JS console https://bugzilla.mozilla.org/show_bug.cgi?id=307363 Attachment 195151: v1 https://bugzilla.mozilla.org/attachment.cgi?id=195151&action=edit ...

superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if t
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Duh, thanks. r+sr=me....

superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #3
Aaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...