superreview granted: [Bug 333579] Firefox crash with Window-Eyes and DHTML/AJAX : [Attachment 228812] Two fixes for image map a11y: 1) Don't walk into maps so that areas don't show twice in a11y tree,
neil@parkwaycc.co.uk <neil@httl.net> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 333579: Firefox crash with Window-Eyes and DHTML/AJAX https://bugzilla.mozilla.org/show_bug.cgi?id=333579 Attachment 228812: Two fixes for image map a11y: 1) Don't walk into maps so that areas don't show twice in a11y tree, 2) Don't refer to |this| in area constructor, Init() from outside as other accessibles do https://bugzilla.mozilla.org/attachment.cgi?id=228812&action=edit ------- Additional Comments from neil@parkwaycc.co....

superreview requested: [Bug 298642] Support official DHTML a11y DTD : [Attachment 187177] 1) Fix GetDocType(), 1) Use doctype to determine if we're a special XHTML app, 2) If we are, don't require na
Aaron Leventhal <aaronleventhal@moonset.net> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 298642: Support official DHTML a11y DTD https://bugzilla.mozilla.org/show_bug.cgi?id=298642 Attachment 187177: 1) Fix GetDocType(), 1) Use doctype to determine if we're a special XHTML app, 2) If we are, don't require namespaces on role & state attribs, 3) Capitalize role names, 4) Remove 3 unnecessary roles https://bugzilla.mozilla.org/attachment.cgi?id=187177&action=edit ...

superreview granted: [Bug 340083] Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs : [Attachment 224205] don't create frames for content we don't handle, don't invalidate nond
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted superreview: Bug 340083: Crash [@ nsSVGPathGeometryFrame::GetCanvasTM] with image in title in defs https://bugzilla.mozilla.org/show_bug.cgi?id=340083 Attachment 224205: don't create frames for content we don't handle, don't invalidate nondisplay content https://bugzilla.mozilla.org/attachment.cgi?id=224205&action=edit ...

superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #3
Aaron Leventhal <aaronleventhal@moonset.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview requested: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to c #2
Aaron Leventhal (vacation: mostly gone until Oct 17) <aaronleventhal@moonset.net> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview requested: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ...

superreview granted: [Bug 298642] Support official DHTML a11y DTD : [Attachment 187177] 1) Fix GetDocType(), 1) Use doctype to determine if we're a special XHTML app, 2) If we are, don't require name
Johnny Stenback <jst@mozilla.org> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 298642: Support official DHTML a11y DTD https://bugzilla.mozilla.org/show_bug.cgi?id=298642 Attachment 187177: 1) Fix GetDocType(), 1) Use doctype to determine if we're a special XHTML app, 2) If we are, don't require namespaces on role & state attribs, 3) Capitalize role names, 4) Remove 3 unnecessary roles https://bugzilla.mozilla.org/attachment.cgi?id=187177&action=edit ------- Additional Comments from Johnny Stenback <jst@m...

superreview requested: [Bug 288532] OOM crash [@ XPCConvert::JSErrorToXPCException] : [Attachment 179228] don't leak and don't crash
timeless@myrealbox.com (working) <timeless@bemail.org> has asked rbs@maths.uq.edu.au for superreview: Bug 288532: OOM crash [@ XPCConvert::JSErrorToXPCException] https://bugzilla.mozilla.org/show_bug.cgi?id=288532 Attachment 179228: don't leak and don't crash https://bugzilla.mozilla.org/attachment.cgi?id=179228&action=edit ...

superreview granted: [Bug 312788] Crash exposing invisible plugins : [Attachment 199889] Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to cre
Brian Ryner <bryner@brianryner.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 312788: Crash exposing invisible plugins https://bugzilla.mozilla.org/show_bug.cgi?id=312788 Attachment 199889: Don't expose invisible plugins (0 area rect). While we're at it, make absolutely sure we don't ever try to create children for native accessibles (make native accessibles inherit from the leaf class) https://bugzilla.mozilla.org/attachment.cgi?id=199889&action=edit ...

superreview requested: [Bug 300779] Support multiple selection for xul:tree : [Attachment 190476] Expose via a11y events. We don't need DOMItemSelected after all, they aren't fired for tree. We'll g #3
Aaron Leventhal <aaronleventhal@moonset.net> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 300779: Support multiple selection for xul:tree https://bugzilla.mozilla.org/show_bug.cgi?id=300779 Attachment 190476: Expose via a11y events. We don't need DOMItemSelected after all, they aren't fired for tree. We'll go off of "select" DOM events later for the add/remove a11y events. https://bugzilla.mozilla.org/attachment.cgi?id=190476&action=edit ...

superreview requested: [Bug 300779] Support multiple selection for xul:tree : [Attachment 190476] Expose via a11y events. We don't need DOMItemSelected after all, they aren't fired for tree. We'll g #2
Aaron Leventhal <aaronleventhal@moonset.net> has asked Brian Ryner <bryner@brianryner.com> for superreview: Bug 300779: Support multiple selection for xul:tree https://bugzilla.mozilla.org/show_bug.cgi?id=300779 Attachment 190476: Expose via a11y events. We don't need DOMItemSelected after all, they aren't fired for tree. We'll go off of "select" DOM events later for the add/remove a11y events. https://bugzilla.mozilla.org/attachment.cgi?id=190476&action=edit ...

superreview requested: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ...

superreview granted: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Boris Zbarsky <bzbarsky@mit.edu> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, I guess.. Is ther a reason mIsBrokenPlugin is write-only? ...

superreview requested: [Bug 288574] [FIX]Don't call ValueAppended for DOM changes that don't create the value : [Attachment 179246] Like so
Boris Zbarsky <bzbarsky@mit.edu> has asked David Baron <dbaron@mozilla.org> for superreview: Bug 288574: [FIX]Don't call ValueAppended for DOM changes that don't create the value https://bugzilla.mozilla.org/show_bug.cgi?id=288574 Attachment 179246: Like so https://bugzilla.mozilla.org/attachment.cgi?id=179246&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This would be simpler if we could depend on the bit on mData, but since we can't... ...