superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219154] Patch for the Windows build v3

Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil@httl.net>
for superreview:
Bug 330053: Make SeaMonkey capable of generating a reasonable build with
MOZ_XUL_APP set.
https://bugzilla.mozilla.org/show_bug.cgi?id=330053

Attachment 219154: Patch for the Windows build v3
https://bugzilla.mozilla.org/attachment.cgi?id=219154&action=edit

------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de>
Removed the ID_DDE_APPLICATION_NAME define since it's not needed in toolkit/
code and so also removed the ifdef change in nsNativeAppSupportWin.h.
0
bugzilla
4/20/2006 4:54:39 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
622 Views

Similar Articles

[PageSpeed] 18

Reply:

Similar Artilces:

superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219154] Patch for the Windows build v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219154: Patch for the Windows build v3 https://bugzilla.mozilla.org/attachment.cgi?id=219154&action=edit ...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219055] Patch for the Windows build v2
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219055: Patch for the Windows build v2 https://bugzilla.mozilla.org/attachment.cgi?id=219055&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> For this patch to apply you need to copy mozilla.ico from xpfe/bootstrap/ to suite/branding/icons/windows/. ...

superreview cancelled: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219055] Patch for the Windows build v2
Frank Wein <bugzilla@mcsmurf.de> has cancelled Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219055: Patch for the Windows build v2 https://bugzilla.mozilla.org/attachment.cgi?id=219055&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Removed the ID_DDE_APPLICATION_NAME define since it's not needed in toolkit/ code and so also removed the ifdef change in nsNa...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218593] Make mac build complete
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218593: Make mac build complete https://bugzilla.mozilla.org/attachment.cgi?id=218593&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> This is the pathc to get suiterunner to build on Mac. Some of this is just correcting the Makefile to things we already do in xpfe/bootstrap (the Info.pli...

superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218593] Make mac build complete
jag (Peter Annema) <jag@tty.nl> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218593: Make mac build complete https://bugzilla.mozilla.org/attachment.cgi?id=218593&action=edit ...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218079] Part 5 v6
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218079: Part 5 v6 - First stab at sorting out inclusion of modules in xpfe and toolkit https://bugzilla.mozilla.org/attachment.cgi?id=218079&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Updated patch to account for bitrot from a checkin earlier today. Also m...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 217688] Part 5 v5
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 217688: Part 5 v5 - First stab at sorting out inclusion of modules in xpfe and toolkit https://bugzilla.mozilla.org/attachment.cgi?id=217688&action=edit ...

superreview cancelled: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 217688] Part 5 v5
Mark Banner <bugzilla@standard8.demon.co.uk> has cancelled Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 217688: Part 5 v5 - First stab at sorting out inclusion of modules in xpfe and toolkit https://bugzilla.mozilla.org/attachment.cgi?id=217688&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> This has been bitrotted by another checkin. I&...

superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218079] Part 5 v6
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218079: Part 5 v6 - First stab at sorting out inclusion of modules in xpfe and toolkit https://bugzilla.mozilla.org/attachment.cgi?id=218079&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ifndef MOZ_SUITE >+# XXX Suite doesn't want these j...

superreview requested: [Bug 343395] Help buttons not displayed on SeaMonkey when build as an xul application (MOZ_XUL_APP=1) : [Attachment 228615] Patch v3
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 343395: Help buttons not displayed on SeaMonkey when build as an xul application (MOZ_XUL_APP=1) https://bugzilla.mozilla.org/show_bug.cgi?id=343395 Attachment 228615: Patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=228615&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Revised patch fixes missing blank line and also gets the bundle in the js function. ...

superreview requested: [Bug 290518] make cairo build on windows/msvc : [Attachment 180837] patch
Brian Ryner <bryner@brianryner.com> has asked T Rowley (IBM) <tor@acm.org> for superreview: Bug 290518: make cairo build on windows/msvc https://bugzilla.mozilla.org/show_bug.cgi?id=290518 Attachment 180837: patch https://bugzilla.mozilla.org/attachment.cgi?id=180837&action=edit ...

superreview requested: [Bug 290518] make cairo build on windows/msvc : [Attachment 180917] revised patch
Brian Ryner <bryner@brianryner.com> has asked T Rowley (IBM) <tor@acm.org> for superreview: Bug 290518: make cairo build on windows/msvc https://bugzilla.mozilla.org/show_bug.cgi?id=290518 Attachment 180917: revised patch https://bugzilla.mozilla.org/attachment.cgi?id=180917&action=edit ------- Additional Comments from Brian Ryner <bryner@brianryner.com> Changes from the last patch: gfx/cairo/libpixman/src/mozstdint.h: - Changed #defines to typedefs gfx/cairo/cairo/src/Makefile.in: - Added exports for non-win32 platforms - Made quartz surface build...

superreview requested: [Bug 350221] Make suiterunner tabbrowser build on toolkit browser : [Attachment 244214] patch, v3
Alex Vincent <ajvincent@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 350221: Make suiterunner tabbrowser build on toolkit browser https://bugzilla.mozilla.org/show_bug.cgi?id=350221 Attachment 244214: patch, v3 https://bugzilla.mozilla.org/attachment.cgi?id=244214&action=edit ------- Additional Comments from Alex Vincent <ajvincent@gmail.com> asking mconnor to review for the toolkit changes, and Neil for sr. ...

superreview granted: [Bug 343395] Help buttons not displayed on SeaMonkey when build as an xul application (MOZ_XUL_APP=1) : [Attachment 228615] Patch v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 343395: Help buttons not displayed on SeaMonkey when build as an xul application (MOZ_XUL_APP=1) https://bugzilla.mozilla.org/show_bug.cgi?id=343395 Attachment 228615: Patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=228615&action=edit ...

Web resources about - superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219154] Patch for the Windows build v3 - mozilla.dev.super-review

Resources last updated: 12/27/2015 11:32:09 AM