superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218079] Part 5 v6 - First stab at sorting out inclusion of modules in xp

Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 330053: Make SeaMonkey capable of generating a reasonable build with
MOZ_XUL_APP set.
https://bugzilla.mozilla.org/show_bug.cgi?id=330053

Attachment 218079: Part 5 v6 - First stab at sorting out inclusion of modules
in xpfe and toolkit
https://bugzilla.mozilla.org/attachment.cgi?id=218079&action=edit

------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk>
Updated patch to account for bitrot from a checkin earlier today. Also moved
nsUserInfo registering into the ifdefs in nsModule.cpp to resolve a undefined
symbol problem that I hadn't been seeing before :/

Carrying forward benjamin's r, as I don't see that its worth bothering him for
that minor change (the xpfe version of nsUserInfo is part of xpfe startup which
the ifdefs are removing for moz_xul_app=1).
0
bugzilla
4/11/2006 9:03:01 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
398 Views

Similar Articles

[PageSpeed] 17

Reply:

Similar Artilces:

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218593] Make mac build complete
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218593: Make mac build complete https://bugzilla.mozilla.org/attachment.cgi?id=218593&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> This is the pathc to get suiterunner to build on Mac. Some of this is just correcting the Makefile to things we already do in xpfe/bootstrap (the Info.pli...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219154] Patch for the Windows build v3
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219154: Patch for the Windows build v3 https://bugzilla.mozilla.org/attachment.cgi?id=219154&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Removed the ID_DDE_APPLICATION_NAME define since it's not needed in toolkit/ code and so also removed the ifdef change in nsNativeAppSupport...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219055] Patch for the Windows build v2
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219055: Patch for the Windows build v2 https://bugzilla.mozilla.org/attachment.cgi?id=219055&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> For this patch to apply you need to copy mozilla.ico from xpfe/bootstrap/ to suite/branding/icons/windows/. ...

superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218593] Make mac build complete
jag (Peter Annema) <jag@tty.nl> has granted Robert Kaiser <kairo@kairo.at>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218593: Make mac build complete https://bugzilla.mozilla.org/attachment.cgi?id=218593&action=edit ...

superreview cancelled: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219055] Patch for the Windows build v2
Frank Wein <bugzilla@mcsmurf.de> has cancelled Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219055: Patch for the Windows build v2 https://bugzilla.mozilla.org/attachment.cgi?id=219055&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Removed the ID_DDE_APPLICATION_NAME define since it's not needed in toolkit/ code and so also removed the ifdef change in nsNa...

superreview granted: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219154] Patch for the Windows build v3
neil@parkwaycc.co.uk <neil@httl.net> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219154: Patch for the Windows build v3 https://bugzilla.mozilla.org/attachment.cgi?id=219154&action=edit ...

superreview requested: [Bug 255834] port Thunderbird RSS/Atom reader to SeaMonkey : [Attachment 234266] Part 1 for trunk
Ian Neal <iann_bugzilla@arlen.demon.co.uk> has asked Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> for superreview: Bug 255834: port Thunderbird RSS/Atom reader to SeaMonkey https://bugzilla.mozilla.org/show_bug.cgi?id=255834 Attachment 234266: Part 1 for trunk - Start building of feed service as mini module v1.0a https://bugzilla.mozilla.org/attachment.cgi?id=234266&action=edit ...

superreview requested: [Bug 233721] Port of Firefox bug 182928 to Seamonkey (Add confirmation for Set As Wallpaper) : [Attachment 141129] Addressed review comments
timeless@myrealbox.com (working) <timeless@bemail.org> has asked tor@acm.org for superreview: Bug 233721: Port of Firefox bug 182928 to Seamonkey (Add confirmation for Set As Wallpaper) http://bugzilla.mozilla.org/show_bug.cgi?id=233721 Attachment 141129: Addressed review comments http://bugzilla.mozilla.org/attachment.cgi?id=141129&action=edit ...

superreview requested: [Bug 326466] Implement Pythonic generators and iteration protocol support for JS1.7 : [Attachment 224291] coroutine generators, a la Python 2.5, v6
Brendan Eich <brendan@mozilla.org> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 326466: Implement Pythonic generators and iteration protocol support for JS1.7 https://bugzilla.mozilla.org/show_bug.cgi?id=326466 Attachment 224291: coroutine generators, a la Python 2.5, v6 https://bugzilla.mozilla.org/attachment.cgi?id=224291&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> I tried to minimize code for managing rt->gcCloseTable. Let me know if you can think of easy wins, so this can go in soon for more thoro...

superreview requested: [Bug 136773] Investigate enabling ldap:5 on optimized builds. : [Attachment 207740] Allow logging ldap:5 on optimized builds
Mark Banner <bugzilla@standard8.demon.co.uk> has asked Dan Mosedale <dmose@mozilla.org> for superreview: Bug 136773: Investigate enabling ldap:5 on optimized builds. https://bugzilla.mozilla.org/show_bug.cgi?id=136773 Attachment 207740: Allow logging ldap:5 on optimized builds https://bugzilla.mozilla.org/attachment.cgi?id=207740&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> This patch does what i suggested, but removes the InvokeMessageCallback and adds "nsLDAPMessage::GetDn(): dn = 'whatever'" in ...

superreview requested: [Bug 343395] Help buttons not displayed on SeaMonkey when build as an xul application (MOZ_XUL_APP=1) : [Attachment 228615] Patch v3
Mark Banner <bugzilla@standard8.demon.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 343395: Help buttons not displayed on SeaMonkey when build as an xul application (MOZ_XUL_APP=1) https://bugzilla.mozilla.org/show_bug.cgi?id=343395 Attachment 228615: Patch v3 https://bugzilla.mozilla.org/attachment.cgi?id=228615&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Revised patch fixes missing blank line and also gets the bundle in the js function. ...

superreview requested: [Bug 321554] Firefox 1.5.0.1
Chase Phillips <chase@mozilla.org> has asked Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> for superreview: Bug 321554: Firefox 1.5.0.1 - Update build and branch values https://bugzilla.mozilla.org/show_bug.cgi?id=321554 Attachment 207208: Stab, v2 https://bugzilla.mozilla.org/attachment.cgi?id=207208&action=edit ------- Additional Comments from Chase Phillips <chase@mozilla.org> r=chase, assuming we need to bump the Gecko milestone at all. Asking for additional review from bsmedberg. Landing this should happen along with build infrastructur...

superreview requested: [Bug 341173] Need hotkeys to assign label/tag to message
Karsten D´┐Żsterloh <mnyromyr@tprac.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 341173: Need hotkeys to assign label/tag to message - shortcut 0-5 https://bugzilla.mozilla.org/show_bug.cgi?id=341173 Attachment 230371: SeaMonkey patch, v6 https://bugzilla.mozilla.org/attachment.cgi?id=230371&action=edit ...

superreview requested: [Bug 329021] Get non-static builds of mailnews working when MOZ_XUL_APP set : [ Attachment 294736] Add nsAbLDAPDirectoryQuery to AB components
Mark Banner <bugzilla@standard8.plus.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 329021: Get non-static builds of mailnews working when MOZ_XUL_APP set https://bugzilla.mozilla.org/show_bug.cgi?id=329021 Attachment 294736: Add nsAbLDAPDirectoryQuery to AB components https://bugzilla.mozilla.org/attachment.cgi?id=294736&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> Neil commented that with his patch it would build but may not run correctly... I've been playing around and I've just fou...

superreview requested: [Bug 225859] port NSPR to Windows XP / Server 2003 64bit for AMD64 : [Attachment 199357] Public interface and build system changes (for code review only)
Wan-Teh Chang <wtchang@redhat.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 225859: port NSPR to Windows XP / Server 2003 64bit for AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=225859 Attachment 199357: Public interface and build system changes (for code review only) https://bugzilla.mozilla.org/attachment.cgi?id=199357&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> These are the changes to NSPR's exported header files and build system for 64-bit Windows. You are welcome to review the full ...

Web resources about - superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218079] Part 5 v6 - First stab at sorting out inclusion of modules in xp - mozilla.dev.super-review

Resources last updated: 12/19/2015 10:39:20 AM