superreview requested: [Bug 329021] Get non-static builds of mailnews working when MOZ_XUL_APP set : [ Attachment 294736] Add nsAbLDAPDirectoryQuery to AB components

Mark Banner <bugzilla@standard8.plus.com> has asked neil@parkwaycc.co.uk
<neil@httl.net> for superreview:
Bug 329021: Get non-static builds of mailnews working when MOZ_XUL_APP set
https://bugzilla.mozilla.org/show_bug.cgi?id=329021

Attachment 294736: Add nsAbLDAPDirectoryQuery to AB components
https://bugzilla.mozilla.org/attachment.cgi?id=294736&action=edit

------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com>
Neil commented that with his patch it would build but may not run correctly...
I've been playing around and I've just found that nsAbLDAPDirectoryQuery is
missing from nsAbFactory.

Here's the fix.
0
bugzilla
12/28/2007 3:43:14 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
369 Views

Similar Articles

[PageSpeed] 35
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview granted: [Bug 329021] Get non-static builds of mailnews working when MOZ_XUL_APP set : [ Attachment 294736] Add nsAbLDAPDirectoryQuery to AB components
neil@parkwaycc.co.uk <neil@httl.net> has granted Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 329021: Get non-static builds of mailnews working when MOZ_XUL_APP set https://bugzilla.mozilla.org/show_bug.cgi?id=329021 Attachment 294736: Add nsAbLDAPDirectoryQuery to AB components https://bugzilla.mozilla.org/attachment.cgi?id=294736&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> So the rest of attachment 275769 is OK then? ...

superreview requested: [Bug 451903] Build error in mailnews/mime with --enable-debug : [Attachment 335252] add building mailnews/ as a requirement to mime
Karsten D=C3=BCsterloh <mnyromyr@tprac.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 451903: Build error in mailnews/mime with --enable-debug https://bugzilla.mozilla.org/show_bug.cgi?id=3D451903 Attachment 335252: add building mailnews/ as a requirement to mime https://bugzilla.mozilla.org/attachment.cgi?id=3D335252&action=3Dedit ------- Additional Comments from Karsten D=C3=BCsterloh <mnyromyr@tprac.de> This makes /mime build again in my debug build. Since I don't do non-debug builds but IanN does, letting him have a look as wel...

superreview requested: [Bug 318018] [BEOS] Thunderbird static build fails : [Attachment 204358] adds required libs to mail Makefile.in for static builds
Sergei Dolgov <sergei_d@fi.tartu.ee> has asked Benjamin Smedberg [:bs] (bsmedberg) <benjamin@smedbergs.us> for superreview: Bug 318018: [BEOS] Thunderbird static build fails https://bugzilla.mozilla.org/show_bug.cgi?id=318018 Attachment 204358: adds required libs to mail Makefile.in for static builds https://bugzilla.mozilla.org/attachment.cgi?id=204358&action=edit ------- Additional Comments from Sergei Dolgov <sergei_d@fi.tartu.ee> additional review request ...

superreview requested: [Bug 285653] add reporter tool to nightly builds : [Attachment 177084] patch to get reporter working in nightlies
Jay Patel <jay@mozilla.org> has asked Brian Ryner (IBM) <bryner@brianryner.com> for superreview: Bug 285653: add reporter tool to nightly builds https://bugzilla.mozilla.org/show_bug.cgi?id=285653 Attachment 177084: patch to get reporter working in nightlies https://bugzilla.mozilla.org/attachment.cgi?id=177084&action=edit ------- Additional Comments from Jay Patel <jay@mozilla.org> The changes from my original comment have been made and I was able to run my build and see the reporter item in the help menu. I could not get the id from the server, so we might...

superreview requested: [Bug 425077] Migrate mail/components to frozen linkage for non-static linux builds : [Attachment 311659] The fix
Mark Banner <bugzilla@standard8.plus.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 425077: Migrate mail/components to frozen linkage for non-static linux builds https://bugzilla.mozilla.org/show_bug.cgi?id=425077 Attachment 311659: The fix https://bugzilla.mozilla.org/attachment.cgi?id=311659&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> As part of the ongoing effort to move Thunderbird onto libxul, I've migrated mail/components to frozen linkage. This patch will only migrate non-sta...

superreview requested: [Bug 208190] work on removing |aPresContext| parameters : [Attachment 127579] add frame manager accessors, clean up nsIFrame::(Get|Set)View
David Baron <dbaron@dbaron.org> has asked Robert O'Callahan <roc+moz@cs.cmu.edu> for superreview: Bug 208190: work on removing |aPresContext| parameters http://bugzilla.mozilla.org/show_bug.cgi?id=208190 Attachment 127579: add frame manager accessors, clean up nsIFrame::(Get|Set)View http://bugzilla.mozilla.org/attachment.cgi?id=127579&action=edit ...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219154] Patch for the Windows build v3
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219154: Patch for the Windows build v3 https://bugzilla.mozilla.org/attachment.cgi?id=219154&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> Removed the ID_DDE_APPLICATION_NAME define since it's not needed in toolkit/ code and so also removed the ifdef change in nsNativeAppSupport...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 218593] Make mac build complete
Robert Kaiser <kairo@kairo.at> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 218593: Make mac build complete https://bugzilla.mozilla.org/attachment.cgi?id=218593&action=edit ------- Additional Comments from Robert Kaiser <kairo@kairo.at> This is the pathc to get suiterunner to build on Mac. Some of this is just correcting the Makefile to things we already do in xpfe/bootstrap (the Info.pli...

superreview requested: [Bug 330053] Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. : [Attachment 219055] Patch for the Windows build v2
Frank Wein <bugzilla@mcsmurf.de> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 330053: Make SeaMonkey capable of generating a reasonable build with MOZ_XUL_APP set. https://bugzilla.mozilla.org/show_bug.cgi?id=330053 Attachment 219055: Patch for the Windows build v2 https://bugzilla.mozilla.org/attachment.cgi?id=219055&action=edit ------- Additional Comments from Frank Wein <bugzilla@mcsmurf.de> For this patch to apply you need to copy mozilla.ico from xpfe/bootstrap/ to suite/branding/icons/windows/. ...

superreview requested: [Bug 233721] Port of Firefox bug 182928 to Seamonkey (Add confirmation for Set As Wallpaper) : [Attachment 141129] Addressed review comments
timeless@myrealbox.com (working) <timeless@bemail.org> has asked tor@acm.org for superreview: Bug 233721: Port of Firefox bug 182928 to Seamonkey (Add confirmation for Set As Wallpaper) http://bugzilla.mozilla.org/show_bug.cgi?id=233721 Attachment 141129: Addressed review comments http://bugzilla.mozilla.org/attachment.cgi?id=141129&action=edit ...

superreview requested: [Bug 339414] os2Embed does not link with static MOZ_XUL_APP : [Attachment 223533] Fix build break (and don't normally build os2Embed)
Peter Weilbacher <mozilla@Weilbacher.org> has asked Michael Kaply (IBM) (mkaply) <mozilla@kaply.com> for superreview: Bug 339414: os2Embed does not link with static MOZ_XUL_APP https://bugzilla.mozilla.org/show_bug.cgi?id=339414 Attachment 223533: Fix build break (and don't normally build os2Embed) https://bugzilla.mozilla.org/attachment.cgi?id=223533&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> This fixes building of os2Embed. The check for WINNT in the os2Embed Makefile should not be needed. I also think it is...

superreview requested: [Bug 54828] Build should default to non-debug/optimized build. : [Attachment 146531] Build moz optimized & non-debug by default
Chris Seawood <cls@seawood.org> has asked Daniel (Leaf) Nunes <leaf@mozilla.org> for superreview: Bug 54828: Build should default to non-debug/optimized build. http://bugzilla.mozilla.org/show_bug.cgi?id=54828 Attachment 146531: Build moz optimized & non-debug by default http://bugzilla.mozilla.org/attachment.cgi?id=146531&action=edit ...

superreview requested: [Bug 322628] Palm Sync Build Changes to automate build and install in profile extensions : [Attachment 320988] Add MB_TOPMOST to MessageBox to prevent install dialog getting hid
Wayne Mery (:wsmwk) <vseerror@lehigh.edu> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 322628: Palm Sync Build Changes to automate build and install in profile extensions https://bugzilla.mozilla.org/show_bug.cgi?id=3D322628 Attachment 320988: Add MB_TOPMOST to MessageBox to prevent install dialog getting hidden https://bugzilla.mozilla.org/attachment.cgi?id=3D320988&action=3Dedit ------- Additional Comments from Wayne Mery (:wsmwk) <vseerror@lehigh.edu> Previous patch attachment 291942 never made it to branch or trunk afaik. We wil...

superreview requested: [Bug 90918] RFE: Add url in "comments" field of the "get info" window when download file. : [Attachment 180129] Cleaned up patch, moving review requests
Torben <torben@despammed.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 90918: RFE: Add url in "comments" field of the "get info" window when download file. https://bugzilla.mozilla.org/show_bug.cgi?id=90918 Attachment 180129: Cleaned up patch, moving review requests https://bugzilla.mozilla.org/attachment.cgi?id=180129&action=edit ...

Web resources about - superreview requested: [Bug 329021] Get non-static builds of mailnews working when MOZ_XUL_APP set : [ Attachment 294736] Add nsAbLDAPDirectoryQuery to AB components - mozilla.dev.super-review

Resources last updated: 1/6/2016 5:34:39 AM