superreview requested: [Bug 310395] Open Link in New Window - new background windows open with Address bar focused : [Attachment 227974] Unbitrots it

froodiantherapy <stridey@gmail.com> has asked Mike Pinkerton
<mikepinkerton@mac.com> for superreview:
Bug 310395: Open Link in New Window - new background windows open with Address
bar focused
https://bugzilla.mozilla.org/show_bug.cgi?id=310395

Attachment 227974: Unbitrots it
https://bugzilla.mozilla.org/attachment.cgi?id=227974&action=edit

------- Additional Comments from froodiantherapy <stridey@gmail.com>
This patch unbitrots the previous one.	It touches all the high-traffic files,
and took a long time to get back up to date, so lets try to get this reviewed
and landed as quickly as possible. :)
0
bugzilla
7/3/2006 8:57:10 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
985 Views

Similar Articles

[PageSpeed] 55
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 410391] Clicking on the status-bar security button does not focus on the security tab in the pageinfo window : [Attachment 295010] Open the PageInfo window with the correc
Philip Chee <philip.chee@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 410391: Clicking on the status-bar security button does not focus on the security tab in the pageinfo window https://bugzilla.mozilla.org/show_bug.cgi?id=410391 Attachment 295010: Open the PageInfo window with the correct tab selected. https://bugzilla.mozilla.org/attachment.cgi?id=295010&action=edit ------- Additional Comments from Philip Chee <philip.chee@gmail.com> Steps to reproduce: 1. Navigate to any page. 2. Click on the security button in the statu...

superreview requested: [Bug 410391] Clicking on the status-bar security button does not focus on the security tab in the pageinfo window : [Attachment 295015] V1. 2 Open the PageInfo window with the c
Philip Chee <philip.chee@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 410391: Clicking on the status-bar security button does not focus on the security tab in the pageinfo window https://bugzilla.mozilla.org/show_bug.cgi?id=410391 Attachment 295015: V1.2 Open the PageInfo window with the correct tab selected (fix nits) https://bugzilla.mozilla.org/attachment.cgi?id=295015&action=edit ------- Additional Comments from Philip Chee <philip.chee@gmail.com> Fix Neil's nits. ...

superreview requested: [Bug 410391] Clicking on the status-bar security button does not focus on the security tab in the pageinfo window : [Attachment 295012] V1. 1 Open the PageInfo window with the c
Philip Chee <philip.chee@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 410391: Clicking on the status-bar security button does not focus on the security tab in the pageinfo window https://bugzilla.mozilla.org/show_bug.cgi?id=410391 Attachment 295012: V1.1 Open the PageInfo window with the correct tab selected. https://bugzilla.mozilla.org/attachment.cgi?id=295012&action=edit ------- Additional Comments from Philip Chee <philip.chee@gmail.com> Neil on #IRC agrees that the .focus() isn't necessary. ...

superreview requested: [Bug 103638] targets with same name in different windows open in wrong window with javascript : [Attachment 170288] Proposed fix, bz's fix with window.open() etc fixed.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 103638: targets with same name in different windows open in wrong window with javascript https://bugzilla.mozilla.org/show_bug.cgi?id=103638 Attachment 170288: Proposed fix, bz's fix with window.open() etc fixed. https://bugzilla.mozilla.org/attachment.cgi?id=170288&action=edit ...

superreview requested: [Bug 241212] Message window for .EML file needs envelope panel : [Attachment 193489] enable opening of attachments from .eml files opened in stand-along window
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 241212: Message window for .EML file needs envelope panel https://bugzilla.mozilla.org/show_bug.cgi?id=241212 Attachment 193489: enable opening of attachments from .eml files opened in stand-along window https://bugzilla.mozilla.org/attachment.cgi?id=193489&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> use url instead of message uri. ...

superreview requested: [Bug 297541] Using window.open to open a window at (0,0) does not work : [Attachment 186289] fix?
Robert O'Callahan (Novell) <roc@ocallahan.org> has asked Christopher Blizzard <blizzard@mozilla.org> for superreview: Bug 297541: Using window.open to open a window at (0,0) does not work https://bugzilla.mozilla.org/show_bug.cgi?id=297541 Attachment 186289: fix? https://bugzilla.mozilla.org/attachment.cgi?id=186289&action=edit ...

superreview requested: [Bug 25287] Inappropriate menu items show as enabled when no windows are open : [Attachment 245032] Fix the major issues (when no windows are open)
Stefan <stefanh@bluebottle.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 25287: Inappropriate menu items show as enabled when no windows are open https://bugzilla.mozilla.org/show_bug.cgi?id=25287 Attachment 245032: Fix the major issues (when no windows are open) https://bugzilla.mozilla.org/attachment.cgi?id=245032&action=edit ------- Additional Comments from Stefan <stefanh@bluebottle.com> This patch will also fix bug 114967, bug 83253 and parts of bug 130891. It will: 1) Disable inappropiate menuitems when all windows are clo...

superreview requested: [Bug 235457] blocked popup window opened from menu circumvents content restrictions : [Attachment 149235] Make URI security check in window.open() behave too
Johnny Stenback <jst@mozilla.jstenback.com> has asked Peter Van der Beken <peterv@propagandism.org> for superreview: Bug 235457: blocked popup window opened from menu circumvents content restrictions http://bugzilla.mozilla.org/show_bug.cgi?id=235457 Attachment 149235: Make URI security check in window.open() behave too http://bugzilla.mozilla.org/attachment.cgi?id=149235&action=edit ...

superreview requested: [Bug 293778] [FIX]bookmarks toolbar missing in 2nd opened window, links in second window possibly cause crash : [Attachment 183470] Fix
Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 293778: [FIX]bookmarks toolbar missing in 2nd opened window, links in second window possibly cause crash https://bugzilla.mozilla.org/show_bug.cgi?id=293778 Attachment 183470: Fix https://bugzilla.mozilla.org/attachment.cgi?id=183470&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> jst, the long comment should pretty much explain what's going on. I went for this instead of trying to make LoadBindings deal with being reentered bec...

superreview canceled: [Bug 410391] Clicking on the status-bar security button does not focus on the security tab in the pageinfo window : [Attachment 295010] Open the PageInfo window with the correct
Philip Chee <philip.chee@gmail.com> has canceled Philip Chee <philip.chee@gmail.com>'s request for superreview: Bug 410391: Clicking on the status-bar security button does not focus on the security tab in the pageinfo window https://bugzilla.mozilla.org/show_bug.cgi?id=410391 Attachment 295010: Open the PageInfo window with the correct tab selected. https://bugzilla.mozilla.org/attachment.cgi?id=295010&action=edit ------- Additional Comments from Philip Chee <philip.chee@gmail.com> Neil on #IRC agrees that the .focus() isn't necessary. ...

superreview granted: [Bug 410391] Clicking on the status-bar security button does not focus on the security tab in the pageinfo window : [Attachment 295010] Open the PageInfo window with the correct
neil@parkwaycc.co.uk <neil@httl.net> has granted superreview: Bug 410391: Clicking on the status-bar security button does not focus on the security tab in the pageinfo window https://bugzilla.mozilla.org/show_bug.cgi?id=410391 Attachment 295010: Open the PageInfo window with the correct tab selected. https://bugzilla.mozilla.org/attachment.cgi?id=295010&action=edit ...

superreview requested: [Bug 232933] javascript window.open('file or bookmark', '_self') does nothing.. : [Attachment 140810] popup blocker once again tolerates window.open targeted to _self, _top et.
Dan M <danm-moz@comcast.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 232933: javascript window.open('file or bookmark', '_self') does nothing.. http://bugzilla.mozilla.org/show_bug.cgi?id=232933 Attachment 140810: popup blocker once again tolerates window.open targeted to _self, _top et.al. http://bugzilla.mozilla.org/attachment.cgi?id=140810&action=edit ...

superreview denied: [Bug 410391] Clicking on the status-bar security button does not focus on the security tab in the pageinfo window : [Attachment 295012] V1. 1 Open the PageInfo window with the cor
neil@parkwaycc.co.uk <neil@httl.net> has denied Philip Chee <philip.chee@gmail.com>'s request for superreview: Bug 410391: Clicking on the status-bar security button does not focus on the security tab in the pageinfo window https://bugzilla.mozilla.org/show_bug.cgi?id=410391 Attachment 295012: V1.1 Open the PageInfo window with the correct tab selected. https://bugzilla.mozilla.org/attachment.cgi?id=295012&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Sorry, but it turns out that I prefer the focus behaviour of attachmen...

superreview denied: [Bug 410391] Clicking on the status-bar security button does not focus on the security tab in the pageinfo window : [Attachment 295015] V1. 2 Open the PageInfo window with the cor
neil@parkwaycc.co.uk <neil@httl.net> has denied Philip Chee <philip.chee@gmail.com>'s request for superreview: Bug 410391: Clicking on the status-bar security button does not focus on the security tab in the pageinfo window https://bugzilla.mozilla.org/show_bug.cgi?id=410391 Attachment 295015: V1.2 Open the PageInfo window with the correct tab selected (fix nits) https://bugzilla.mozilla.org/attachment.cgi?id=295015&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Bah, he gives me a good reason, then ignores it... ...

superreview granted: [Bug 410391] Clicking on the status-bar security button does not focus on the security tab in the pageinfo window : [Attachment 295015] V1. 2 Open the PageInfo window with the cor
neil@parkwaycc.co.uk <neil@httl.net> has granted superreview: Bug 410391: Clicking on the status-bar security button does not focus on the security tab in the pageinfo window https://bugzilla.mozilla.org/show_bug.cgi?id=410391 Attachment 295015: V1.2 Open the PageInfo window with the correct tab selected (fix nits) https://bugzilla.mozilla.org/attachment.cgi?id=295015&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> I guess you can do it this way too if you insist. ...

Web resources about - superreview requested: [Bug 310395] Open Link in New Window - new background windows open with Address bar focused : [Attachment 227974] Unbitrots it - mozilla.dev.super-review

Resources last updated: 11/20/2015 10:26:18 PM