superreview requested: [Bug 299372] Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save #3

Dan Mosedale <dmose@mozilla.org> has asked Christian :Biesinger
<cbiesinger@gmx.at> for superreview:
Bug 299372: Content-Disposition headers no longer looked at for Save Link As
filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of
the attachment; Save Page As works fine
https://bugzilla.mozilla.org/show_bug.cgi?id=299372

Attachment 293766: "Save Link As..." patch, v1
https://bugzilla.mozilla.org/attachment.cgi?id=293766&action=edit

------- Additional Comments from Dan Mosedale <dmose@mozilla.org>
This patch changes "Save Link As..." to always use the external helper app
service, which means that the filename always comes from the same GET used to
download the file.

The also means that, for HTTP links, once network.http.max-connections
(currently defaulted to 2) for the site in question is hit, any subsequent
downloads will queue invisibly until a connection frees up, after which the
file picker may open (depending on pref; the pref is now attended to, unlike
the old code path).

There are a number of related bugs to be spun off, 

* bump network.http.max-connections to 8.  This is likely to also help Tp, and
will make the silent queuing much more of an edge case.  Should do this for
Firefox 3.

* allow dl manager to accept incomplete nsITransfers and pass one in.  This
will give instant UI feedback for queued transfers in the download manager,
making them no longer silent.

* give the user some UI frob to abort waiting for the filename, if we think
it's possible to design meaningful UI for this.  IE has a dialog for this case,
and it solves the "I want to start 9 downloads with 'Save Link As' and go to
lunch." case.

* change "Save As..." to "Save" in the case where that pref is set (already
filed).

I'll file and/or link to the remaining bugs here.

mconnor, can you r the toolkit/browser changes?

biesi, can you r/sr the very minimal uriloader changes?
0
bugzilla
12/18/2007 11:49:27 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
761 Views

Similar Articles

[PageSpeed] 4
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview requested: [Bug 299372] Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save #2
Dan Mosedale <dmose@mozilla.org> has asked Christian :Biesinger <cbiesinger@gmx.at> for superreview: Bug 299372: Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save Page As works fine https://bugzilla.mozilla.org/show_bug.cgi?id=299372 Attachment 305240: "Save Link As..." patch, v4 https://bugzilla.mozilla.org/attachment.cgi?id=305240&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> Updated to be pref...

superreview granted: [Bug 299372] Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save Pa #3
Dan Mosedale <dmose@mozilla.org> has granted superreview: Bug 299372: Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save Page As works fine https://bugzilla.mozilla.org/show_bug.cgi?id=299372 Attachment 305659: "Save Link As..." patch, v5 https://bugzilla.mozilla.org/attachment.cgi?id=305659&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> Addresses the issues biesi found; carrying forward sr. ...

superreview canceled: [Bug 299372] Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save P
Dan Mosedale <dmose@mozilla.org> has canceled Dan Mosedale <dmose@mozilla.org>'s request for superreview: Bug 299372: Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save Page As works fine https://bugzilla.mozilla.org/show_bug.cgi?id=299372 Attachment 304357: "Save Link As..." patch, v3 https://bugzilla.mozilla.org/attachment.cgi?id=304357&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> Updated t...

superreview granted: [Bug 299372] Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save Pa #2
Christian :Biesinger <cbiesinger@gmx.at> has granted Dan Mosedale <dmose@mozilla.org>'s request for superreview: Bug 299372: Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name = of the attachment; Save Page As works fine https://bugzilla.mozilla.org/show_bug.cgi?id=3D299372 Attachment 305240: "Save Link As..." patch, v4 https://bugzilla.mozilla.org/attachment.cgi?id=3D305240&action=3Dedit ------- Additional Comments from Christian :Biesinger <cbiesing...

superreview granted: [Bug 299372] Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save Pa #4
Christian :Biesinger <cbiesinger@gmx.at> has granted Dan Mosedale <dmose@mozilla.org>'s request for superreview: Bug 299372: Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save Page As works fine https://bugzilla.mozilla.org/show_bug.cgi?id=299372 Attachment 293766: "Save Link As..." patch, v1 https://bugzilla.mozilla.org/attachment.cgi?id=293766&action=edit ...

superreview granted: [Bug 299372] Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save Pa #5
Dan Mosedale <dmose@mozilla.org> has granted superreview: Bug 299372: Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save Page As works fine https://bugzilla.mozilla.org/show_bug.cgi?id=299372 Attachment 294545: "Save Link As..." patch, v2 https://bugzilla.mozilla.org/attachment.cgi?id=294545&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> Patch v2; all comments addressed _except_ that I'm still using ...

superreview requested: [Bug 416063] "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) : [Attachment 304041] fix
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> for superreview: Bug 416063: "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) https://bugzilla.mozilla.org/show_bug.cgi?id=416063 Attachment 304041: fix https://bugzilla.mozilla.org/attachment.cgi?id=304041&action=edit ...

superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 206229] Patch #3
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 206229: Patch rv2.0 https://bugzilla.mozilla.org/attachment.cgi?id=206229&action=edit ...

superreview granted: [Bug 416063] "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) : [Attachment 304041] fix
Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> has granted Stuart Morgan <stuart.morgan@alumni.case.edu>'s request for superreview: Bug 416063: "Save this password?" dialog has "Never Save" focused instead of "Don't Save" with FKA on (again!) https://bugzilla.mozilla.org/show_bug.cgi?id=416063 Attachment 304041: fix https://bugzilla.mozilla.org/attachment.cgi?id=304041&action=edit ------- Additional Comments from Mike Pinkerton (not reading bugmail) <mikepinkerton@mac.com> sr=pink ...

superreview requested: [Bug 216479] when saving drafts and templates, we don't save the "return receipts" and "attach vcard" info : [ Attachment 295016] proposed fix
Magnus Melin <mkmelin+mozilla@iki.fi> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 216479: when saving drafts and templates, we don't save the "return receipts" and "attach vcard" info https://bugzilla.mozilla.org/show_bug.cgi?id=216479 Attachment 295016: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=295016&action=edit ------- Additional Comments from Magnus Melin <mkmelin+mozilla@iki.fi> Everything else is in place, it's just that the parsed values were always overridden by the identity prefs...

superreview requested: [Bug 242953] an Imported eudora attached file is always named "Attached File" instead of its real name : [Attachment 153467] set the attachment name as the leaf name of the fil
Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 242953: an Imported eudora attached file is always named "Attached File" instead of its real name http://bugzilla.mozilla.org/show_bug.cgi?id=242953 Attachment 153467: set the attachment name as the leaf name of the file http://bugzilla.mozilla.org/attachment.cgi?id=153467&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> I've given up on trying to get the whitespace to work in these import files. They were a...

superreview requested: [Bug 259454] IME input (e.g., Chinese, Japanese and Korean) cannot be performed in Find Toolbar when opened with "/" or "'" : [Attachment 185290] Patch rv4.3 (content/)
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked David Baron (traveling May 23-June 9) <dbaron@mozillafoundation.org> for superreview: Bug 259454: IME input (e.g., Chinese, Japanese and Korean) cannot be performed in Find Toolbar when opened with "/" or "'" https://bugzilla.mozilla.org/show_bug.cgi?id=259454 Attachment 185290: Patch rv4.3 (content/) https://bugzilla.mozilla.org/attachment.cgi?id=185290&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> O.K. I removed th...

superreview requested: [Bug 264757] "Save Image as" does not respect either MIME type or content-disposition : [Attachment 179546] Proposed patch, using pav's new API
Boris Zbarsky <bzbarsky@mit.edu> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 264757: "Save Image as" does not respect either MIME type or content-disposition https://bugzilla.mozilla.org/show_bug.cgi?id=264757 Attachment 179546: Proposed patch, using pav's new API https://bugzilla.mozilla.org/attachment.cgi?id=179546&action=edit ...

superreview requested: [Bug 314231] If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." : [Attachment 201159] Patch
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 314231: If link target URL has non-ASCII char that is not encoded by UTF-8, the default file name is always escaped at "Save Link Target As..." https://bugzilla.mozilla.org/show_bug.cgi?id=314231 Attachment 201159: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=201159&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> This fix this bug. aDocum...

Web resources about - superreview requested: [Bug 299372] Content-Disposition headers no longer looked at for Save Link As filename, so it uses e.g. "attachment.cgi" in bugzilla instead of the name of the attachment; Save #3 - mozilla.dev.super-review

Resources last updated: 1/2/2016 10:09:38 PM