superreview requested: [Bug 184614] valgrind doesn't like nsDiskCacheBlockFile::WriteBlocks (uninitialized memory written to cache) : [Attachment 222617] V4: Moved back the declaration of 'fileSize' t

Alfred Kayser <alfredkayser@nl.ibm.com> has asked Darin Fisher (Google)
<darin@meer.net> for superreview:
Bug 184614: valgrind doesn't like nsDiskCacheBlockFile::WriteBlocks
(uninitialized memory written to cache)
https://bugzilla.mozilla.org/show_bug.cgi?id=184614

Attachment 222617: V4: Moved back the declaration of 'fileSize' to the top
https://bugzilla.mozilla.org/attachment.cgi?id=222617&action=edit

------- Additional Comments from Alfred Kayser <alfredkayser@nl.ibm.com>
Darin, can you do the SR, or must someelse (who?) do this?
0
bugzilla
5/19/2006 12:32:14 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
683 Views

Similar Articles

[PageSpeed] 24
Get it on Google Play
Get it on Apple App Store

Reply:

Similar Artilces:

superreview granted: [Bug 184614] valgrind doesn't like nsDiskCacheBlockFile::WriteBlocks (uninitialized memory written to cache) : [Attachment 222617] V4: Moved back the declaration of 'fileSize' to
Darin Fisher (Google) <darin@meer.net> has granted Alfred Kayser <alfredkayser@nl.ibm.com>'s request for superreview: Bug 184614: valgrind doesn't like nsDiskCacheBlockFile::WriteBlocks (uninitialized memory written to cache) https://bugzilla.mozilla.org/show_bug.cgi?id=184614 Attachment 222617: V4: Moved back the declaration of 'fileSize' to the top https://bugzilla.mozilla.org/attachment.cgi?id=222617&action=edit ------- Additional Comments from Darin Fisher (Google) <darin@meer.net> >Index: nsDiskCacheBlockFile.cpp > nsDiskCacheBloc...

superreview requested: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if
Johnny Stenback <jst@mozilla.jstenback.com> has asked Brendan Eich <brendan@mozilla.org> for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ...

superreview granted: [Bug 404773] Find bar doesn't like the letters 'b', 'o ', 'd', 'y', and 'random'
Johnny Stenback (:jst) <jst@mozilla.org> has granted Dave Townsend (Mossop) <dtownsend@mozilla.com>'s request for superreview: Bug 404773: Find bar doesn't like the letters 'b', 'o', 'd', 'y', and 'random' https://bugzilla.mozilla.org/show_bug.cgi?id=404773 Attachment 291924: patch rev 1 https://bugzilla.mozilla.org/attachment.cgi?id=291924&action=edit ------- Additional Comments from Johnny Stenback (:jst) <jst@mozilla.org> Nice :) r+sr=jst ...

superreview requested: [Bug 122238] input type="image" doesn't send x/y (image doesn't exist; width and height not set) : [Attachment 139545] Same as jkeiser's patch, really...
Boris Zbarsky <bz-vacation@mit.edu> has asked Johnny Stenback <jst@mozilla.jstenback.com> for superreview: Bug 122238: input type="image" doesn't send x/y (image doesn't exist; width and height not set) http://bugzilla.mozilla.org/show_bug.cgi?id=122238 Attachment 139545: Same as jkeiser's patch, really... http://bugzilla.mozilla.org/attachment.cgi?id=139545&action=edit ...

superreview requested: [Bug 40680] OBJECT attribute 'codebase' doesn't affect relative 'data' URI : [Attachment 177518] 40680-1.diff
Daniel Brooks <db48x@yahoo.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 40680: OBJECT attribute 'codebase' doesn't affect relative 'data' URI https://bugzilla.mozilla.org/show_bug.cgi?id=40680 Attachment 177518: 40680-1.diff https://bugzilla.mozilla.org/attachment.cgi?id=177518&action=edit ------- Additional Comments from Daniel Brooks <db48x@yahoo.com> that should fix it ...

superreview granted: [Bug 245619] Don't bother converting result of scripts into a string when the caller doesn't care about the value. : [Attachment 150056] Don't convert the result to a string if t
Brendan Eich <brendan@mozilla.org> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 245619: Don't bother converting result of scripts into a string when the caller doesn't care about the value. http://bugzilla.mozilla.org/show_bug.cgi?id=245619 Attachment 150056: Don't convert the result to a string if the caller doesn't care about the return value. http://bugzilla.mozilla.org/attachment.cgi?id=150056&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Duh, thanks. r+sr=me....

superreview requested: [Bug 269318] TAB doesn't start from selection text after mouse click : [Attachment 166255] If element gets focused, move selection to focus if focus isn't already inside the s
Aaron Leventhal <aaronleventhal@moonset.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> for superreview: Bug 269318: TAB doesn't start from selection text after mouse click https://bugzilla.mozilla.org/show_bug.cgi?id=269318 Attachment 166255: If element gets focused, move selection to focus if focus isn't already inside the selection. mLastFocusedWith is no longer needed for making tab not move relative to selection after a mouse click https://bugzilla.mozilla.org/attachment.cgi?id=166255&action=edit ...

superreview requested: [Bug 280713] ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly : [Attachment 173997] updated to review comments
Blake Kaplan <mrbkap@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 280713: ContinueInterruptedParsing doesn't set the current context's scanner's mIncremental member correctly https://bugzilla.mozilla.org/show_bug.cgi?id=280713 Attachment 173997: updated to review comments https://bugzilla.mozilla.org/attachment.cgi?id=173997&action=edit ...

superreview requested: [Bug 232129] imap protocol logging doesn't handle long lines : [Attachment 139853] fix that doesn't add newlines
David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 232129: imap protocol logging doesn't handle long lines http://bugzilla.mozilla.org/show_bug.cgi?id=232129 Attachment 139853: fix that doesn't add newlines http://bugzilla.mozilla.org/attachment.cgi?id=139853&action=edit ...

superreview requested: [Bug 87513] about:<randomness> doesn't display a default page, if the about: topic doesn't exist. : [Attachment 195365] Simple fix
Boris Zbarsky <bzbarsky@mit.edu> has asked Darin Fisher <darin@meer.net> for superreview: Bug 87513: about:<randomness> doesn't display a default page, if the about: topic doesn't exist. https://bugzilla.mozilla.org/show_bug.cgi?id=87513 Attachment 195365: Simple fix https://bugzilla.mozilla.org/attachment.cgi?id=195365&action=edit ...

superreview requested: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has asked David Baron [:dbaron] <dbaron@mozilla.com> for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=3D93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=3D323226&action=3Dedit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> This proved to be pretty simple to fix, with some caveats. The attached pa= tch passes Hixie's test linke...

superreview requested: [Bug 217896] ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape : [Attachment 130691] don't do silly things that don't make sense
timeless@myrealbox.com <timeless@bemail.org> has asked Johnny Stenback <jst@netscape.com> for superreview: Bug 217896: ASSERTION: nsMemoryImpl::Alloc of 0: 'size' in GlobalWindowImpl::Unescape http://bugzilla.mozilla.org/show_bug.cgi?id=217896 Attachment 130691: don't do silly things that don't make sense http://bugzilla.mozilla.org/attachment.cgi?id=130691&action=edit ...

superreview requested: [Bug 264442] plugin finder can't find anything for windows media. : [Attachment 162212] Don't assume we don't have a plugin before getting a responce from the network.
Johnny Stenback <jst@mozilla.jstenback.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 264442: plugin finder can't find anything for windows media. https://bugzilla.mozilla.org/show_bug.cgi?id=264442 Attachment 162212: Don't assume we don't have a plugin before getting a responce from the network. https://bugzilla.mozilla.org/attachment.cgi?id=162212&action=edit ...

superreview requested: [Bug 404773] Find bar doesn't like the letter 'o'
Dave Townsend (Mossop) <dtownsend@mozilla.com> has asked Johnny Stenback (:jst) <jst@mozilla.org> for superreview: Bug 404773: Find bar doesn't like the letter 'o' https://bugzilla.mozilla.org/show_bug.cgi?id=404773 Attachment 291924: patch rev 1 https://bugzilla.mozilla.org/attachment.cgi?id=291924&action=edit ------- Additional Comments from Dave Townsend (Mossop) <dtownsend@mozilla.com> Turns out unterminated strings are a bad thing. The call to StripChars was getting the soft hyphen, plus whatever characters following the array in memory til...

Web resources about - superreview requested: [Bug 184614] valgrind doesn't like nsDiskCacheBlockFile::WriteBlocks (uninitialized memory written to cache) : [Attachment 222617] V4: Moved back the declaration of 'fileSize' t - mozilla.dev.super-review

Resources last updated: 12/17/2015 11:49:35 AM