superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236342] update

Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang
<wtchang@redhat.com> for superreview:
Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just
using /dev/urandom
https://bugzilla.mozilla.org/show_bug.cgi?id=182758

Attachment 236342: update
https://bugzilla.mozilla.org/attachment.cgi?id=236342&action=edit

------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com>
This patch contains several changes :
1) More comments
2) CollectEntropy and RNG_kstat are both changed to return a SECStatus . This
is to ease future work in bug 350798 to check for success
3) CollectEntropy has an extra PRUint32 *total_fed argument which gets
incremented
4) RNG_kstat has an extra PRUInt32* fed argument to return the number of bytes
of entropy that it generated and fed to the RNG
5) CollectEntropy now only feeds data to the RNG if the buffer is full, and
will never pass a zero length to RNG_RandomUpdate
6) CollectEntropy local variable buffered renamed to processed
7) CollectEntropy argument entropy_collected renamed to entropy_buffered. Same
for RNG_kstat local
0
bugzilla
9/1/2006 12:47:16 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
697 Views

Similar Articles

[PageSpeed] 57
Get it on Google Play
Get it on Apple App Store

Reply:

Web resources about - superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236342] update - mozilla.dev.super-review

Resources last updated: 3/6/2016 11:31:34 PM