superreview requested: [Bug 115951] freebl dynamic library is never unloaded by libsoftoken or libssl. Also tiny one-time leak in freebl's loader.c : [Attachment 239727] Incorporate Wan-Teh's feedback

Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang
<wtchang@redhat.com> for superreview:
Bug 115951: freebl dynamic library is never unloaded by libsoftoken or libssl.
Also tiny one-time leak in freebl's loader.c
https://bugzilla.mozilla.org/show_bug.cgi?id=115951

Attachment 239727: Incorporate Wan-Teh's feedback
https://bugzilla.mozilla.org/attachment.cgi?id=239727&action=edit

------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com>
1) This patch no longer has the freebl init callback mechanism that the
previous one did.
2) I cleaned up the unnecessary wrapper functions in loader.c
3) I added some error checking for the new functions in ssl, which are now in
sslsock.c and invoked only when SSL_OptionSet(sock, SSL_BYPASS_PKCS11, PR_TRUE)
or SSL_OptionSetDefault(SSL_BYPASS_PKCS11, PR_TRUE) are called . If servers are
using the model socket option with SSL_OptionSet, SSL_BypassSetup should be a
one-time call only .
0
bugzilla
9/22/2006 10:47:20 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
580 Views

Similar Articles

[PageSpeed] 8
Get it on Google Play
Get it on Apple App Store

Reply: