superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313971] Label disabling patch v1.1a
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313971: Label disabling patch v1.1a https://bugzilla.mozilla.org/attachment.cgi?id=313971&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Changes since v1.1: * Labels now have the same disabled status as their associated colorpicker. ...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312933] Disable and lock checking patch v1.0
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312933: Disable and lock checking patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=312933&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> This patch: * Disables the color pickers when system colors box is checked as long as picker pref is not locked. * Re-enables the col...

superreview denied: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312934] Disable and lock checking patch v1.0a
neil@parkwaycc.co.uk <neil@httl.net> has denied Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=3D79603 Attachment 312934: Disable and lock checking patch v1.0a https://bugzilla.mozilla.org/attachment.cgi?id=3D312934&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Unfortunately disabling colourpickers doesn't work correctly - the binding simply makes a bold claim that it's...

superreview canceled: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312933] Disable and lock checking patch v1.0
Ian Neal <iann_bugzilla@blueyonder.co.uk> has canceled Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312933: Disable and lock checking patch v1.0 https://bugzilla.mozilla.org/attachment.cgi?id=312933&action=edit ...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 312934] Disable and lock checking patch v1.0a
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 312934: Disable and lock checking patch v1.0a https://bugzilla.mozilla.org/attachment.cgi?id=312934&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Correct patch that doesn't try adding a second pref-appearance.js entry to jar.mn ...

superreview canceled: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313728] Onchange patch v1.1
Ian Neal <iann_bugzilla@blueyonder.co.uk> has canceled Ian Neal <iann_bugzilla@blueyonder.co.uk>'s request for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313728: Onchange patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=313728&action=edit ...

superreview requested: [Bug 79603] Disable color controls when 'Use system color' is checked : [Attachment 313728] Onchange patch v1.1
Ian Neal <iann_bugzilla@blueyonder.co.uk> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 79603: Disable color controls when 'Use system color' is checked https://bugzilla.mozilla.org/show_bug.cgi?id=79603 Attachment 313728: Onchange patch v1.1 https://bugzilla.mozilla.org/attachment.cgi?id=313728&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@blueyonder.co.uk> Changes since v1.0a - addressed review comments: * use onchange on preference. * use preference value instead of checkbox setting. * set disabled prop...

superreview granted: [Bug 419167] right/left borders don't adopt user-defined color (colour) scheme (untick 'Allow pages to choose their own colors') : [Attachment 305371] patch without the array
David Baron [:dbaron] <dbaron@mozilla.com> has granted superreview: Bug 419167: right/left borders don't adopt user-defined color (colour) sche= me (untick 'Allow pages to choose their own colors') https://bugzilla.mozilla.org/show_bug.cgi?id=3D419167 Attachment 305371: patch without the array https://bugzilla.mozilla.org/attachment.cgi?id=3D305371&action=3Dedit ------- Additional Comments from David Baron [:dbaron] <dbaron@mozilla.com> r+sr=3Ddbaron.=0D =0D Why don't we just get this one in and I'll worry about converting this code over later...

superreview granted: [Bug 58048] [Pref Stylesheet]`Always use my colors' shouldn't remove colors from form controls [CASCADE]
Boris Zbarsky <bzbarsky@mit.edu> has granted David Baron [:dbaron] <dbaron@mozilla.com>'s request for superreview: Bug 58048: [Pref Stylesheet]`Always use my colors' shouldn't remove colors = from form controls [CASCADE] https://bugzilla.mozilla.org/show_bug.cgi?id=3D58048 Attachment 264970: patch https://bugzilla.mozilla.org/attachment.cgi?id=3D264970&action=3Dedit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >+++ b/layout/style/nsCSSDataBlock.cpp=0D >+ else if (iProp =3D=3D eCSSProperty_color ||=0D ....=0D =0D ...

superreview granted: [Bug 408023] The indicator doesn' t look disabled in a disabled check menu item : [Attachment 292721] Patch
Robert O'Callahan (:roc) <roc@ocallahan.org> has granted Michael Ventnor <ventnor.bugzilla@yahoo.com.au>'s request for superreview: Bug 408023: The indicator doesn't look disabled in a disabled check menu item https://bugzilla.mozilla.org/show_bug.cgi?id=408023 Attachment 292721: Patch https://bugzilla.mozilla.org/attachment.cgi?id=292721&action=edit ...

superreview granted: [Bug 282141] Use system colors pref uses the wrong color for default background : [Attachment 175183] Patch
Dan Mosedale <dmose@mozilla.org> has granted Dan Mosedale <dmose@mozilla.org>'s request for superreview: Bug 282141: Use system colors pref uses the wrong color for default background https://bugzilla.mozilla.org/show_bug.cgi?id=282141 Attachment 175183: Patch https://bugzilla.mozilla.org/attachment.cgi?id=175183&action=edit ...

superreview granted: [Bug 282141] Use system colors pref uses the wrong color for default background : [Attachment 174243] Patch
Christopher A. Aillon <caillon@gmail.com> has granted Christopher A. Aillon <caillon@gmail.com>'s request for superreview: Bug 282141: Use system colors pref uses the wrong color for default background https://bugzilla.mozilla.org/show_bug.cgi?id=282141 Attachment 174243: Patch https://bugzilla.mozilla.org/attachment.cgi?id=174243&action=edit ------- Additional Comments from Christopher A. Aillon <caillon@gmail.com> blizzard says sr=blizzard (looking over my shoulder) ...

superreview granted: [Bug 290788] crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] : [Attachment 181152] Patch
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Frank Wein <bugzilla@mcsmurf.de>'s request for superreview: Bug 290788: crash when try to 'save all' Attachments from MailNews 'File' 'Attachments' Menu [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=290788 Attachment 181152: Patch https://bugzilla.mozilla.org/attachment.cgi?id=181152&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> D'oh! ;-) ...

superreview granted: [Bug 241147] DecodeStructParticle fails on 'sequences' and 'choices' : [Attachment 146641] v1 patch
Johnny Stenback <jst@mozilla.jstenback.com> has granted Darin Fisher (IBM) <darin@meer.net>'s request for superreview: Bug 241147: DecodeStructParticle fails on 'sequences' and 'choices' http://bugzilla.mozilla.org/show_bug.cgi?id=241147 Attachment 146641: v1 patch http://bugzilla.mozilla.org/attachment.cgi?id=146641&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> - rc = DecodeStructParticle(aEncoding, aElement, child, aAttachments, aDestination, getter_AddRefs(after)); + rc = DecodeStruct...