superreview granted: [Bug 439470] Mailing List Dialog for OS X address books doesn't list addresses and isn't read-only : [Attachment 327403] Provide read-only detection for mailing list dialogs.

David Bienvenu <bienvenu@nventure.com> has granted Mark Banner (afk 5-12 July)
<bugzilla@standard8.plus.com>'s request for superreview:
Bug 439470: Mailing List Dialog for OS X address books doesn't list addresses
and isn't read-only
https://bugzilla.mozilla.org/show_bug.cgi?id=439470

Attachment 327403: Provide read-only detection for mailing list dialogs.
https://bugzilla.mozilla.org/attachment.cgi?id=327403&action=edit

------- Additional Comments from David Bienvenu <bienvenu@nventure.com>
Looks good - one comment nit:

read-only? if so,

should be "If so", not "if so".
0
bugzilla
6/30/2008 8:25:34 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
923 Views

Similar Articles

[PageSpeed] 4

Reply:

Similar Artilces:

superreview requested: [Bug 439470] Mailing List Dialog for OS X address books doesn't list addresses and isn't read-only : [Attachment 327403] Provide read-only detection for mailing list dialogs.
Mark Banner (afk 5-12 July) <bugzilla@standard8.plus.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 439470: Mailing List Dialog for OS X address books doesn't list addresses and isn't read-only https://bugzilla.mozilla.org/show_bug.cgi?id=439470 Attachment 327403: Provide read-only detection for mailing list dialogs. https://bugzilla.mozilla.org/attachment.cgi?id=327403&action=edit ------- Additional Comments from Mark Banner (afk 5-12 July) <bugzilla@standard8.plus.com> I wanted to come up with something for this before TB...

superreview canceled: [Bug 439470] Mailing List Dialog for OS X address books doesn't list addresses and isn't read-only : [Attachment 330001] Fix initialisation of directories/mailing lists
Mark Banner <bugzilla@standard8.plus.com> has canceled Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 439470: Mailing List Dialog for OS X address books doesn't list addresses and isn't read-only https://bugzilla.mozilla.org/show_bug.cgi?id=439470 Attachment 330001: Fix initialisation of directories/mailing lists https://bugzilla.mozilla.org/attachment.cgi?id=330001&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> Opps, wrong bug. I'd better move it across. ...

superreview requested: [Bug 439470] Mailing List Dialog for OS X address books doesn't list addresses and isn't read-only : [Attachment 330001] Fix initialisation of directories/mailing lists
Mark Banner <bugzilla@standard8.plus.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 439470: Mailing List Dialog for OS X address books doesn't list addresses and isn't read-only https://bugzilla.mozilla.org/show_bug.cgi?id=439470 Attachment 330001: Fix initialisation of directories/mailing lists https://bugzilla.mozilla.org/attachment.cgi?id=330001&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> So the problem with the code at the moment, is that the maintained lists (of cards) are onl...

superreview granted: [Bug 437903] Can't send emails to OS X mailing lists. : [Attachment 330004] Fix initialisation of directories/mailing lists
David Bienvenu <bienvenu@nventure.com> has granted Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 437903: Can't send emails to OS X mailing lists. https://bugzilla.mozilla.org/show_bug.cgi?id=437903 Attachment 330004: Fix initialisation of directories/mailing lists https://bugzilla.mozilla.org/attachment.cgi?id=330004&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> nit: i can be declared in the for loop: + unsigned int i; + unsigned int nbCards = [cards count]; + nsCOMPtr<nsIAbCard...

superreview requested: [Bug 437903] Can't send emails to OS X mailing lists. : [Attachment 330004] Fix initialisation of directories/mailing lists
Mark Banner <bugzilla@standard8.plus.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 437903: Can't send emails to OS X mailing lists. https://bugzilla.mozilla.org/show_bug.cgi?id=437903 Attachment 330004: Fix initialisation of directories/mailing lists https://bugzilla.mozilla.org/attachment.cgi?id=330004&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> So the problem with the code at the moment, is that the maintained lists (of cards) are only filled in when GetChildCards is called. This is ...

superreview granted: [Bug 439475] Crash [@ConvertToCard] when deleting card/mailing list from Mac OS X Address Book and Thunderbird Address Book is open : [Attachment 326871] The fix
David Bienvenu <bienvenu@nventure.com> has granted Mark Banner <bugzilla@standard8.plus.com>'s request for superreview: Bug 439475: Crash [@ConvertToCard] when deleting card/mailing list from Mac OS X Address Book and Thunderbird Address Book is open https://bugzilla.mozilla.org/show_bug.cgi?id=439475 Attachment 326871: The fix https://bugzilla.mozilla.org/attachment.cgi?id=326871&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> I don't know if it makes sense to put an nsCAutoString in a struct, even if the struct is...

superreview granted: [Bug 437903] Can't send emails to OS X mailing lists. : [Attachment 328102] The fix
David Bienvenu <bienvenu@nventure.com> has granted Mark Banner (afk 5-12 July) <bugzilla@standard8.plus.com>'s request for superreview: Bug 437903: Can't send emails to OS X mailing lists. https://bugzilla.mozilla.org/show_bug.cgi?id=437903 Attachment 328102: The fix https://bugzilla.mozilla.org/attachment.cgi?id=328102&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> r/sr=me, once the comments are addressesed... ...

superreview granted: [Bug 231034] Tab doesn't scroll though address list : [Attachment 140245] updated patch with neil's comments
David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 231034: Tab doesn't scroll though address list http://bugzilla.mozilla.org/show_bug.cgi?id=231034 Attachment 140245: updated patch with neil's comments http://bugzilla.mozilla.org/attachment.cgi?id=140245&action=edit ...

superreview granted: [Bug 301935] Crash when trying to send mail and collected address book doesn't exist : [Attachment 190729] Part 2 - Warn the user
Mark Banner <bugzilla@standard8.demon.co.uk> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 301935: Crash when trying to send mail and collected address book doesn't exist https://bugzilla.mozilla.org/show_bug.cgi?id=301935 Attachment 190729: Part 2 - Warn the user - fix review nits. https://bugzilla.mozilla.org/attachment.cgi?id=190729&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Carrying forward previous r & sr. Requesting approval. Low risk patch changing the ...

superreview granted: [Bug 245325] [Contacts side bar is empty in the compose window] and ["Add to Address Book ..." pane isn't filling in] : [Attachment 150001] new card/list fixes
Seth Spitzer <sspitzer@mozilla.org> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 245325: [Contacts side bar is empty in the compose window] and ["Add to Address Book ..." pane isn't filling in] http://bugzilla.mozilla.org/show_bug.cgi?id=245325 Attachment 150001: new card/list fixes http://bugzilla.mozilla.org/attachment.cgi?id=150001&action=edit ------- Additional Comments from Seth Spitzer <sspitzer@mozilla.org> the changes to mozilla/mailnews look good, but you need mscott to approve ...

superreview granted: [Bug 203866] modutil -list doesn't list all modules in secmod.db : [Attachment 132966] Incorporate Review comments.
Wan-Teh Chang <wchang0222@aol.com> has granted Robert Relyea <rrelyea0264@aol.com>'s request for superreview: Bug 203866: modutil -list doesn't list all modules in secmod.db http://bugzilla.mozilla.org/show_bug.cgi?id=203866 Attachment 132966: Incorporate Review comments. http://bugzilla.mozilla.org/attachment.cgi?id=132966&action=edit ------- Additional Comments from Wan-Teh Chang <wchang0222@aol.com> r=wtc. It's not necessary to fix the nonstandard indentation style. All we want is consistency within the same file. But, since you already di...

superreview requested: [Bug 439475] Crash [@ConvertToCard] when deleting card/mailing list from Mac OS X Address Book and Thunderbird Address Book is open : [Attachment 326871] The fix
Mark Banner <bugzilla@standard8.plus.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 439475: Crash [@ConvertToCard] when deleting card/mailing list from Mac OS X Address Book and Thunderbird Address Book is open https://bugzilla.mozilla.org/show_bug.cgi?id=439475 Attachment 326871: The fix https://bugzilla.mozilla.org/attachment.cgi?id=326871&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.plus.com> This fixes the crash problem completely (in the last patch I was removing items from the hash twice, not a...

superreview granted: [Bug 301935] Crash when trying to send mail and collected address book doesn't exist : [Attachment 190426] Part 2
Scott MacGregor <mscott@mozilla.org> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 301935: Crash when trying to send mail and collected address book doesn't exist https://bugzilla.mozilla.org/show_bug.cgi?id=301935 Attachment 190426: Part 2 - Warn the user before they delete the addr book that is set for collecting https://bugzilla.mozilla.org/attachment.cgi?id=190426&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> yup, I misunderstood. How about changing the dialog wording...

superreview granted: [Bug 368626] Importer (Win Eudora, Address Book). Mailing list nickname not assigned to 'nickname' in Penelope
David Bienvenu <bienvenu@nventure.com> has granted Geoffrey C. Wenger <gwenger@qualcomm.com>'s request for superreview: Bug 368626: Importer (Win Eudora, Address Book). Mailing list nickname not assigned to 'nickname' in Penelope https://bugzilla.mozilla.org/show_bug.cgi?id=368626 Attachment 262174: Patch that fixes bug. Note patch was not created with CVS. https://bugzilla.mozilla.org/attachment.cgi?id=262174&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> I changed this: + if ( !name.IsEmpty() ) + rv =...

Web resources about - superreview granted: [Bug 439470] Mailing List Dialog for OS X address books doesn't list addresses and isn't read-only : [Attachment 327403] Provide read-only detection for mailing list dialogs. - mozilla.dev.super-review

Resources last updated: 12/8/2015 8:20:23 PM