superreview granted: [Bug 428332] Add the MoFo EULA line back to SeaMonkey's about:license now that bug 368091 is fixed : [Attachment 316649] Fix, v1

neil@parkwaycc.co.uk <neil@httl.net> has granted Smokey Ardisson (behind; no
bugmail - do not email) <alqahira@ardisson.org>'s request for superreview:
Bug 428332: Add the MoFo EULA line back to SeaMonkey's about:license now th=
at
bug 368091 is fixed
https://bugzilla.mozilla.org/show_bug.cgi?id=3D428332

Attachment 316649: Fix, v1
https://bugzilla.mozilla.org/attachment.cgi?id=3D316649&action=3Dedit

------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net>
Thanks for doing this!=0D
=0D
>+# the following files are suite-specific overrides of generic Core files:=
=0D
>+*  content/communicator/license.html=09=09=09=09=20=20=20=20=20
(/toolkit/content/license.html)=0D
>+% override chrome://global/content/license.html
chrome://communicator/content/license.html=0D
We're trying to keep the file list in order, so license.html would go in
presumably just before nsContextMenu.js while the override goes just after =
the
package in which the override appears. See suite/locales/jar.mn for example.
Also I think it would be helpful to point out in the comment that the app
licence gets substituted in (and possibly in the Makefile as well).=0D
=0D
(If only the licence had been in xhtml, then it would have been much easier=
 to
substitute stuff in...)=
0
bugzilla
4/20/2008 10:20:40 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
727 Views

Similar Articles

[PageSpeed] 33

Reply:

Similar Artilces:

superreview requested: [Bug 428332] Add the MoFo EULA line back to SeaMonkey's about:license now that bug 368091 is fixed : [Attachment 316649] Fix, v1
Smokey Ardisson (behind; no bugmail - do not email) <alqahira@ardisson.org> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 428332: Add the MoFo EULA line back to SeaMonkey's about:license now that bug 368091 is fixed https://bugzilla.mozilla.org/show_bug.cgi?id=428332 Attachment 316649: Fix, v1 https://bugzilla.mozilla.org/attachment.cgi?id=316649&action=edit ------- Additional Comments from Smokey Ardisson (behind; no bugmail - do not email) <alqahira@ardisson.org> This was a breeze to fix :) Some notes: 1) I stuck this in suit...

superreview granted: [Bug 245066] [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) : [Attachment 156344] proposed fix
Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 245066: [internal] nsPop3Protocol.cpp, back out fix for bug #157644, since david has fixed the problem another way (bug #229374) http://bugzilla.mozilla.org/show_bug.cgi?id=245066 Attachment 156344: proposed fix http://bugzilla.mozilla.org/attachment.cgi?id=156344&action=edit ...

superreview granted: [Bug 280947] Fix for bug 279945 breaks dragging of dynamic images : [Attachment 173629] Fix bz's issues.
Daniel Veditz <dveditz@cruzio.com> has granted Johnny Stenback <jst@mozilla.org>'s request for superreview: Bug 280947: Fix for bug 279945 breaks dragging of dynamic images https://bugzilla.mozilla.org/show_bug.cgi?id=280947 Attachment 173629: Fix bz's issues. https://bugzilla.mozilla.org/attachment.cgi?id=173629&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> sr=dveditz ...

superreview granted: [Bug 340800] [FIX]Line breaks lost in text document's body.innerHTML : [Attachment 227362] Fix
Peter Van der Beken <peterv@propagandism.org> has granted Boris Zbarsky (gone June 26 -- Jul 13) <bzbarsky@mit.edu>'s request for superreview: Bug 340800: [FIX]Line breaks lost in text document's body.innerHTML https://bugzilla.mozilla.org/show_bug.cgi?id=340800 Attachment 227362: Fix https://bugzilla.mozilla.org/attachment.cgi?id=227362&action=edit ...

superreview granted: [Bug 360511] [FIX]Going back to page with URL hash (#foo) doesn't show hash part : [Attachment 245427] Fixes bug, as expected
Jonas Sicking <bugmail@sicking.cc> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 360511: [FIX]Going back to page with URL hash (#foo) doesn't show hash part https://bugzilla.mozilla.org/show_bug.cgi?id=360511 Attachment 245427: Fixes bug, as expected https://bugzilla.mozilla.org/attachment.cgi?id=245427&action=edit ...

superreview granted: [Bug 229737] [RFE] Favicons for XUL error pages : [Attachment 193389] address Neil's comments, fix seamonkey's check
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has granted Mike Connor <mconnor@steelgryphon.com>'s request for superreview: Bug 229737: [RFE] Favicons for XUL error pages https://bugzilla.mozilla.org/show_bug.cgi?id=229737 Attachment 193389: address Neil's comments, fix seamonkey's check https://bugzilla.mozilla.org/attachment.cgi?id=193389&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> >- var url = getWebNavigation().currentURI.spec >+ var url = document.documentURI.spec ...

superreview granted: [Bug 92686] Return inserts line break, should insert paragraph break : [Attachment 156598] fix #3, in answer to brade's and akkana's comments
Johnny Stenback <jst@mozilla.jstenback.com> has granted Johnny Stenback <jst@mozilla.jstenback.com>'s request for superreview: Bug 92686: Return inserts line break, should insert paragraph break https://bugzilla.mozilla.org/show_bug.cgi?id=92686 Attachment 156598: fix #3, in answer to brade's and akkana's comments https://bugzilla.mozilla.org/attachment.cgi?id=156598&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.jstenback.com> sr=jst (and marking brade's r+ too, I'll attach a patch that fixes the issue she comme...

superreview granted: [Bug 360579] [FIX]Fix for bug 326009 doesn't work quite right with more than 2 tabs : [Attachment 245463] Fix
Johnny Stenback <jst@mozilla.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 360579: [FIX]Fix for bug 326009 doesn't work quite right with more than 2 tabs https://bugzilla.mozilla.org/show_bug.cgi?id=360579 Attachment 245463: Fix https://bugzilla.mozilla.org/attachment.cgi?id=245463&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> Yeah, this is obviously the right thing to do. r+sr=jst ...

superreview granted: [Bug 269581] NSS calls C_GetAttributeValue unnecessarily when token is logged in : [Attachment 175370] fixes integrating Bob and Wan-Teh's review comments. Also fix bogus logic
Robert Relyea <rrelyea@redhat.com> has granted Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 269581: NSS calls C_GetAttributeValue unnecessarily when token is logged in https://bugzilla.mozilla.org/show_bug.cgi?id=269581 Attachment 175370: fixes integrating Bob and Wan-Teh's review comments. Also fix bogus logic https://bugzilla.mozilla.org/attachment.cgi?id=175370&action=edit ------- Additional Comments from Robert Relyea <rrelyea@redhat.com> looks good! bob ...

superreview granted: [Bug 157566] Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension : [Attachment 147290] trunk version of the fix with david's review comment
Scott MacGregor <mscott@mozilla.org> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 157566: Enhance MailNews to work with WinZip's "Zip and e-mail" shell extension http://bugzilla.mozilla.org/show_bug.cgi?id=157566 Attachment 147290: trunk version of the fix with david's review comment http://bugzilla.mozilla.org/attachment.cgi?id=147290&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> carrying over david's sr ...

superreview granted: [Bug 242441] Port fix to bug 242082 to SeaMonkey : [Attachment 148964] Fix issues
Alec Flett <alecf@flett.org> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com>'s request for superreview: Bug 242441: Port fix to bug 242082 to SeaMonkey http://bugzilla.mozilla.org/show_bug.cgi?id=242441 Attachment 148964: Fix issues http://bugzilla.mozilla.org/attachment.cgi?id=148964&action=edit ------- Additional Comments from Alec Flett <alecf@flett.org> sr=alecf ...

superreview granted: [Bug 408749] "ASSERTION: A block's child' s next in flow's parent must be a block" with -moz-column, table stuff : [ Attachment 293607] fix assert
Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> has granted Robert O'Callahan (:roc) <roc@ocallahan.org>'s request for superreview: Bug 408749: "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff https://bugzilla.mozilla.org/show_bug.cgi?id=408749 Attachment 293607: fix assert https://bugzilla.mozilla.org/attachment.cgi?id=293607&action=edit ------- Additional Comments from Boris Zbarsky (reviews very slow until spring) <bzbarsky@mit.edu> Looks good. That said, s...

superreview granted: [Bug 306534] [FIX]###!!! ASSERTION: Float frame has wrong parent: 'floatFrame->GetParent() == mBlock', file nsBlockReflowState.cpp, line 835 : [Attachment 205284] Fix
Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky (out of town Dec 12 -- Jan 2) <bzbarsky@mit.edu>'s request for superreview: Bug 306534: [FIX]###!!! ASSERTION: Float frame has wrong parent: 'floatFrame->GetParent() == mBlock', file nsBlockReflowState.cpp, line 835 https://bugzilla.mozilla.org/show_bug.cgi?id=306534 Attachment 205284: Fix https://bugzilla.mozilla.org/attachment.cgi?id=205284&action=edit ...

superreview granted: [Bug 21616] Space after ::first-letter pseudo-element line is larger than between other lines : [Attachment 166184] fix based on MathML's GetBoundingMetrics
Boris Zbarsky <bzbarsky@mit.edu> has granted rbs@maths.uq.edu.au's request for superreview: Bug 21616: Space after ::first-letter pseudo-element line is larger than between other lines https://bugzilla.mozilla.org/show_bug.cgi?id=21616 Attachment 166184: fix based on MathML's GetBoundingMetrics https://bugzilla.mozilla.org/attachment.cgi?id=166184&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> r+sr=bzbarsky, and could you file a bug on making GetBoundingMetrics either have its own ifdef (implied by MOZ_MATHML) or just be alway...

Web resources about - superreview granted: [Bug 428332] Add the MoFo EULA line back to SeaMonkey's about:license now that bug 368091 is fixed : [Attachment 316649] Fix, v1 - mozilla.dev.super-review

Resources last updated: 12/23/2015 10:29:34 AM